fix: address review comments

mhdawson · mhdawson · commit 4d3fc76c692c · 2020-07-06T15:08:54.000-04:00
Signed-off-by: Michael Dawson &lt;michael_dawson@ca.ibm.com&gt;
diff --git a/lib/cli/commands/show.js b/lib/cli/commands/show.js
@@ -1,5 +1,6 @@
 'use strict'
 const support = require('../../../index.js')
+const Arborist = require('@npmcli/arborist')
 
 // print out the information for a module and its
 // children
@@ -35,7 +36,6 @@ module.exports = function (opts) {
       return yargs
     },
     handler: function (argv) {
-      const Arborist = require('@npmcli/arborist')
       const arb = new Arborist()
       arb.loadActual().then(root => {
         printModule(root, 0, argv).then(() => {}, (e) => {
diff --git a/lib/cli/commands/validate.js b/lib/cli/commands/validate.js
@@ -32,14 +32,14 @@ module.exports = function (opts) {
           console.log(errorInSupportElement)
           console.log('Support element should either be true or an Object matching the required schema')
           return
-        } else {
-          try {
-            support.validateSupportElement({ support: supportData }, true)
-          } catch (e) {
-            console.log(errorInSupportElement)
-            console.log(e.prettyValidationErrors)
-            return
-          }
+        }
+
+        try {
+          support.validateSupportElement({ support: supportData }, true)
+        } catch (e) {
+          console.log(errorInSupportElement)
+          console.log(e.prettyValidationErrors)
+          return
         }
 
         // support element was ok so validate the data itself
diff --git a/lib/cli/index.js b/lib/cli/index.js
@@ -57,7 +57,7 @@ module.exports = (options = {}) => {
       'log-level': ['silent', 'verbose']
     })
     .option('canonical', {
-      describe: 'Use canaonical support info even when local info is available',
+      describe: 'Use canonical support info even when local info is available',
       type: 'boolean',
       group: 'preferences'
     })
diff --git a/test/cli/show-local-escape-ok/package.json b/test/cli/show-local-escape-ok/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@pkgjs/support-show-local-escape-ok",
   "version": "0.0.1",
-  "support": "../../artifacts/MySupportInfo.json",
+  "support": "../../fixtures/my-support-info.json",
   "repository": {
     "type": "git",
     "url": "https://github.com/pkgjs/support.git"
diff --git a/test/cli/show-local-escape/expected b/test/cli/show-local-escape/expected
@@ -1 +1 @@
-  @pkgjs/support-show-local-escape(0.0.1) - https://github.com/pkgjs/support/blob/master/MySupportInfo.json
+  @pkgjs/support-show-local-escape(0.0.1) - https://github.com/pkgjs/support/blob/master/my-support-info.json
diff --git a/test/cli/show-local-escape/package.json b/test/cli/show-local-escape/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@pkgjs/support-show-local-escape",
   "version": "0.0.1",
-  "support": "../artifacts/MySupportInfo.json",
+  "support": "../fixtures/my-support-info.json",
   "repository": {
     "type": "git",
     "url": "https://github.com/pkgjs/support.git"
diff --git a/test/cli/show-local-path1/my-support-info.json b/test/cli/show-local-path1/my-support-info.json
diff --git a/test/cli/show-local-path1/package.json b/test/cli/show-local-path1/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@pkgjs/support-show-local-path1",
   "version": "0.0.1",
-  "support": "./MySupportInfo.json",
+  "support": "./my-support-info.json",
   "repository": {
     "type": "git",
     "url": "https://github.com/pkgjs/support-show-local-path1.git"
diff --git a/test/cli/show-local-path2/expected b/test/cli/show-local-path2/expected
@@ -1 +1 @@
-  @pkgjs/show-local-path2(0.0.1) - https://github.com/pkgjs/show-local-path2/blob/master/subdir/MySupportInfo.json
+  @pkgjs/show-local-path2(0.0.1) - https://github.com/pkgjs/show-local-path2/blob/master/subdir/my-support-info.json
diff --git a/test/cli/show-local-path2/package.json b/test/cli/show-local-path2/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@pkgjs/show-local-path2",
   "version": "0.0.1",
-  "support": "./subdir/MySupportInfo.json",
+  "support": "./subdir/my-support-info.json",
   "repository": {
     "type": "git",
     "url": "https://github.com/pkgjs/show-local-path2.git"
diff --git a/test/cli/show-local-path2/subdir1/my-support-info.json b/test/cli/show-local-path2/subdir1/my-support-info.json
diff --git a/test/cli/show-separate-repo-directory1/expected b/test/cli/show-separate-repo-directory1/expected
@@ -1 +1 @@
-  @pkgjs/support-separate-repo-directory1(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir2/MySupportPackage.json
+  @pkgjs/support-separate-repo-directory1(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir2/my-support-package.json
diff --git a/test/cli/show-separate-repo-directory1/package.json b/test/cli/show-separate-repo-directory1/package.json
@@ -12,6 +12,6 @@
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git",
       "directory" : "subdir2"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/show-separate-repo-directory3/expected b/test/cli/show-separate-repo-directory3/expected
@@ -1 +1 @@
-  @pkgjs/support-separate-repo-directory3(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir2/subdir1/MySupportPackage.json
+  @pkgjs/support-separate-repo-directory3(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir2/subdir1/my-support-package.json
diff --git a/test/cli/show-separate-repo-directory3/package.json b/test/cli/show-separate-repo-directory3/package.json
@@ -12,6 +12,6 @@
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git",
       "directory" : "subdir2"
     },
-   "path" : "./subdir1/MySupportPackage.json"
+   "path" : "./subdir1/my-support-package.json"
   }
 }
diff --git a/test/cli/show-separate-repo-path-escape/expected b/test/cli/show-separate-repo-path-escape/expected
@@ -1 +1 @@
-  @pkgjs/support-separate-repo-path-escape(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/MySupportPackage.json
+  @pkgjs/support-separate-repo-path-escape(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/my-support-package.json
diff --git a/test/cli/show-separate-repo-path-escape/package.json b/test/cli/show-separate-repo-path-escape/package.json
@@ -11,6 +11,6 @@
       "type": "git",
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git"
     },
-   "path" : "./subdir1/../../../../MySupportPackage.json"
+   "path" : "./subdir1/../../../../my-support-package.json"
   }
 }
diff --git a/test/cli/show-separate-repo-path1/expected b/test/cli/show-separate-repo-path1/expected
@@ -1 +1 @@
-  @pkgjs/support-separate-repo-path1(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/MySupportPackage.json
+  @pkgjs/support-separate-repo-path1(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/my-support-package.json
diff --git a/test/cli/show-separate-repo-path1/package.json b/test/cli/show-separate-repo-path1/package.json
@@ -11,6 +11,6 @@
       "type": "git",
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/show-separate-repo-path2/expected b/test/cli/show-separate-repo-path2/expected
@@ -1 +1 @@
-  @pkgjs/support-separate-repo-path2(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir1/MySupportPackage.json
+  @pkgjs/support-separate-repo-path2(0.0.1) - https://github.com/pkgjs/support-separate-repo-other/blob/master/subdir1/my-support-package.json
diff --git a/test/cli/show-separate-repo-path2/package.json b/test/cli/show-separate-repo-path2/package.json
@@ -11,6 +11,6 @@
       "type": "git",
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git"
     },
-   "path" : "./subdir1/MySupportPackage.json"
+   "path" : "./subdir1/my-support-package.json"
   }
 }
diff --git a/test/cli/validate-local-repository-bad1/expected b/test/cli/validate-local-repository-bad1/expected
@@ -1,21 +1,21 @@
 Error in support element in package.json
 ENUM should be equal to one of the allowed values
 
-> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
+> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
 
 TYPE should be string
 
-> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
+> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
 
 ONEOF should match exactly one schema in oneOf
 
-> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
+> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
 
 ENUM should be equal to one of the allowed values
 (git)
 
-> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
+> 1 | {"support":{"repository":{"type":"xxx","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
     |                                  ^^^^^ 👈🏽  Did you mean git here?
diff --git a/test/cli/validate-local-repository-bad1/package.json b/test/cli/validate-local-repository-bad1/package.json
@@ -12,6 +12,6 @@
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git",
       "directory" : "subdir2"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/validate-local-repository-bad2/expected b/test/cli/validate-local-repository-bad2/expected
@@ -1,20 +1,20 @@
 Error in support element in package.json
 ENUM should be equal to one of the allowed values
 
-> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
+> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
 
 TYPE should be string
 
-> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
+> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
 
 ONEOF should match exactly one schema in oneOf
 
-> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
+> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
 
 REQUIRED should have required property 'url'
 
-> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
+> 1 | {"support":{"repository":{"type":"git","directory":"subdir2"},"path":"./my-support-package.json"}}
     |                          ^ ☹️  url is missing here!
diff --git a/test/cli/validate-local-repository-bad2/package.json b/test/cli/validate-local-repository-bad2/package.json
@@ -11,6 +11,6 @@
       "type": "git",
       "directory" : "subdir2"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/validate-local-repository-bad3/expected b/test/cli/validate-local-repository-bad3/expected
@@ -1,20 +1,20 @@
 Error in support element in package.json
 ENUM should be equal to one of the allowed values
 
-> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
+> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
 
 TYPE should be string
 
-> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
+> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
 
 ONEOF should match exactly one schema in oneOf
 
-> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
+> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
 
 REQUIRED should have required property 'type'
 
-> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./MySupportPackage.json"}}
+> 1 | {"support":{"repository":{"url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2"},"path":"./my-support-package.json"}}
     |                          ^ ☹️  type is missing here!
diff --git a/test/cli/validate-local-repository-bad3/package.json b/test/cli/validate-local-repository-bad3/package.json
@@ -11,6 +11,6 @@
       "url" : "https://github.com/pkgjs/support-separate-repo-other.git",
       "directory" : "subdir2"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/validate-local-repository-bad4/expected b/test/cli/validate-local-repository-bad4/expected
@@ -1,20 +1,20 @@
 Error in support element in package.json
 ENUM should be equal to one of the allowed values
 
-> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
+> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  enum should be equal to one of the allowed values
 
 TYPE should be string
 
-> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
+> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  type should be string
 
 ONEOF should match exactly one schema in oneOf
 
-> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./MySupportPackage.json"}}
-    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
+> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./my-support-package.json"}}
+    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 👈🏽  oneOf should match exactly one schema in oneOf
 
 ADDTIONAL PROPERTY should NOT have additional properties
 
-> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./MySupportPackage.json"}}
+> 1 | {"support":{"repository":{"type":"git","url":"https://github.com/pkgjs/support-separate-repo-other.git","directory":"subdir2","extra":"123"},"path":"./my-support-package.json"}}
     |                                                                                                                               ^^^^^^^ 😲  extra is not expected to be here!
diff --git a/test/cli/validate-local-repository-bad4/package.json b/test/cli/validate-local-repository-bad4/package.json
@@ -13,6 +13,6 @@
       "directory" : "subdir2",
       "extra": "123"
     },
-   "path" : "./MySupportPackage.json"
+   "path" : "./my-support-package.json"
   }
 }
diff --git a/test/cli/validate-local-repository-bad5/expected b/test/cli/validate-local-repository-bad5/expected
diff --git a/test/cli/validate-local-repository-bad5/package.json b/test/cli/validate-local-repository-bad5/package.json
diff --git a/test/cli/validate-local-repository1/expected b/test/cli/validate-local-repository1/expected
diff --git a/test/cli/validate-local-repository1/package.json b/test/cli/validate-local-repository1/package.json
diff --git a/test/fixtures/my-support-info.json b/test/fixtures/my-support-info.json

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@pkgjs/support-show-local-escape-ok",`
`3`	`3`	`"version": "0.0.1",`
`4`		`- "support": "../../artifacts/MySupportInfo.json",`
	`4`	`+ "support": "../../fixtures/my-support-info.json",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
`7`	`7`	`"url": "https://github.com/pkgjs/support.git"`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`- @pkgjs/support-show-local-escape(0.0.1) - https://github.com/pkgjs/support/blob/master/MySupportInfo.json`
	`1`	`+ @pkgjs/support-show-local-escape(0.0.1) - https://github.com/pkgjs/support/blob/master/my-support-info.json`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@pkgjs/support-show-local-path1",`
`3`	`3`	`"version": "0.0.1",`
`4`		`- "support": "./MySupportInfo.json",`
	`4`	`+ "support": "./my-support-info.json",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
`7`	`7`	`"url": "https://github.com/pkgjs/support-show-local-path1.git"`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`- @pkgjs/show-local-path2(0.0.1) - https://github.com/pkgjs/show-local-path2/blob/master/subdir/MySupportInfo.json`
	`1`	`+ @pkgjs/show-local-path2(0.0.1) - https://github.com/pkgjs/show-local-path2/blob/master/subdir/my-support-info.json`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@pkgjs/show-local-path2",`
`3`	`3`	`"version": "0.0.1",`
`4`		`- "support": "./subdir/MySupportInfo.json",`
	`4`	`+ "support": "./subdir/my-support-info.json",`
`5`	`5`	`"repository": {`
`6`	`6`	`"type": "git",`
`7`	`7`	`"url": "https://github.com/pkgjs/show-local-path2.git"`