Ensure the tmpdir is dropped

Author: mxcl

.github/workflows/ci.yml

@@ -150,6 +150,10 @@ jobs:
         if: ${{ matrix.os == 'ubuntu-latest' }}
         # ^^ only on one platform as wasteful otherwise
 
+      - run: if [ $(find ~/.pkgx -name .tmp\* -type d | wc -l) -gt 0 ]; then
+            exit 1;
+          fi
+
       - name: generate coverage
         run: |
           cargo install rustfilt

crates/lib/src/install.rs

@@ -103,7 +103,7 @@ where
 
     // Step 5: atomically move from temp dir to installation location
     let partial_path = format!("{}/v{}", pkg.project, pkg.version.raw);
-    fs::rename(temp_dir.into_path().join(&partial_path), &dst_path)?;
+    fs::rename(temp_dir.path().join(&partial_path), &dst_path)?;
 
     let installation = Installation {
         path: dst_path,