Merge pull request #1173 from kaitlinnewson/12182-3_3_0

bozana · web-flow · commit 08490ec00452 · 2026-01-07T14:36:26.000+01:00
pkp/pkp-lib#12182 remove ucfirst from names in crossref plugin
diff --git a/plugins/importexport/crossref/filter/PreprintCrossrefXmlFilter.inc.php b/plugins/importexport/crossref/filter/PreprintCrossrefXmlFilter.inc.php
@@ -163,8 +163,8 @@ function createPostedContentNode($doc, $publication, $submission) {
 				// Check if both givenName and familyName is set for the submission language.
 				if (!empty($familyNames[$locale]) && !empty($givenNames[$locale])) {
 					$personNameNode->setAttribute('language', PKPLocale::getIso1FromLocale($locale));
-					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$locale]), ENT_COMPAT, 'UTF-8')));
-					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyNames[$locale]), ENT_COMPAT, 'UTF-8')));
+					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars($givenNames[$locale], ENT_COMPAT, 'UTF-8')));
+					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($familyNames[$locale], ENT_COMPAT, 'UTF-8')));
 
 					$hasAltName = false;
 					foreach($familyNames as $otherLocal => $familyName) {
@@ -179,17 +179,17 @@ function createPostedContentNode($doc, $publication, $submission) {
 							$nameNode = $doc->createElementNS($deployment->getNamespace(), 'name');
 							$nameNode->setAttribute('language', PKPLocale::getIso1FromLocale($otherLocal));
 
-							$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyName), ENT_COMPAT, 'UTF-8')));
+							$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($familyName, ENT_COMPAT, 'UTF-8')));
 							if (isset($givenNames[$otherLocal]) && !empty($givenNames[$otherLocal])) {
-								$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$otherLocal]), ENT_COMPAT, 'UTF-8')));
+								$nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars($givenNames[$otherLocal], ENT_COMPAT, 'UTF-8')));
 							}
 
 							$altNameNode->appendChild($nameNode);
 						}
 					}
 
 				} else {
-					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($givenNames[$locale]), ENT_COMPAT, 'UTF-8')));
+					$personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($givenNames[$locale], ENT_COMPAT, 'UTF-8')));
 				}
 
 				if ($author->getData('orcid')) {
@@ -285,5 +285,3 @@ function createRelationsDataNode($doc, $parentDoi) {
 		return $relationsDataNode;
 	}
 }
-
-

Original file line number	Diff line number	Diff line change
`@@ -163,8 +163,8 @@ function createPostedContentNode($doc, $publication, $submission) {`
`163`	`163`	`// Check if both givenName and familyName is set for the submission language.`
`164`	`164`	`if (!empty($familyNames[$locale]) && !empty($givenNames[$locale])) {`
`165`	`165`	`$personNameNode->setAttribute('language', PKPLocale::getIso1FromLocale($locale));`
`166`		`- $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$locale]), ENT_COMPAT, 'UTF-8')));`
`167`		`- $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyNames[$locale]), ENT_COMPAT, 'UTF-8')));`
	`166`	`+ $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars($givenNames[$locale], ENT_COMPAT, 'UTF-8')));`
	`167`	`+ $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($familyNames[$locale], ENT_COMPAT, 'UTF-8')));`
`168`	`168`
`169`	`169`	`$hasAltName = false;`
`170`	`170`	`foreach($familyNames as $otherLocal => $familyName) {`
`@@ -179,17 +179,17 @@ function createPostedContentNode($doc, $publication, $submission) {`
`179`	`179`	`$nameNode = $doc->createElementNS($deployment->getNamespace(), 'name');`
`180`	`180`	`$nameNode->setAttribute('language', PKPLocale::getIso1FromLocale($otherLocal));`
`181`	`181`
`182`		`- $nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($familyName), ENT_COMPAT, 'UTF-8')));`
	`182`	`+ $nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($familyName, ENT_COMPAT, 'UTF-8')));`
`183`	`183`	`if (isset($givenNames[$otherLocal]) && !empty($givenNames[$otherLocal])) {`
`184`		`- $nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars(ucfirst($givenNames[$otherLocal]), ENT_COMPAT, 'UTF-8')));`
	`184`	`+ $nameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'given_name', htmlspecialchars($givenNames[$otherLocal], ENT_COMPAT, 'UTF-8')));`
`185`	`185`	`}`
`186`	`186`
`187`	`187`	`$altNameNode->appendChild($nameNode);`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`} else {`
`192`		`- $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars(ucfirst($givenNames[$locale]), ENT_COMPAT, 'UTF-8')));`
	`192`	`+ $personNameNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'surname', htmlspecialchars($givenNames[$locale], ENT_COMPAT, 'UTF-8')));`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`if ($author->getData('orcid')) {`
`@@ -285,5 +285,3 @@ function createRelationsDataNode($doc, $parentDoi) {`
`285`	`285`	`return $relationsDataNode;`
`286`	`286`	`}`
`287`	`287`	`}`
`288`		`-`
`289`		`-`