Decision Documentation for 3.4 and 3.5 - talking about functions that aren't there

[JakobRing]

I'm currently working on a plugin for OJS 3.5, and I wanted to add an Editorial Decision Button. Before I found the Plugin-Guide for that, I read through the "Decision" Documentation for 3.5 (same as 3.4) and I noticed that the places the examples are talking about don't exist.

pkp-docs/dev/documentation/en/decisions.md

Line 423 in c914420

protected function getStageDecisionTypes(int $stageId): array

I understand that

To add or remove these buttons from the submission's workflow page, modify the WorkflowHandler.

talks about the WorkflowHandler that is already there and the function inside the WorkflowHandler has to be changed.

But the getStageDecisionTypes() in the example afterwards is not there in the WorkflowHandler . Also the Hook-Call is made from an entirely different place than the WorkflowHandler so extending it to add this code makes no sense I guess?

Also the Hook-Call is made with the syntax of 3.3 HookRegistry::call('Workflow::Decisions', [&$decisionTypes, $stageId]); instead of the new Hook::call('Workflow::Decisions', [&$decisionTypes, $stageId]).

I hope I don't miss something here.

[asmecher]

(I tagged @jardakotesovec on your discussion re: extending editor decisions via the new UI tools -- that will probably lead to a concrete decision on best approaches that will inform how we update this example. Thanks for reporting!)

[jardakotesovec]

@JakobRing Thanks for pointing out the outdated docs. We will make the updates.

In your case it seems that you don't actually care about adding actual editorial decision - but rather custom button that do what you need to do, right?

Have you discovered the examples&docs on extending some of these redesigned UI? We had couple of links in the release notebook. But need to look into the current docs to make sure its easier to discover.

Following that approach - there is bit of annoying boilerplate at the beginning - but its lot more flexible to add any UI element to the submission/workflow page and write custom logic what it should do.

https://stable-3_5_0--6555d3db80418bb1681b8b17.chromatic.com/?path=/docs/guide-plugins--docs

[JakobRing]

@jardakotesovec Thank you!
Yeah that is indeed the case.

I will look into that docs. If I have any questions I would come back to you if that is ok?

[jardakotesovec]

@JakobRing Sure, I will keep this opened to track the docs update which you pointed out. But if you are having difficulties with your use case its fine to add comment here as well. I will just ask you if you can just update the forum once you have good solution to the problem to share it with others there, thanks!

[JakobRing]

I'll do!

Thanks :)