-
Notifications
You must be signed in to change notification settings - Fork 474
Open
Open
Copy link
Labels
Bug:1:MinorA bug found in uncommon paths, with low consequences, limited users or has an easy workaroundA bug found in uncommon paths, with low consequences, limited users or has an easy workaround
Milestone
Description
Valid Title
- I have updated the title to accurately reflect the bug description
Description
In OPS categories uses "preprints" (rather than "catalog" in OJS/OMP) for defining paths to content related to categories (including URLs to category views and images for the categories). This leads to a few issues in the code which don't currently account for this difference:
- On the category editing form, the sample URL displays the incorrect path
- When uploading images to a category, the resulting paths to the images are incorrect, meaning the image doesn't load on the form or on the front-end page for the category
- In the "browse" plugin, the paths to the categories that appear in the block are not correct (see also Block links redirect and Highlight Issue in OPS 3.3 browse#7)
This issue has been partially fixed for OPS 3.5/main as part of #6002, except for the issue in the browse plugin.
Steps to Reproduce
- Login with a manager or admin role
- Navigate to Settings > Server > Categories
- Click Edit under an existing category, or make a new one
- Notice that the sample URL is not correct on the form
- Upload an image and save, then edit the category form again to see the broken image thumbnail
- Go to the front-end page for the category and also note the broken image link
Expected Result
The sample URLs and paths to images should be correct.
Actual Result
The sample URLs and paths to images are not correct and images for categories are broken.
Environment Details
No response
Application Version
OPS, all versions
Logs
No response
Additional Information
Incorrect sample URL which should use "preprints" and not "catalog"(OPS 3.4):
Broken cover image on form (OPS 3.4):
Pull Requests
- pkp-lib 3.3: pkp/pkp-lib#12003 fix category links for OPS #12424
- OPS 3.3: pkp/pkp-lib#12003 fix category links for OPS ops#1221
- browse 3.3: pkp/pkp-lib#12003 fix category paths for OPS browse#16
- pkp-lib 3.4: pkp/pkp-lib#12003 fix category links for OPS #12452
- OPS 3.4: pkp/pkp-lib#12003 fix category links for OPS ops#1235
- browse 3.4: pkp/pkp-lib#12003 fix category paths for OPS browse#17
- browse 3.5: pkp/pkp-lib#12003 fix category paths for OPS browse#18
- browse main: pkp/pkp-lib#12003 fix category paths for OPS browse#19
Submodule updates only
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Bug:1:MinorA bug found in uncommon paths, with low consequences, limited users or has an easy workaroundA bug found in uncommon paths, with low consequences, limited users or has an easy workaround