refactor: enhance memory pool logging for RX/TX queues in pktgen

Signed-off-by: Keith Wiles <keith.wiles@intel.com>

Author: KeithWiles

app/l2p.c

@@ -79,7 +79,7 @@ l2p_pktmbuf_create(const char *type, l2p_port_t *port, uint16_t qid, int nb_mbuf
                  "Cannot create mbuf pool (%s) port %d, queue %u, nb_mbufs %d, NUMA %d: %s\n", name,
                  port->pid, qid, nb_mbufs, sid, rte_strerror(rte_errno));
 
-    pktgen_log_info("  Create: '%-*s' - Memory used (MBUFs %'6u x size %'6u) = %'8lu KB @ %p\n", 16,
+    pktgen_log_info("  Create: '%-*s' - Memory used (MBUFs %'6u x size %'6u) = %'8lu KB @ %p\n", 24,
                     name, nb_mbufs, bufSize, sz / 1024, mp);
 
     return mp;

app/pktgen-cmds.c

@@ -1221,16 +1221,28 @@ debug_mempool_dump(port_info_t *pinfo __rte_unused, char *name __rte_unused)
     all = !strcmp(name, "all");
 
     if (all || !strcmp(name, "rx")) {
-        for (uint16_t q = 0; q < l2p_get_rxcnt(pinfo->pid); q++)
-            rte_mempool_dump(stdout, l2p_get_rx_mp(pinfo->pid, q));
+        for (uint16_t q = 0; q < l2p_get_rxcnt(pinfo->pid); q++) {
+            struct rte_mempool *mp = l2p_get_rx_mp(pinfo->pid, q);
+            if (mp)
+                fprintf(stdout, "\nPort %u RX qid %u: %s @ %p\n", pinfo->pid, q, mp->name, mp);
+            __mempool_dump(stdout, mp);
+        }
     }
     if (all || !strcmp(name, "tx")) {
-        for (uint16_t q = 0; q < l2p_get_txcnt(pinfo->pid); q++)
-            __mempool_dump(stdout, l2p_get_tx_mp(pinfo->pid, q));
+        for (uint16_t q = 0; q < l2p_get_txcnt(pinfo->pid); q++) {
+            struct rte_mempool *mp = l2p_get_tx_mp(pinfo->pid, q);
+            if (mp)
+                fprintf(stdout, "\nPort %u TX qid %u: %s @ %p\n", pinfo->pid, q, mp->name, mp);
+            __mempool_dump(stdout, mp);
+        }
     }
     if (all || !strcmp(name, "arp")) {
-        for (uint16_t q = 0; q < l2p_get_txcnt(pinfo->pid); q++)
-            __mempool_dump(stdout, l2p_get_sp_mp(pinfo->pid, q));
+        for (uint16_t q = 0; q < l2p_get_txcnt(pinfo->pid); q++) {
+            struct rte_mempool *mp = l2p_get_sp_mp(pinfo->pid, q);
+            if (mp)
+                fprintf(stdout, "\nPort %u SP qid %u: %s @ %p\n", pinfo->pid, q, mp->name, mp);
+            __mempool_dump(stdout, mp);
+        }
     }
 }
 

app/pktgen.c

@@ -1058,8 +1058,10 @@ pktgen_main_rxtx_loop(void)
     rx_qid = l2p_get_rxqid(lid);
     tx_qid = l2p_get_txqid(lid);
 
-    printf("RX/TX lid %3d, pid %2d, qids %2d/%2d Mempool %-16s @ %p\n", lid, pinfo->pid, rx_qid,
-           tx_qid, l2p_get_tx_mp(pinfo->pid, tx_qid)->name, l2p_get_tx_mp(pinfo->pid, tx_qid));
+    printf("RX/TX lid %3d, pid %2d, qids %2d/%2d RX-MP %-16s @ %p TX-MP %-16s @ %p\n", lid,
+           pinfo->pid, rx_qid, tx_qid, l2p_get_rx_mp(pinfo->pid, rx_qid)->name,
+           l2p_get_rx_mp(pinfo->pid, rx_qid), l2p_get_tx_mp(pinfo->pid, tx_qid)->name,
+           l2p_get_tx_mp(pinfo->pid, tx_qid));
 
     while (pktgen.force_quit == 0) {
         /* Process RX */
@@ -1115,7 +1117,7 @@ pktgen_main_tx_loop(void)
 
     tx_qid = l2p_get_txqid(lid);
 
-    printf("TX lid %3d, pid %2d, qid %2d, Mempool %-16s @ %p\n", lid, pinfo->pid, tx_qid,
+    printf("TX lid %3d, pid %2d, qid %2d, TX-MP %-16s @ %p\n", lid, pinfo->pid, tx_qid,
            l2p_get_tx_mp(pinfo->pid, tx_qid)->name, l2p_get_tx_mp(pinfo->pid, tx_qid));
 
     while (unlikely(pktgen.force_quit == 0)) {
@@ -1166,7 +1168,7 @@ pktgen_main_rx_loop(void)
     pinfo  = l2p_get_pinfo_by_lcore(lid);
     rx_qid = l2p_get_rxqid(lid);
 
-    printf("RX lid %3d, pid %2d, qid %2d, Mempool %-16s @ %p\n", lid, pinfo->pid, rx_qid,
+    printf("RX lid %3d, pid %2d, qid %2d, RX-MP %-16s @ %p\n", lid, pinfo->pid, rx_qid,
            l2p_get_rx_mp(pinfo->pid, rx_qid)->name, l2p_get_rx_mp(pinfo->pid, rx_qid));
 
     while (pktgen.force_quit == 0)