Skip to content

Commit d200d30

Browse files
committed
merge_vars: fix shared-prefix conflicts
Example: the suffix "files__to_merge" also matches "wireless_profiles__to_merge" which caused funny issues. Let's also match on the leading underscores to prevent that.
1 parent 740c1dd commit d200d30

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

group_vars/all/general.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ sysupgrade_preserve_custom_files:
3232

3333
image_search_pattern: "*-sysupgrade.*"
3434

35-
all_sysctl__to_merge:
35+
all__sysctl__to_merge:
3636
# when oom kicks in most likely something broke. Panic/Reboot then
3737
vm.panic_on_oom: 1
3838

group_vars/role_corerouter/general.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
wireless_profile: disable
44

5-
role_corerouter_sysctl__to_merge:
5+
role_corerouter__sysctl__to_merge:
66
net.netfilter.nf_conntrack_max: 131072

group_vars/role_gateway/general.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ freifunk_wahlkreis_announcement_prefix: 44
2121
local_asn: 44194
2222
peer_asn: 25291
2323

24-
role_gateway_sysctl__to_merge:
24+
role_gateway__sysctl__to_merge:
2525
net.netfilter.nf_conntrack_max: 524288
2626

2727
## WIREGUARD SECTION
Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,44 @@
11
---
22
- name: Merge packages variable
33
merge_vars:
4-
suffix_to_merge: packages__to_merge
4+
suffix_to_merge: __packages__to_merge
55
merged_var_name: packages
66
expected_type: list
77

88
- name: Merge disabled_services variable
99
merge_vars:
10-
suffix_to_merge: disabled_services__to_merge
10+
suffix_to_merge: __disabled_services__to_merge
1111
merged_var_name: disabled_services
1212
expected_type: list
1313

1414
- name: Merge wireless_profiles variable
1515
merge_vars:
16-
suffix_to_merge: wireless_profiles__to_merge
16+
suffix_to_merge: __wireless_profiles__to_merge
1717
merged_var_name: wireless_profiles
1818
expected_type: list
1919

2020
- name: Merge ssh_keys variable
2121
merge_vars:
22-
suffix_to_merge: ssh_keys__to_merge
22+
suffix_to_merge: __ssh_keys__to_merge
2323
merged_var_name: ssh_keys
2424
expected_type: list
2525
when: ssh_keys is undefined
2626

2727
- name: Merge sysctl variable
2828
merge_vars:
29-
suffix_to_merge: sysctl__to_merge
29+
suffix_to_merge: __sysctl__to_merge
3030
merged_var_name: sysctl
3131
expected_type: dict
3232

3333
- name: Merge rclocal variable
3434
merge_vars:
35-
suffix_to_merge: rclocal__to_merge
35+
suffix_to_merge: __rclocal__to_merge
3636
merged_var_name: rclocal
3737
expected_type: list
3838

3939
- name: "Merge channel_assignments variables"
4040
merge_vars:
41-
suffix_to_merge: "{{ item.split('__')[1] + '__to_merge' }}"
41+
suffix_to_merge: "__{{ item.split('__')[1] + '__to_merge' }}"
4242
merged_var_name: "{{ item.split('__')[1] }}"
4343
expected_type: dict
4444
loop: "{{ hostvars[inventory_hostname] | select('match', '.*__channel_assignments_.*') }}"

0 commit comments

Comments
 (0)