Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Commit 31bce35

Browse files
committed
adjust cookie implementation
1 parent 8ebd25d commit 31bce35

File tree

2 files changed

+7
-32
lines changed

2 files changed

+7
-32
lines changed

SocketIO.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ typedef enum {
7171
BOOL _isConnecting;
7272
BOOL _useSecure;
7373

74+
NSArray *_cookies;
75+
7476
NSURLConnection *_handshake;
7577

7678
// heartbeat
@@ -95,19 +97,16 @@ typedef enum {
9597
@property (nonatomic, readonly) NSString *sid;
9698
@property (nonatomic, readonly) NSTimeInterval heartbeatTimeout;
9799
@property (nonatomic) BOOL useSecure;
100+
@property (nonatomic) NSArray *cookies;
98101
@property (nonatomic, readonly) BOOL isConnected, isConnecting;
99102
@property (nonatomic, weak) id<SocketIODelegate> delegate;
100103
@property (nonatomic) BOOL returnAllDataFromAck;
101104

102105
- (id) initWithDelegate:(id<SocketIODelegate>)delegate;
103106
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port;
104107
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params;
105-
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withCookieParams:(NSDictionary *)cookieParams;
106108
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withNamespace:(NSString *)endpoint;
107-
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withCookieParams:(NSDictionary *)cookieParams withNamespace:(NSString *)endpoint;
108109
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withNamespace:(NSString *)endpoint withConnectionTimeout: (NSTimeInterval) connectionTimeout;
109-
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withCookieParams:(NSDictionary *)cookieParams withNamespace:(NSString *)endpoint withConnectionTimeout: (NSTimeInterval) connectionTimeout;
110-
111110

112111
- (void) disconnect;
113112
- (void) disconnectForced;

SocketIO.m

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ @implementation SocketIO
7979
@synthesize isConnected = _isConnected,
8080
isConnecting = _isConnecting,
8181
useSecure = _useSecure,
82+
cookies = _cookies,
8283
delegate = _delegate,
8384
heartbeatTimeout = _heartbeatTimeout,
8485
returnAllDataFromAck = _returnAllDataFromAck;
@@ -106,11 +107,6 @@ - (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDic
106107
[self connectToHost:host onPort:port withParams:params withNamespace:@"" withConnectionTimeout:defaultConnectionTimeout];
107108
}
108109

109-
- (void) connectToHost:(NSString *)host onPort:(NSInteger)port withParams:(NSDictionary *)params withCookieParams:(NSDictionary *)cookieParams
110-
{
111-
[self connectToHost:host onPort:port withParams:params withCookieParams:cookieParams withNamespace:@"" withConnectionTimeout:defaultConnectionTimeout];
112-
}
113-
114110
- (void) connectToHost:(NSString *)host
115111
onPort:(NSInteger)port
116112
withParams:(NSDictionary *)params
@@ -122,25 +118,6 @@ - (void) connectToHost:(NSString *)host
122118
- (void) connectToHost:(NSString *)host
123119
onPort:(NSInteger)port
124120
withParams:(NSDictionary *)params
125-
withCookieParams:(NSDictionary *)cookieParams
126-
withNamespace:(NSString *)endpoint
127-
{
128-
[self connectToHost:host onPort:port withParams:params withCookieParams:cookieParams withNamespace:endpoint withConnectionTimeout:defaultConnectionTimeout];
129-
}
130-
131-
- (void) connectToHost:(NSString *)host
132-
onPort:(NSInteger)port
133-
withParams:(NSDictionary *)params
134-
withNamespace:(NSString *)endpoint
135-
withConnectionTimeout:(NSTimeInterval)connectionTimeout
136-
{
137-
[self connectToHost:host onPort:port withParams:params withCookieParams:nil withNamespace:endpoint withConnectionTimeout:defaultConnectionTimeout];
138-
}
139-
140-
- (void) connectToHost:(NSString *)host
141-
onPort:(NSInteger)port
142-
withParams:(NSDictionary *)params
143-
withCookieParams:(NSDictionary *)cookieParams
144121
withNamespace:(NSString *)endpoint
145122
withConnectionTimeout:(NSTimeInterval)connectionTimeout
146123
{
@@ -172,10 +149,9 @@ - (void) connectToHost:(NSString *)host
172149
cachePolicy:NSURLRequestReloadIgnoringLocalAndRemoteCacheData
173150
timeoutInterval:connectionTimeout];
174151

175-
if (cookieParams) {
176-
NSHTTPCookie *cookie = [NSHTTPCookie cookieWithProperties:cookieParams];
177-
NSArray* cookieArray = [NSArray arrayWithObjects: cookie, nil];
178-
NSDictionary * headers = [NSHTTPCookie requestHeaderFieldsWithCookies:cookieArray];
152+
if (_cookies != nil) {
153+
DEBUGLOG(@"Adding cookie(s): %@", [_cookies description]);
154+
NSDictionary *headers = [NSHTTPCookie requestHeaderFieldsWithCookies:_cookies];
179155
[request setAllHTTPHeaderFields:headers];
180156
}
181157

0 commit comments

Comments
 (0)