Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Commit b9a8c69

Browse files
committed
finally remove deprecated delegate methods
1 parent e111532 commit b9a8c69

File tree

2 files changed

+0
-18
lines changed

2 files changed

+0
-18
lines changed

SocketIO.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,6 @@ typedef enum {
5252
- (void) socketIO:(SocketIO *)socket didReceiveEvent:(SocketIOPacket *)packet;
5353
- (void) socketIO:(SocketIO *)socket didSendMessage:(SocketIOPacket *)packet;
5454
- (void) socketIO:(SocketIO *)socket onError:(NSError *)error;
55-
56-
// TODO: deprecated -> to be removed
57-
- (void) socketIO:(SocketIO *)socket failedToConnectWithError:(NSError *)error __attribute__((deprecated));
58-
- (void) socketIOHandshakeFailed:(SocketIO *)socket __attribute__((deprecated));
5955
@end
6056

6157

SocketIO.m

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -686,13 +686,6 @@ - (void) connection:(NSURLConnection *)connection didFailWithError:(NSError *)er
686686

687687
[_delegate socketIO:self onError:err];
688688
}
689-
// TODO: deprecated - to be removed
690-
else if ([_delegate respondsToSelector:@selector(socketIOHandshakeFailed:)]) {
691-
#pragma clang diagnostic push
692-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
693-
[_delegate socketIOHandshakeFailed:self];
694-
#pragma clang diagnostic pop
695-
}
696689
}
697690

698691
- (void) connectionDidFinishLoading:(NSURLConnection *)connection
@@ -770,13 +763,6 @@ - (void) connectionDidFinishLoading:(NSURLConnection *)connection
770763
if ([_delegate respondsToSelector:@selector(socketIO:onError:)]) {
771764
[_delegate socketIO:self onError:error];
772765
}
773-
// TODO: deprecated - to be removed
774-
else if ([_delegate respondsToSelector:@selector(socketIO:failedToConnectWithError:)]) {
775-
#pragma clang diagnostic push
776-
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
777-
[_delegate socketIO:self failedToConnectWithError:error];
778-
#pragma clang diagnostic pop
779-
}
780766

781767
// make sure to do call all cleanup code
782768
[self onDisconnect:error];

0 commit comments

Comments
 (0)