Skip to content

Commit a7d9072

Browse files
committed
Pod eviction filter flags should not be mutually exclusive
Apparently I temporarily forgot how switches work in Go.
1 parent 746de97 commit a7d9072

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

cmd/draino/draino.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -87,12 +87,13 @@ func main() {
8787
kingpin.FatalIfError(err, "cannot create Kubernetes client")
8888

8989
pf := []kubernetes.PodFilterFunc{kubernetes.MirrorPodFilter}
90-
switch {
91-
case !*evictLocalStoragePods:
90+
if !*evictLocalStoragePods {
9291
pf = append(pf, kubernetes.LocalStoragePodFilter)
93-
case !*evictUnreplicatedPods:
92+
}
93+
if !*evictUnreplicatedPods {
9494
pf = append(pf, kubernetes.UnreplicatedPodFilter)
95-
case !*evictDaemonSetPods:
95+
}
96+
if !*evictDaemonSetPods {
9697
pf = append(pf, kubernetes.NewDaemonSetPodFilter(cs))
9798
}
9899
var h cache.ResourceEventHandler = kubernetes.NewDrainingResourceEventHandler(

0 commit comments

Comments
 (0)