Skip to content

Commit 00e2372

Browse files
guydavenportGuy Davenportjloux-brapiBrapiCoordinatorSelby
authored
Added missing descriptions and some minor changes in Schema (#654)
* Added missing descriptions and some minor changes in Schema * merge in from #651 * Update Specification/BrAPI-Schema/BrAPI-Germplasm/Cross.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * Update Specification/BrAPI-Schema/BrAPI-Germplasm/PlannedCross.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * Update Specification/BrAPI-Schema/BrAPI-Phenotyping/ObservationUnit.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * Update Specification/BrAPI-Schema/BrAPI-Phenotyping/Scale.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * Update Specification/BrAPI-Schema/BrAPI-Core/Study.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * Update Specification/BrAPI-Schema/BrAPI-Phenotyping/Scale.json Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> * updated cross description --------- Co-authored-by: Guy Davenport <guy.davenport@partners.basf.com> Co-authored-by: jloux-brapi <jloux.brapi@gmail.com> Co-authored-by: Peter Selby <ps664@cornell.edu>
1 parent e1c956b commit 00e2372

File tree

15 files changed

+68
-55
lines changed

15 files changed

+68
-55
lines changed

Specification/BrAPI-Schema/BrAPI-Common/AdditionalInfo.json

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,18 @@
22
"$defs": {
33
"AdditionalInfo": {
44
"additionalProperties": {
5-
"type": "string"
5+
"description": "A free space containing any additional information related to a particular object.",
6+
"type": [
7+
"null",
8+
"string"
9+
]
610
},
711
"description": "A free space containing any additional information related to a particular object. A data source may provide any JSON object, unrestricted by the BrAPI specification.",
812
"title": "AdditionalInfo",
9-
"type": "object"
13+
"type": [
14+
"null",
15+
"object"
16+
]
1017
}
1118
},
1219
"$id": "https://brapi.org/Specification/BrAPI-Schema/Components/Common/AdditionalInfo.json",

Specification/BrAPI-Schema/BrAPI-Core/DataLink.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
{
22
"$defs": {
33
"DataLink": {
4+
"description": "A link to a data file associated with a study. Extra data could include notes, images, and reference data. Based on the MIAPPE V1.1 (DM-38) Data file description.",
45
"properties": {
56
"dataFormat": {
67
"description": "The structure of the data within a file. For example - VCF, table, image archive, multispectral image archives in EDAM ontology (used in Galaxy)\n\nMIAPPE V1.1 (DM-38) Data file description - Description of the format of the data file. May be a standard file format name, or a description of organization of the data in a tabular file.",

Specification/BrAPI-Schema/BrAPI-Core/List.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,10 @@
103103
"type": "object",
104104
"description": "A List represents a collection of other BrAPI data objects. Typically these are custom lists generated by a user to keep track of interesting data. For example, a user might build a List of Germplasm that they have manually marked for further study.",
105105
"brapi-metadata": {
106-
"primaryModel": true
106+
"primaryModel": true,
107+
"subQuery": [
108+
"data"
109+
]
107110
}
108111
}
109112
},

Specification/BrAPI-Schema/BrAPI-Core/Study.json

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,8 @@
6868
"environmentParameters": {
6969
"description": "Environmental parameters that were kept constant throughout the study and did not change between observation units.\n\nMIAPPE V1.1 (DM-57) Environment - Environmental parameters that were kept constant throughout the study and did not change between observation units or assays. Environment characteristics that vary over time, i.e. environmental variables, should be recorded as Observed Variables (see below).",
7070
"relationshipType": "one-to-many",
71-
"referencedAttribute": "study",
7271
"items": {
73-
"$ref": "../BrAPI-Core/Study.json#/$defs/EnvironmentParameters",
74-
"description": "EnvironmentParameters"
72+
"$ref": "../BrAPI-Core/Study.json#/$defs/EnvironmentParameter"
7573
},
7674
"title": "EnvironmentParameters",
7775
"type": [
@@ -322,7 +320,8 @@
322320
"primaryModel": true
323321
}
324322
},
325-
"EnvironmentParameters": {
323+
"EnvironmentParameter": {
324+
"description": "An environmental parameter that was kept constant throughout the study and did not change between observation units.\n\nMIAPPE V1.1 (DM-57) Environment - Environmental parameters that were kept constant throughout the study and did not change between observation units or assays. Environment characteristics that vary over time, i.e. environmental variables, should be recorded as Observed Variables.",
326325
"properties": {
327326
"description": {
328327
"description": "Human-readable value of the environment parameter (defined above) constant within the experiment",
@@ -457,13 +456,15 @@
457456
"type": "string"
458457
},
459458
"timestamp": {
459+
"description": "The timestamp of the update.",
460460
"format": "date-time",
461461
"type": [
462462
"null",
463463
"string"
464464
]
465465
},
466466
"version": {
467+
"description": "The version of the update.",
467468
"type": [
468469
"null",
469470
"string"

Specification/BrAPI-Schema/BrAPI-Core/Trial.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -238,12 +238,14 @@
238238
"Publication": {
239239
"properties": {
240240
"publicationPUI": {
241+
"description": "The permanent unique identifier of the publication.",
241242
"type": [
242243
"null",
243244
"string"
244245
]
245246
},
246247
"publicationReference": {
248+
"description": "The publication reference.",
247249
"type": [
248250
"null",
249251
"string"

Specification/BrAPI-Schema/BrAPI-Genotyping/Call.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
}
6868
},
6969
"GenotypeMetadata": {
70+
"description": "An additional layer of metadata associated with a genotype",
7071
"properties": {
7172
"dataType": {
7273
"description": "The type of field represented in this Genotype Field. This is intended to help parse the data out of JSON.",

Specification/BrAPI-Schema/BrAPI-Germplasm/Cross.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,12 @@
6565
},
6666
"plannedCross": {
6767
"$ref": "PlannedCross.json#/$defs/PlannedCross",
68-
"description": "the unique identifier for a planned cross",
68+
"description": "The Cross that was used in the planning of this one.",
6969
"referencedAttribute": "crosses",
7070
"relationshipType": "many-to-one"
7171
},
7272
"pollinationEvents": {
73-
"description": "The list of pollination events that occurred for this cross",
73+
"description": "The list of pollination events that occurred for this cross.",
7474
"relationshipType": "one-to-many",
7575
"referencedAttribute": "cross",
7676
"items": {
@@ -132,7 +132,7 @@
132132
}
133133
},
134134
"title": "CrossAttribute",
135-
"description": "A custom attributes associated with a cross",
135+
"description": "A custom attribute associated with a cross. For example, if the crossing event occurred on a humid day, a user might record 'crossAttributeName':'Relative Humidity', 'crossAttributeValue':'80%'",
136136
"type": "object",
137137
"brapi-metadata": {
138138
"primaryModel": false
@@ -163,14 +163,14 @@
163163
]
164164
},
165165
"cross": {
166-
"description": "Pollination events associated with a cross",
166+
"description": "The Cross associated with this Pollination Event",
167167
"$ref": "../BrAPI-Germplasm/Cross.json#/$defs/Cross",
168168
"relationshipType": "many-to-one",
169169
"referencedAttribute": "pollinationEvents"
170170
}
171171
},
172172
"title": "PollinationEvent",
173-
"description": "A pollination event that occurred for this cross",
173+
"description": "A Pollination Event that was used or attempted for a Cross.",
174174
"type": "object",
175175
"brapi-metadata": {
176176
"primaryModel": false

Specification/BrAPI-Schema/BrAPI-Germplasm/Germplasm.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
]
134134
},
135135
"germplasmDbId": {
136-
"description": "The ID which uniquely identifies a germplasm within the given database server \n<br>MIAPPE V1.1 (DM-41) Biological material ID - Code used to identify the biological material in the data file. Should be unique within the Investigation. Can correspond to experimental plant ID, seed lot ID, etc. This material identification is different from a BiosampleID which corresponds to Observation Unit or Samples sections below.",
136+
"description": "The ID which uniquely identifies a germplasm within the given database server \n<br>MIAPPE V1.1 (DM-41) Biological material ID - Code used to identify the biological material in the data file. Should be unique within the Investigation. Can correspond to experimental plant ID, inventory lot ID, etc. This material identification is different from a BiosampleID which corresponds to Observation Unit or Samples sections below.",
137137
"type": "string"
138138
},
139139
"germplasmName": {
@@ -155,7 +155,7 @@
155155
]
156156
},
157157
"germplasmPUI": {
158-
"description": "The Permanent Unique Identifier which represents a germplasm\n\nMIAPPE V1.1 (DM-41) Biological material ID - Code used to identify the biological material in the data file. Should be unique within the Investigation. Can correspond to experimental plant ID, seed lot ID, etc This material identification is different from a BiosampleID which corresponds to Observation Unit or Samples sections below.\n\nMIAPPE V1.1 (DM-51) Material source DOI - Digital Object Identifier (DOI) of the material source\n\nMCPD (v2.1) (PUID) 0. Any persistent, unique identifier assigned to the accession so it can be unambiguously referenced at the global level and the information associated with it harvested through automated means. Report one PUID for each accession. The Secretariat of the International Treaty on Plant Genetic Resources for Food and Agriculture (PGRFA) is facilitating the assignment of a persistent unique identifier (PUID), in the form of a DOI, to PGRFA at the accession level. Genebanks not applying a true PUID to their accessions should use, and request recipients to use, the concatenation of INSTCODE, ACCENUMB, and GENUS as a globally unique identifier similar in most respects to the PUID whenever they exchange information on accessions with third parties.",
158+
"description": "The Permanent Unique Identifier which represents a germplasm\n\nMIAPPE V1.1 (DM-41) Biological material ID - Code used to identify the biological material in the data file. Should be unique within the Investigation. Can correspond to experimental plant ID, inventory lot ID, etc This material identification is different from a BiosampleID which corresponds to Observation Unit or Samples sections below.\n\nMIAPPE V1.1 (DM-51) Material source DOI - Digital Object Identifier (DOI) of the material source\n\nMCPD (v2.1) (PUID) 0. Any persistent, unique identifier assigned to the accession so it can be unambiguously referenced at the global level and the information associated with it harvested through automated means. Report one PUID for each accession. The Secretariat of the International Treaty on Plant Genetic Resources for Food and Agriculture (PGRFA) is facilitating the assignment of a persistent unique identifier (PUID), in the form of a DOI, to PGRFA at the accession level. Genebanks not applying a true PUID to their accessions should use, and request recipients to use, the concatenation of INSTCODE, ACCENUMB, and GENUS as a globally unique identifier similar in most respects to the PUID whenever they exchange information on accessions with third parties.",
159159
"type": "string"
160160
},
161161
"germplasmPreprocessing": {
@@ -245,7 +245,6 @@
245245
"synonyms": {
246246
"description": "List of alternative names or IDs used to reference this germplasm\n\nMCPD (v2.1) (OTHERNUMB) 24. Any other identifiers known to exist in other collections for this accession. Use the following format: INSTCODE:ACCENUMB;INSTCODE:identifier;INSTCODE and identifier are separated by a colon without space. Pairs of INSTCODE and identifier are separated by a semicolon without space. When the institute is not known, the identifier should be preceded by a colon.",
247247
"relationshipType": "one-to-many",
248-
"referencedAttribute": "germplasm",
249248
"items": {
250249
"$ref": "../BrAPI-Germplasm/Germplasm.json#/$defs/Synonym",
251250
"description": "Synonyms"
@@ -264,7 +263,6 @@
264263
"$ref": "../BrAPI-Germplasm/Germplasm.json#/$defs/TaxonId",
265264
"description": "TaxonIds"
266265
},
267-
"title": "TaxonIds",
268266
"type": [
269267
"null",
270268
"array"
@@ -408,7 +406,7 @@
408406
]
409407
},
410408
"germplasm": {
411-
"description": "donoers associated with a germplasm",
409+
"description": "donors associated with a germplasm",
412410
"$ref": "../BrAPI-Germplasm/Germplasm.json#/$defs/Germplasm",
413411
"relationshipType": "many-to-one",
414412
"referencedAttribute": "donors"
@@ -502,6 +500,7 @@
502500
}
503501
},
504502
"Synonym": {
503+
"description": "Alternative way to refer to a Germplasm, Cultivar of Variety",
505504
"properties": {
506505
"synonym": {
507506
"description": "Alternative name or ID used to reference this germplasm",
@@ -532,6 +531,7 @@
532531
}
533532
},
534533
"TaxonId": {
534+
"description": "The Taxon of the Germplasm",
535535
"properties": {
536536
"taxonId": {
537537
"description": "The identifier (name, ID, URI) of a particular taxonomy within the source provider",

Specification/BrAPI-Schema/BrAPI-Phenotyping/Event.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
}
193193
},
194194
"title": "EventParameter",
195-
"description": "An object describing additional event parameters. Each of the following accepts a human-readable value or URI",
195+
"description": "Additional metadata to describe an event, based on the ICASA standard model. For example, 'Tillage Implement' (tiimp), 'Tillage Depth' (tidep), and 'Tillage Mix Effectiveness' (timix) might all be recorded parameters for a Tillage event.",
196196
"type": "object",
197197
"brapi-metadata": {
198198
"primaryModel": false

Specification/BrAPI-Schema/BrAPI-Phenotyping/Image.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
"properties": {
55
"additionalInfo": {
66
"description": "A free space containing any additional information related to a particular object. A data source may provide any JSON object, unrestricted by the BrAPI specification.",
7-
"$ref": "../BrAPI-Common/AdditionalInfo.json#/$defs/AdditionalInfo",
8-
"relationshipType": "one-to-one"
7+
"$ref": "../BrAPI-Common/AdditionalInfo.json#/$defs/AdditionalInfo"
98
},
109
"copyright": {
1110
"description": "The copyright information of this image. Example 'Copyright 2018 Bob Robertson'",

0 commit comments

Comments
 (0)