Merge pull request #364 from platanus/selec2-tags-fix

fix(select): tags option not working with active_admin_form_for

Author: ldlsegovia

CHANGELOG.md

@@ -2,12 +2,23 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
-### ### 1.8.2
+### Unreleased
+
+##### Fixed
+
+* `tags` option not working with `active_admin_form_for` [#364](https://github.com/platanus/activeadmin_addons/pull/364)
+
+### 1.8.2
 
 ##### Fixed
 * Removes vendor directory from build to reduce gem size
 
-### 1.8.0
+### 1.8.0 and 1.8.1
+
+Versions 1.8.0 and 1.8.1 were yanked by what was described in version 1.8.2. Sorry for the inconvenience.
+Related issues:
+- https://github.com/platanus/activeadmin_addons/issues/357
+- https://github.com/platanus/activeadmin_addons/issues/362
 
 ##### Added
 * Added date time picker filter [#333](https://github.com/platanus/activeadmin_addons/pull/333)

app/inputs/active_admin/inputs/select_input.rb

@@ -4,7 +4,11 @@ def input_html_options
   end
 
   def raw_collection
-    field_value = object.send(method)
+    field_value = begin
+                    object.send(method)
+                  rescue NoMethodError
+                    nil
+                  end
 
     @options[:tags].present? && field_value.present? ? (super.to_a << field_value).uniq : super
   end

spec/features/inputs/select2_spec.rb

@@ -25,30 +25,55 @@
       let(:invoice) { create_invoice }
       let(:selection) { '#444' }
 
-      before do
-        register_form(Invoice) do |f|
-          f.input :number, as: :select, collection: ["#111", "#222", "#333"], tags: true
+      context "with AA form" do
+        before do
+          register_form(Invoice) do |f|
+            f.input :number, as: :select, collection: ["#111", "#222", "#333"], tags: true
+          end
         end
-      end
 
-      context 'when entering option not in collection' do
-        before { visit edit_admin_invoice_path(invoice) }
+        context 'when entering option not in collection' do
+          before { visit edit_admin_invoice_path(invoice) }
 
-        it "adds new option", js: true do
-          expect_select2_options_count_to_eq(4)
-          fill_select2_input(selection)
-          expect_select2_options_count_to_eq(5)
+          it "adds new option", js: true do
+            expect_select2_options_count_to_eq(4)
+            fill_select2_input(selection)
+            expect_select2_options_count_to_eq(5)
+          end
+        end
+
+        context 'when initial value is not in inputs collection' do
+          before do
+            invoice.update!(number: selection)
+            visit edit_admin_invoice_path(invoice)
+          end
+
+          it "includes initial value as option", js: true do
+            expect_select2_options_count_to_eq(5)
+          end
         end
       end
 
-      context 'when initial value is not in inputs collection' do
+      context "with custom form" do
         before do
-          invoice.update!(number: selection)
-          visit edit_admin_invoice_path(invoice)
+          register_page(Invoice) do
+            config.filters = false
+            sidebar 'Filters' do
+              active_admin_form_for(:q) do |f|
+                f.input :number, as: :select, collection: ["#111", "#222", "#333"], tags: true
+              end
+            end
+          end
         end
 
-        it "includes initial value as option", js: true do
-          expect_select2_options_count_to_eq(5)
+        context 'when entering option not in collection' do
+          before { visit admin_invoices_path }
+
+          it "adds new option", js: true do
+            expect_select2_options_count_to_eq(4)
+            fill_select2_input(selection)
+            expect_select2_options_count_to_eq(5)
+          end
         end
       end
     end