refactor(middleware): simplify CreateAuthMiddleware function

• Remove unused retriever parameter for clarity
• Clean up related test cases to reflect changes

Author: nexus49

middleware/authzMiddlewares.go

@@ -2,8 +2,6 @@ package middleware
 
 import (
 	"net/http"
-
-	"github.com/platform-mesh/golang-commons/policy_services"
 )
 
 // CreateAuthMiddleware returns a slice of HTTP middleware constructors that populate
@@ -13,10 +11,7 @@ import (
 // 1. StoreWebToken()
 // 2. StoreAuthHeader()
 // 3. StoreSpiffeHeader()
-//
-// The `retriever` parameter is accepted for compatibility with caller signatures but is
-// not used by this implementation.
-func CreateAuthMiddleware(retriever policy_services.TenantRetriever) []func(http.Handler) http.Handler {
+func CreateAuthMiddleware() []func(http.Handler) http.Handler {
 	mws := make([]func(http.Handler) http.Handler, 0, 5)
 
 	mws = append(mws, StoreWebToken())

middleware/authzMiddlewares_test.go

@@ -1,29 +1,15 @@
 package middleware
 
 import (
-	"context"
+	_ "context"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/mock"
-
-	"github.com/platform-mesh/golang-commons/policy_services"
+	_ "github.com/stretchr/testify/mock"
 )
 
-// MockTenantRetriever is a mock implementation of TenantRetriever
-type MockTenantRetriever struct {
-	mock.Mock
-}
-
-func (m *MockTenantRetriever) RetrieveTenant(ctx context.Context) (string, error) {
-	args := m.Called(ctx)
-	return args.String(0), args.Error(1)
-}
-
 func TestCreateAuthMiddleware(t *testing.T) {
-	mockRetriever := &MockTenantRetriever{}
-
-	middlewares := CreateAuthMiddleware(mockRetriever)
+	middlewares := CreateAuthMiddleware()
 
 	// Should return 3 middlewares: StoreWebToken, StoreAuthHeader, StoreSpiffeHeader
 	assert.Len(t, middlewares, 3)
@@ -35,7 +21,7 @@ func TestCreateAuthMiddleware(t *testing.T) {
 }
 
 func TestCreateAuthMiddleware_WithNilRetriever(t *testing.T) {
-	middlewares := CreateAuthMiddleware(nil)
+	middlewares := CreateAuthMiddleware()
 
 	// Should still return 3 middlewares even with nil retriever
 	assert.Len(t, middlewares, 3)
@@ -47,9 +33,7 @@ func TestCreateAuthMiddleware_WithNilRetriever(t *testing.T) {
 }
 
 func TestCreateAuthMiddleware_ReturnsCorrectMiddlewares(t *testing.T) {
-	mockRetriever := &MockTenantRetriever{}
-
-	middlewares := CreateAuthMiddleware(mockRetriever)
+	middlewares := CreateAuthMiddleware()
 
 	// Verify we get exactly 3 middlewares
 	assert.Len(t, middlewares, 3)
@@ -62,16 +46,3 @@ func TestCreateAuthMiddleware_ReturnsCorrectMiddlewares(t *testing.T) {
 		// This is implicitly tested by the fact that the function compiles and returns without error
 	}
 }
-
-// Test that implements policy_services.TenantRetriever interface
-func TestTenantRetrieverInterface(t *testing.T) {
-	mockRetriever := &MockTenantRetriever{}
-
-	// Verify our mock implements the interface
-	var retriever policy_services.TenantRetriever = mockRetriever
-	assert.NotNil(t, retriever)
-
-	// Test that we can use it with the middleware functions
-	middlewares := CreateAuthMiddleware(retriever)
-	assert.Len(t, middlewares, 3)
-}