feat: implement finalizer logic in deployment and providersecret subroutines.

On-behalf-of: @SAP angel.kafazov@sap.com
Signed-off-by: Angel Kafazov <akafazov@cst-bg.net>

Author: akafazov

internal/controller/platformmesh_controller.go

@@ -30,6 +30,7 @@ import (
 	corev1alpha1 "github.com/platform-mesh/platform-mesh-operator/api/v1alpha1"
 	"github.com/platform-mesh/platform-mesh-operator/internal/config"
 	"github.com/platform-mesh/platform-mesh-operator/pkg/subroutines"
+	corev1 "k8s.io/api/core/v1"
 )
 
 var (
@@ -67,6 +68,7 @@ func (r *PlatformMeshReconciler) SetupWithManager(mgr ctrl.Manager, cfg *pmconfi
 	if err != nil {
 		return err
 	}
+	builder.Owns(&corev1.Secret{})
 	return builder.Complete(r)
 }
 

pkg/subroutines/deployment.go

@@ -76,6 +76,7 @@ func (r *DeploymentSubroutine) Finalize(ctx context.Context, _ runtimeobject.Run
 		return ctrl.Result{}, errors.NewOperatorError(err, false, true)
 	}
 
+	log.Info().Msg("Successfully finalized DeploymentSubroutine")
 	// If we reach here, both objects are deleted or did not exist. The controller will remove our finalizer.
 	return ctrl.Result{}, nil
 }

pkg/subroutines/providersecret.go

@@ -243,10 +243,15 @@ func (r *ProvidersecretSubroutine) HandleProviderConnection(
 	providerSecret := &corev1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      pc.Secret,
-			Namespace: "platform-mesh-system",
+			Namespace: instance.Namespace,
 		},
 	}
 
+	if err := controllerutil.SetOwnerReference(instance, providerSecret, r.client.Scheme()); err != nil {
+		log.Error().Err(err).Msg("Failed to set owner reference on secret")
+		return ctrl.Result{}, errors.NewOperatorError(err, false, false)
+	}
+
 	_, err = controllerutil.CreateOrUpdate(ctx, r.client, providerSecret, func() error {
 		providerSecret.Data = map[string][]byte{
 			"kubeconfig": kcpConfigBytes,
@@ -311,9 +316,15 @@ func (r *ProvidersecretSubroutine) HandleInitializerConnection(
 	initializerSecret := &corev1.Secret{
 		ObjectMeta: metav1.ObjectMeta{
 			Name:      ic.Secret,
-			Namespace: "platform-mesh-system",
+			Namespace: instance.Namespace,
 		},
 	}
+
+	if err := controllerutil.SetOwnerReference(instance, initializerSecret, r.client.Scheme()); err != nil {
+		log.Error().Err(err).Msg("Failed to set owner reference on secret")
+		return ctrl.Result{}, errors.NewOperatorError(err, false, false)
+	}
+
 	_, err = controllerutil.CreateOrUpdate(ctx, r.client, initializerSecret, func() error {
 		initializerSecret.Data = map[string][]byte{"kubeconfig": data}
 		return err