Resource ready conditions (#100)

* feat: remove resource.ts from openmfp

* feat: implement readyCondition

* fix: fix tests

* feat: update openmfp deps

* fix: fix column retrieval

* feat: update docs

* feat: change ready condition equality check logic

* fix: fix import path

* feat: change docs

Author: Sobyt483

docs/readme-generic-ui.md

@@ -24,8 +24,17 @@ In order to use the generic list view, you need to adjust the node’s   `conten
 
 - context resource definition `"context"`
 
-    - in the `"resourceDefinition"` the given fields need to be specified: `group, plural, singular, kind, scope, namespace` describing
-      properties of the resource.
+  - in the `"resourceDefinition"` the given fields need to be specified: `group, plural, singular, kind, scope, namespace` describing properties of the resource.
+  - Also `"resourceDefinition"` have optional field `readyCondition` that describing when resource treated as ready
+    It's an object that contains two fields:
+      - `jsonPathExpression`: JSONPath expression used to evaluate whether the resource is ready at runtime
+      - `property`: JSON path(s) used to generate GraphQL fields to fetch the necessary data for readiness evaluation
+    ```json
+    "readyCondition": {
+      "jsonPathExpression": "status.conditions[?(@.type=='Ready' && @.status=='True')]",
+      "property": ["status.conditions.status", "status.conditions.type"],
+    },
+    ```
     - in the `"ui"` part of the `"resourceDefinition"` we can specify `"logoUrl"` for the resource as well as the definitions of the
       corresponding views
 
@@ -95,6 +104,10 @@ Below is an example content-configuration for an accounts node using the generic
               "kind": "Account",
               "scope": "Cluster",
               "namespace": null,
+              "readyCondition": {
+                "jsonPathExpression": "status.conditions[?(@.type=='Ready' && @.status=='True')]",
+                "property": ["status.conditions.status", "status.conditions.type"],
+              },
               "ui": {
                 "logoUrl": "https://www.kcp.io/icons/logo.svg",
                 "listView": {

package-lock.json

@@ -29,7 +29,7 @@
     "@angular/compiler-cli": "^20.2.1",
     "@angular/localize": "^20.2.1",
     "@briebug/jest-schematic": "6.0.0",
-    "@openmfp/portal-ui-lib": "0.181.8",
+    "@openmfp/portal-ui-lib": "0.182.0",
     "@openmfp/config-prettier": "0.8.1",
     "@types/jest": "^30.0.0",
     "@types/jmespath": "0.15.2",
@@ -51,4 +51,4 @@
     "ts-jest": "29.3.2",
     "typescript": "~5.8.0"
   }
-}
+}

package.json

@@ -65,6 +65,10 @@ export interface ResourceDefinition {
   kind: string;
   scope?: KubernetesScope;
   namespace?: string;
+  readyCondition?: {
+    jsonPathExpression: string;
+    property: string | string[];
+  };
   ui?: UIDefinition;
 }
 
@@ -79,4 +83,4 @@ export interface UIDefinition {
   detailView?: UiView;
 }
 
-export type KubernetesScope = 'Cluster' | 'Namespaced';
+export type KubernetesScope = 'Cluster' | 'Namespaced';

projects/lib/models/models/resource.ts

@@ -1,4 +1,5 @@
-import { NodeContext, Resource } from '@openmfp/portal-ui-lib';
+import { NodeContext } from '@openmfp/portal-ui-lib';
+import { Resource } from '@platform-mesh/portal-ui-lib/models';
 
 export interface PortalContext extends Record<string, any> {
   crdGatewayApiUrl: string;

projects/lib/portal-options/models/luigi-context.ts

@@ -2,18 +2,21 @@ import { DestroyRef, Injectable, inject } from '@angular/core';
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import {
   AuthService,
-  FieldDefinition,
   LuigiCoreService,
   LuigiNode,
   PortalConfig,
-  Resource,
 } from '@openmfp/portal-ui-lib';
-import { ResourceNodeContext, ResourceService } from '@platform-mesh/portal-ui-lib/services';
+import { FieldDefinition, Resource } from '@platform-mesh/portal-ui-lib/models';
+import {
+  ResourceNodeContext,
+  ResourceService,
+} from '@platform-mesh/portal-ui-lib/services';
 import { generateGraphQLFields } from '@platform-mesh/portal-ui-lib/utils';
 import '@ui5/webcomponents/dist/ComboBox.js';
 import { Observable, of } from 'rxjs';
 import { shareReplay } from 'rxjs/operators';
 
+
 const defaultColumns: FieldDefinition[] = [
   {
     label: 'Name',
@@ -148,4 +151,4 @@ export class NamespaceSelectionRendererService {
       console.warn(`Segment "${name}" not found in path.`);
     }
   }
-}
+}

projects/lib/portal-options/services/header-bar-renderers/namespace-selection-renderer.service.ts

@@ -1,11 +1,11 @@
-import { TestBed } from '@angular/core/testing';
-import { Resource } from '@openmfp/portal-ui-lib';
-import { ResourceService } from '@platform-mesh/portal-ui-lib/services';
-import { of, throwError } from 'rxjs';
 import { PortalNodeContext } from '../models/luigi-context';
 import { PortalLuigiNode } from '../models/luigi-node';
 import { CrdGatewayKcpPatchResolver } from './crd-gateway-kcp-patch-resolver.service';
 import { NodeContextProcessingServiceImpl } from './node-context-processing.service';
+import { TestBed } from '@angular/core/testing';
+import { Resource } from '@platform-mesh/portal-ui-lib/models';
+import { ResourceService } from '@platform-mesh/portal-ui-lib/services';
+import { of, throwError } from 'rxjs';
 
 describe('NodeContextProcessingServiceImpl', () => {
   let service: NodeContextProcessingServiceImpl;
@@ -431,4 +431,4 @@ describe('NodeContextProcessingServiceImpl', () => {
       );
     });
   });
-});
+});

projects/lib/portal-options/services/node-context-processing.service.spec.ts

@@ -1,6 +1,8 @@
 import { NodeContext } from '@openmfp/portal-ui-lib';
+import { ResourceDefinition } from '@platform-mesh/portal-ui-lib/models';
 
 export interface ResourceNodeContext extends Partial<NodeContext> {
+  resourceDefinition?: ResourceDefinition;
   organization?: string;
   accountId?: string;
   kcpCA?: string;
@@ -15,4 +17,4 @@ export interface ResourceNodeContext extends Partial<NodeContext> {
     crdGatewayApiUrl: string;
     kcpWorkspaceUrl?: string;
   };
-}
+}

projects/lib/services/resource/resource-node-context.ts

@@ -1,5 +1,5 @@
-import { FieldDefinition } from '@openmfp/portal-ui-lib';
 import { generateGraphQLFields } from './columns-to-gql-fields';
+import { FieldDefinition } from '@platform-mesh/portal-ui-lib/models';
 
 describe('columns-to-gql-fields', () => {
   describe('generateGraphQLFields', () => {

projects/lib/utils/utils/columns-to-gql-fields.spec.ts

@@ -1,4 +1,4 @@
-import { FieldDefinition } from '@openmfp/portal-ui-lib';
+import { FieldDefinition } from '@platform-mesh/portal-ui-lib/models';
 
 export const generateGraphQLFields = (uiFields: FieldDefinition[]): any[] => {
   const graphQLFields = [];