refactor: address pr comments

Author: Sobyt483

projects/wc/src/app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.html

@@ -57,7 +57,7 @@
           >
             @if (form.controls[fieldProperty].errors?.k8sNameInvalid) {
               <div slot="valueStateMessage">
-                Invalid resource name <a href="https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names" target="_blank">RFC 1035</a>
+                <a href="{{ k8sMessages.RFC_1035.href }}" target="_blank">{{ k8sMessages.RFC_1035.message }}</a>
               </div>
             }
           </ui5-input>

projects/wc/src/app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.component.ts

@@ -1,6 +1,7 @@
+import { k8sMessages } from '../../../../consts/k8s-messages';
 import { k8sNameValidator } from '../../../../validators/k8s-name-validator';
 import { DynamicSelectComponent } from '../../../dynamic-select/dynamic-select.component';
-import { CreateOnlyResourceFieldNames } from './create-resource-modal.enums';
+import { ResourceFieldNames } from './create-resource-modal.enums';
 import {
   Component,
   OnInit,
@@ -66,6 +67,8 @@ export class CreateResourceModalComponent implements OnInit {
 
   private originalResource = signal<Resource | null>(null);
 
+  protected readonly k8sMessages = k8sMessages;
+
   ngOnInit(): void {
     this.form = this.fb.group(this.createControls());
   }
@@ -132,9 +135,9 @@ export class CreateResourceModalComponent implements OnInit {
 
   isCreateFieldOnly(field: FieldDefinition): boolean {
     return (
-      field.property === CreateOnlyResourceFieldNames.MetadataName ||
-      field.property === CreateOnlyResourceFieldNames.SpecType ||
-      field.property === CreateOnlyResourceFieldNames.MetadataNamespace
+      field.property === ResourceFieldNames.MetadataName ||
+      field.property === ResourceFieldNames.SpecType ||
+      field.property === ResourceFieldNames.MetadataNamespace
     );
   }
 
@@ -161,9 +164,7 @@ export class CreateResourceModalComponent implements OnInit {
       validators.push(Validators.required);
     }
 
-    if (
-      fieldDefinition.property === CreateOnlyResourceFieldNames.MetadataName
-    ) {
+    if (fieldDefinition.property === ResourceFieldNames.MetadataName) {
       validators.push(k8sNameValidator);
     }
 

projects/wc/src/app/components/generic-ui/list-view/create-resource-modal/create-resource-modal.enums.ts

@@ -1,4 +1,4 @@
-export enum CreateOnlyResourceFieldNames {
+export enum ResourceFieldNames {
   MetadataName = 'metadata.name',
   SpecType = 'spec.type',
   MetadataNamespace = 'metadata.namespace',

projects/wc/src/app/components/organization-management/organization-management.component.html

@@ -40,7 +40,7 @@
           [valueState]="getValueState(newOrganization)"
         >
           <div slot="valueStateMessage">
-            Invalid organization name <a href="https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names" target="_blank">RFC 1035</a>
+            <a href="{{ k8sMessages.RFC_1035.href }}" target="_blank">{{ k8sMessages.RFC_1035.message }}</a>
           </div>
       </ui5-input>
       <ui5-button [disabled]="newOrganization.invalid" design="Emphasized" (ui5Click)="onboardOrganization()">{{

projects/wc/src/app/components/organization-management/organization-management.component.ts

@@ -1,3 +1,4 @@
+import { k8sMessages } from '../../consts/k8s-messages';
 import { k8sNameValidator } from '../../validators/k8s-name-validator';
 import {
   ChangeDetectionStrategy,
@@ -60,6 +61,7 @@ export class OrganizationManagementComponent implements OnInit {
   private i18nService = inject(I18nService);
   private resourceService = inject(ResourceService);
   private envConfigService = inject(EnvConfigService);
+
   context = input<ResourceNodeContext>();
   LuigiClient = input<LuigiClient>();
 
@@ -71,6 +73,8 @@ export class OrganizationManagementComponent implements OnInit {
     nonNullable: true,
   });
 
+  protected readonly k8sMessages = k8sMessages;
+
   constructor() {
     effect(() => {
       const ctx = this.context();
@@ -211,8 +215,8 @@ export class OrganizationManagementComponent implements OnInit {
 
     if (!sanitizedOrg) {
       this.LuigiClient().uxManager().showAlert({
-        text: 'Organization name is not valid for subdomain usage, accrording to RFC 1034/1123.',
-        type: 'error',
+        text: k8sMessages.RFC_1034_1123.message,
+        type: k8sMessages.RFC_1034_1123.type,
       });
       return;
     }

projects/wc/src/app/consts/k8s-messages.ts

@@ -0,0 +1,13 @@
+export const k8sMessages = {
+  RFC_1035: {
+    href: 'https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names',
+    message: 'Invalid resource name accrording to RFC 1035',
+    type: 'error',
+  },
+  RFC_1034_1123: {
+    href: 'https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names',
+    message:
+      'Organization name is not valid for subdomain usage, accrording to RFC 1034/1123.',
+    type: 'error',
+  },
+} as const;