Clean up default columns (#123)

* feat: cleanup default columns

* fix: fix tests

Author: Sobyt483

projects/lib/portal-options/services/custom-global-nodes.service.ts

@@ -44,6 +44,7 @@ export class CustomGlobalNodesServiceImpl implements CustomGlobalNodesService {
             children: [
               {
                 pathSegment: 'overview',
+                context: {} as PortalNodeContext,
                 hideSideNav: true,
                 hideFromNav: true,
                 defineEntity: {

projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.spec.ts

@@ -138,55 +138,6 @@ describe('DetailViewComponent', () => {
     expect(mockAnchorElement.click).toHaveBeenCalled();
   });
 
-  it('should return default fields when ui.detailView.fields is undefined', () => {
-    // Reset mocks and create new component instance
-    jest.clearAllMocks();
-    const newFixture = TestBed.createComponent(DetailViewComponent);
-    const newComponent = newFixture.componentInstance;
-
-    newComponent.context = (() => ({
-      resourceId: 'cluster-1',
-      token: 'abc123',
-      resourceDefinition: {
-        kind: 'Cluster',
-        group: 'core.k8s.io',
-        ui: {
-          detailView: {
-            // fields is undefined
-          },
-        },
-      },
-      entity: {
-        metadata: { name: 'test-resource' },
-      },
-      parentNavigationContexts: ['project'],
-    })) as any;
-
-    newComponent.LuigiClient = (() => ({
-      linkManager: () => ({
-        fromContext: jest.fn().mockReturnThis(),
-        navigate: jest.fn(),
-        withParams: jest.fn().mockReturnThis(),
-      }),
-      uxManager: () => ({
-        showAlert: jest.fn(),
-      }),
-      getNodeParams: jest.fn(),
-    })) as any;
-
-    newFixture.detectChanges();
-
-    const defaultFields = [
-      {
-        label: 'Workspace Status',
-        jsonPathExpression: 'status.conditions[?(@.type=="Ready")].status',
-        property: ['status.conditions.status', 'status.conditions.type'],
-      },
-    ];
-
-    expect(newComponent.resourceFields()).toEqual(defaultFields);
-  });
-
   it('should call resource service with correct parameters for account kind', () => {
     jest.clearAllMocks();
     const newFixture = TestBed.createComponent(DetailViewComponent);

projects/wc/src/app/components/generic-ui/detail-view/detail-view.component.ts

@@ -1,3 +1,7 @@
+import { processFields } from '../../../utils/proccess-fields';
+import { validateKubeconfigProps } from '../../../utils/ts-guargs/validate-kubeconfig-props';
+import { ValueCellComponent } from '../value-cell/value-cell.component';
+import { kubeConfigTemplate } from './kubeconfig-template';
 import {
   ChangeDetectionStrategy,
   Component,
@@ -10,7 +14,7 @@ import {
 } from '@angular/core';
 import { LuigiClient } from '@luigi-project/client/luigi-element';
 import { EnvConfigService } from '@openmfp/portal-ui-lib';
-import { FieldDefinition, Resource } from '@platform-mesh/portal-ui-lib/models';
+import { Resource } from '@platform-mesh/portal-ui-lib/models';
 import {
   GatewayService,
   ResourceNodeContext,
@@ -31,18 +35,6 @@ import {
   ToolbarButtonComponent,
   ToolbarComponent,
 } from '@ui5/webcomponents-ngx';
-import { processFields } from '../../../utils/proccess-fields';
-import { ValueCellComponent } from '../value-cell/value-cell.component';
-import { kubeConfigTemplate } from './kubeconfig-template';
-import { validateKubeconfigProps } from '../../../utils/ts-guargs/validate-kubeconfig-props';
-
-const defaultFields: FieldDefinition[] = [
-  {
-    label: 'Workspace Status',
-    jsonPathExpression: 'status.conditions[?(@.type=="Ready")].status',
-    property: ['status.conditions.status', 'status.conditions.type'],
-  },
-];
 
 @Component({
   selector: 'detail-view',
@@ -75,7 +67,7 @@ export class DetailViewComponent {
 
   resourceDefinition = computed(() => this.context().resourceDefinition);
   resourceFields = computed(
-    () => this.resourceDefinition()?.ui?.detailView?.fields || defaultFields,
+    () => this.resourceDefinition()?.ui?.detailView?.fields ?? [],
   );
   resourceId = computed(() => this.context().entity?.metadata.name);
   workspacePath = computed(() =>
@@ -193,4 +185,4 @@ export class DetailViewComponent {
 
     return resourceDefinition;
   }
-}
+}

projects/wc/src/app/components/generic-ui/list-view/list-view.component.spec.ts

@@ -197,37 +197,6 @@ describe('ListViewComponent', () => {
     expect(newComponent.hasUiCreateViewFields()).toBe(true);
   });
 
-  it('should use default columns when no listView fields are defined', () => {
-    // Create a new component instance with different context
-    const newFixture = TestBed.createComponent(ListViewComponent);
-    const newComponent = newFixture.componentInstance;
-
-    newComponent.context = (() => ({
-      resourceDefinition: {
-        plural: 'clusters',
-        kind: 'Cluster',
-        group: 'core.k8s.io',
-        ui: {
-          // No listView fields defined
-        },
-      },
-    })) as any;
-
-    newComponent.LuigiClient = (() => ({
-      linkManager: () => ({
-        fromContext: jest.fn().mockReturnThis(),
-        navigate: jest.fn(),
-        withParams: jest.fn().mockReturnThis(),
-      }),
-      getNodeParams: jest.fn(),
-    })) as any;
-
-    newFixture.detectChanges();
-
-    expect(newComponent.columns().length).toBeGreaterThan(0);
-    expect(newComponent.columns()[0].label).toBe('Name');
-  });
-
   it('should compute heading correctly with capitalized plural', () => {
     const newFixture = TestBed.createComponent(ListViewComponent);
     const newComponent = newFixture.componentInstance;

projects/wc/src/app/components/generic-ui/list-view/list-view.component.ts

@@ -18,7 +18,7 @@ import {
 import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { LuigiClient } from '@luigi-project/client/luigi-element';
 import { LuigiCoreService } from '@openmfp/portal-ui-lib';
-import { FieldDefinition, Resource } from '@platform-mesh/portal-ui-lib/models';
+import { Resource } from '@platform-mesh/portal-ui-lib/models';
 import {
   ResourceNodeContext,
   ResourceService,
@@ -44,18 +44,6 @@ import {
   ToolbarComponent,
 } from '@ui5/webcomponents-ngx';
 
-const defaultColumns: FieldDefinition[] = [
-  {
-    label: 'Name',
-    property: 'metadata.name',
-  },
-  {
-    label: 'Workspace Status',
-    jsonPathExpression: 'status.conditions[?(@.type=="Ready")].status',
-    property: ['status.conditions.status', 'status.conditions.type'],
-  },
-];
-
 @Component({
   selector: 'list-view',
   standalone: true,
@@ -98,7 +86,7 @@ export class ListViewComponent implements OnInit {
   );
   resourceDefinition = computed(() => this.context().resourceDefinition);
   columns = computed(
-    () => this.resourceDefinition()?.ui?.listView?.fields || defaultColumns,
+    () => this.resourceDefinition()?.ui?.listView?.fields ?? [],
   );
   viewColomns = computed(() => processFields(this.columns()));
   readyCondition = computed(() => this.resourceDefinition()?.readyCondition);