Skip to content

Commit 593f1e2

Browse files
committed
fix: move pnpm link inside Docker container for Linux tests
The pnpm link was running on the host before Docker, but Docker's pnpm install --prefer-offline recreates node_modules, wiping the link. Moving the link inside Docker after pnpm install fixes this.
1 parent a7797d1 commit 593f1e2

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -310,8 +310,6 @@ jobs:
310310
with:
311311
name: entrypoints
312312
path: .
313-
- name: Link npm package for testing
314-
run: pnpm link ./npm/${{ matrix.settings.npm_dir }}
315313
- name: Output docker params
316314
id: docker
317315
run: |
@@ -363,4 +361,5 @@ jobs:
363361
npm i -gf pnpm
364362
node fix-python-soname.js
365363
pnpm install --prefer-offline
364+
pnpm link ./npm/${{ matrix.settings.npm_dir }}
366365
pnpm test

0 commit comments

Comments
 (0)