Finalize Account Settings and switch to a dedicated page (#681)

### Summary & Motivation

Convert the Account Settings from a modal dialog accessed through the
`AvatarButton` to a standalone page, now accessible via the **Account**
menu in the **Side Menu**. This change improves usability and provides a
more structured experience for managing account details.

A new endpoint has been implemented to update the **tenant name**
(account name) when saving changes.

Previously, all tenant-related API endpoints used `/tenants/{id}`, but
these have been updated to `/tenants/current` for improved clarity and
consistency. Both `GET` and `PUT` endpoints now use this new convention.
To support this change, a new `GetCurrentTenantAsync` method has been
added to the `TenantRepository`, and the `GetTenant` and
`GetCurrentTenant` commands have been updated to use this method.

All related frontend components, commands, and tests have been updated
accordingly.

### Checklist

- [x] I have added tests, or done manual regression tests
- [x] I have updated the documentation, if necessary

Author: tjementum

application/account-management/Api/Endpoints/TenantEndpoints.cs

@@ -14,15 +14,15 @@ public void MapEndpoints(IEndpointRouteBuilder routes)
     {
         var group = routes.MapGroup(RoutesPrefix).WithTags("Tenants").RequireAuthorization();
 
-        group.MapGet("/{id}", async Task<ApiResult<TenantResponse>> ([AsParameters] GetTenantQuery query, IMediator mediator)
-            => await mediator.Send(query)
+        group.MapGet("/current", async Task<ApiResult<TenantResponse>> (IMediator mediator)
+            => await mediator.Send(new GetTenantQuery())
         ).Produces<TenantResponse>();
 
-        group.MapPut("/{id}", async Task<ApiResult> (TenantId id, UpdateTenantCommand command, IMediator mediator)
-            => await mediator.Send(command with { Id = id })
+        group.MapPut("/current", async Task<ApiResult> (UpdateCurrentTenantCommand command, IMediator mediator)
+            => await mediator.Send(command)
         );
 
-        group.MapDelete("/{id}", async Task<ApiResult> (TenantId id, IMediator mediator)
+        routes.MapDelete("/internal-api/account-management/tenants/{id}", async Task<ApiResult> (TenantId id, IMediator mediator)
             => await mediator.Send(new DeleteTenantCommand(id))
         );
     }

…eatures/Tenants/Commands/UpdateTenant.cs …/Tenants/Commands/UpdateCurrentTenant.csapplication/account-management/Core/Features/Tenants/Commands/UpdateTenant.cs renamed to application/account-management/Core/Features/Tenants/Commands/UpdateCurrentTenant.cs application/account-management/Core/Features/Tenants/Commands/UpdateTenant.cs renamed to application/account-management/Core/Features/Tenants/Commands/UpdateCurrentTenant.cs

@@ -2,23 +2,19 @@
 using JetBrains.Annotations;
 using PlatformPlatform.AccountManagement.Features.Tenants.Domain;
 using PlatformPlatform.SharedKernel.Cqrs;
-using PlatformPlatform.SharedKernel.Domain;
 using PlatformPlatform.SharedKernel.Telemetry;
 
 namespace PlatformPlatform.AccountManagement.Features.Tenants.Commands;
 
 [PublicAPI]
-public sealed record UpdateTenantCommand : ICommand, IRequest<Result>
+public sealed record UpdateCurrentTenantCommand : ICommand, IRequest<Result>
 {
-    [JsonIgnore] // Removes this property from the API contract
-    public TenantId Id { get; init; } = null!;
-
     public required string Name { get; init; }
 }
 
-public sealed class UpdateTenantValidator : AbstractValidator<UpdateTenantCommand>
+public sealed class UpdateCurrentTenantValidator : AbstractValidator<UpdateCurrentTenantCommand>
 {
-    public UpdateTenantValidator()
+    public UpdateCurrentTenantValidator()
     {
         RuleFor(x => x.Name).NotEmpty();
         RuleFor(x => x.Name).Length(1, 30)
@@ -28,12 +24,11 @@ public UpdateTenantValidator()
 }
 
 public sealed class UpdateTenantHandler(ITenantRepository tenantRepository, ITelemetryEventsCollector events)
-    : IRequestHandler<UpdateTenantCommand, Result>
+    : IRequestHandler<UpdateCurrentTenantCommand, Result>
 {
-    public async Task<Result> Handle(UpdateTenantCommand command, CancellationToken cancellationToken)
+    public async Task<Result> Handle(UpdateCurrentTenantCommand command, CancellationToken cancellationToken)
     {
-        var tenant = await tenantRepository.GetByIdAsync(command.Id, cancellationToken);
-        if (tenant is null) return Result.NotFound($"Tenant with id '{command.Id}' not found.");
+        var tenant = await tenantRepository.GetCurrentTenantAsync(cancellationToken);
 
         tenant.Update(command.Name);
         tenantRepository.Update(tenant);

application/account-management/Core/Features/Tenants/Domain/TenantRepository.cs

@@ -1,20 +1,30 @@
 using Microsoft.EntityFrameworkCore;
 using PlatformPlatform.AccountManagement.Database;
 using PlatformPlatform.SharedKernel.Domain;
+using PlatformPlatform.SharedKernel.ExecutionContext;
 using PlatformPlatform.SharedKernel.Persistence;
 
 namespace PlatformPlatform.AccountManagement.Features.Tenants.Domain;
 
 public interface ITenantRepository : ICrudRepository<Tenant, TenantId>
 {
+    Task<Tenant> GetCurrentTenantAsync(CancellationToken cancellationToken);
+
     Task<bool> ExistsAsync(TenantId id, CancellationToken cancellationToken);
 
     Task<bool> IsSubdomainFreeAsync(string subdomain, CancellationToken cancellationToken);
 }
 
-internal sealed class TenantRepository(AccountManagementDbContext accountManagementDbContext)
+internal sealed class TenantRepository(AccountManagementDbContext accountManagementDbContext, IExecutionContext executionContext)
     : RepositoryBase<Tenant, TenantId>(accountManagementDbContext), ITenantRepository
 {
+    public async Task<Tenant> GetCurrentTenantAsync(CancellationToken cancellationToken)
+    {
+        ArgumentNullException.ThrowIfNull(executionContext.TenantId!);
+        return await GetByIdAsync(executionContext.TenantId, cancellationToken) ??
+               throw new InvalidOperationException("Active tenant not found.");
+    }
+
     public Task<bool> IsSubdomainFreeAsync(string subdomain, CancellationToken cancellationToken)
     {
         return DbSet.AllAsync(tenant => tenant.Id != subdomain, cancellationToken);

…re/Features/Tenants/Queries/GetTenant.cs …ures/Tenants/Queries/GetCurrentTenant.csapplication/account-management/Core/Features/Tenants/Queries/GetTenant.cs renamed to application/account-management/Core/Features/Tenants/Queries/GetCurrentTenant.cs application/account-management/Core/Features/Tenants/Queries/GetTenant.cs renamed to application/account-management/Core/Features/Tenants/Queries/GetCurrentTenant.cs

@@ -7,7 +7,7 @@
 namespace PlatformPlatform.AccountManagement.Features.Tenants.Queries;
 
 [PublicAPI]
-public sealed record GetTenantQuery(TenantId Id) : IRequest<Result<TenantResponse>>;
+public sealed record GetTenantQuery : IRequest<Result<TenantResponse>>;
 
 [PublicAPI]
 public sealed record TenantResponse(TenantId Id, DateTimeOffset CreatedAt, DateTimeOffset? ModifiedAt, string Name, TenantState State);
@@ -17,7 +17,7 @@ public sealed class GetTenantHandler(ITenantRepository tenantRepository)
 {
     public async Task<Result<TenantResponse>> Handle(GetTenantQuery query, CancellationToken cancellationToken)
     {
-        var tenant = await tenantRepository.GetByIdAsync(query.Id, cancellationToken);
-        return tenant?.Adapt<TenantResponse>() ?? Result<TenantResponse>.NotFound($"Tenant with id '{query.Id}' not found.");
+        var tenant = await tenantRepository.GetCurrentTenantAsync(cancellationToken);
+        return tenant.Adapt<TenantResponse>();
     }
 }

application/account-management/Tests/Tenants/DeleteTenantTests.cs

@@ -20,7 +20,7 @@ public async Task DeleteTenant_WhenTenantDoesNotExists_ShouldReturnNotFound()
         var unknownTenantId = Faker.Subdomain();
 
         // Act
-        var response = await AuthenticatedHttpClient.DeleteAsync($"/api/account-management/tenants/{unknownTenantId}");
+        var response = await AuthenticatedHttpClient.DeleteAsync($"/internal-api/account-management/tenants/{unknownTenantId}");
 
         //Assert
         await response.ShouldHaveErrorStatusCode(HttpStatusCode.NotFound, $"Tenant with id '{unknownTenantId}' not found.");
@@ -50,7 +50,7 @@ public async Task DeleteTenant_WhenTenantHasUsers_ShouldReturnBadRequest()
         );
 
         // Act
-        var response = await AuthenticatedHttpClient.DeleteAsync($"/api/account-management/tenants/{existingTenantId}");
+        var response = await AuthenticatedHttpClient.DeleteAsync($"/internal-api/account-management/tenants/{existingTenantId}");
         TelemetryEventsCollectorSpy.Reset();
 
         // Assert
@@ -70,7 +70,7 @@ public async Task DeleteTenant_WhenTenantHasNoUsers_ShouldDeleteTenant()
         var existingTenantId = DatabaseSeeder.Tenant1.Id;
 
         // Act
-        var response = await AuthenticatedHttpClient.DeleteAsync($"/api/account-management/tenants/{existingTenantId}");
+        var response = await AuthenticatedHttpClient.DeleteAsync($"/internal-api/account-management/tenants/{existingTenantId}");
 
         // Assert
         response.ShouldHaveEmptyHeaderAndLocationOnSuccess();

application/account-management/Tests/Tenants/GetCurrentTenantTests.cs

@@ -0,0 +1,40 @@
+using FluentAssertions;
+using NJsonSchema;
+using PlatformPlatform.AccountManagement.Database;
+using PlatformPlatform.SharedKernel.Tests;
+using Xunit;
+
+namespace PlatformPlatform.AccountManagement.Tests.Tenants;
+
+public sealed class GetCurrentTenantTests : EndpointBaseTest<AccountManagementDbContext>
+{
+    [Fact]
+    public async Task GetCurrentTenant_WhenTenantExists_ShouldReturnTenantWithValidContract()
+    {
+        // Act
+        var response = await AuthenticatedHttpClient.GetAsync("/api/account-management/tenants/current");
+
+        // Assert
+        response.ShouldBeSuccessfulGetRequest();
+
+        var schema = await JsonSchema.FromJsonAsync(
+            """
+            {
+                'type': 'object',
+                'properties': {
+                    'id': {'type': 'string', 'pattern': '^(?=.{3,30}$)(?!-)[a-z0-9-]*(?<!-)$'},
+                    'createdAt': {'type': 'string', 'format': 'date-time'},
+                    'modifiedAt': {'type': ['null', 'string'], 'format': 'date-time'},
+                    'name': {'type': 'string', 'minLength': 1, 'maxLength': 30},
+                    'state': {'type': 'string', 'minLength': 1, 'maxLength':20}
+                },
+                'required': ['id', 'createdAt', 'modifiedAt', 'name', 'state'],
+                'additionalProperties': false
+            }
+            """
+        );
+
+        var responseBody = await response.Content.ReadAsStringAsync();
+        schema.Validate(responseBody).Should().BeEmpty();
+    }
+}

application/account-management/Tests/Tenants/GetTenantTests.cs

@@ -9,17 +9,16 @@
 
 namespace PlatformPlatform.AccountManagement.Tests.Tenants;
 
-public sealed class UpdateTenantTests : EndpointBaseTest<AccountManagementDbContext>
+public sealed class UpdateCurrentTenantTests : EndpointBaseTest<AccountManagementDbContext>
 {
     [Fact]
-    public async Task UpdateTenant_WhenValid_ShouldUpdateTenant()
+    public async Task UpdateCurrentTenant_WhenValid_ShouldUpdateTenant()
     {
         // Arrange
-        var existingTenantId = DatabaseSeeder.Tenant1.Id;
-        var command = new UpdateTenantCommand { Name = Faker.TenantName() };
+        var command = new UpdateCurrentTenantCommand { Name = Faker.TenantName() };
 
         // Act
-        var response = await AuthenticatedHttpClient.PutAsJsonAsync($"/api/account-management/tenants/{existingTenantId}", command);
+        var response = await AuthenticatedHttpClient.PutAsJsonAsync("/api/account-management/tenants/current", command);
 
         // Assert
         response.ShouldHaveEmptyHeaderAndLocationOnSuccess();
@@ -30,15 +29,14 @@ public async Task UpdateTenant_WhenValid_ShouldUpdateTenant()
     }
 
     [Fact]
-    public async Task UpdateTenant_WhenInvalid_ShouldReturnBadRequest()
+    public async Task UpdateCurrentTenant_WhenInvalid_ShouldReturnBadRequest()
     {
         // Arrange
-        var existingTenantId = DatabaseSeeder.Tenant1.Id;
         var invalidName = Faker.Random.String2(31);
-        var command = new UpdateTenantCommand { Name = invalidName };
+        var command = new UpdateCurrentTenantCommand { Name = invalidName };
 
         // Act
-        var response = await AuthenticatedHttpClient.PutAsJsonAsync($"/api/account-management/tenants/{existingTenantId}", command);
+        var response = await AuthenticatedHttpClient.PutAsJsonAsync("/api/account-management/tenants/current", command);
 
         // Assert
         var expectedErrors = new[]
@@ -49,20 +47,4 @@ public async Task UpdateTenant_WhenInvalid_ShouldReturnBadRequest()
 
         TelemetryEventsCollectorSpy.AreAllEventsDispatched.Should().BeFalse();
     }
-
-    [Fact]
-    public async Task UpdateTenant_WhenTenantDoesNotExists_ShouldReturnNotFound()
-    {
-        // Arrange
-        var unknownTenantId = Faker.Subdomain();
-        var command = new UpdateTenantCommand { Name = Faker.TenantName() };
-
-        // Act
-        var response = await AuthenticatedHttpClient.PutAsJsonAsync($"/api/account-management/tenants/{unknownTenantId}", command);
-
-        //Assert
-        await response.ShouldHaveErrorStatusCode(HttpStatusCode.NotFound, $"Tenant with id '{unknownTenantId}' not found.");
-
-        TelemetryEventsCollectorSpy.AreAllEventsDispatched.Should().BeFalse();
-    }
 }