Clean up some unused code

Author: pjcdawkins

src/Command/App/AppListCommand.php

@@ -2,8 +2,6 @@
 namespace Platformsh\Cli\Command\App;
 
 use Platformsh\Cli\Command\CommandBase;
-use Platformsh\Cli\Local\ApplicationFinder;
-use Platformsh\Cli\Local\LocalApplication;
 use Platformsh\Cli\Service\Table;
 use Platformsh\Client\Model\Deployment\EnvironmentDeployment;
 use Symfony\Component\Console\Input\InputInterface;

src/Command/Auth/ApiTokenLoginCommand.php

@@ -4,7 +4,6 @@
 use CommerceGuys\Guzzle\Oauth2\AccessToken;
 use GuzzleHttp\Client;
 use GuzzleHttp\Exception\BadResponseException;
-use GuzzleHttp\Url;
 use Platformsh\Cli\Command\CommandBase;
 use Platformsh\Client\OAuth2\ApiToken;
 use Symfony\Component\Console\Input\InputInterface;

src/Command/CompletionCommand.php

@@ -4,7 +4,6 @@
 
 use Platformsh\Cli\Local\ApplicationFinder;
 use Platformsh\Cli\Service\Api;
-use Platformsh\Cli\Local\LocalApplication;
 use Stecman\Component\Symfony\Console\BashCompletion\Completion;
 use Stecman\Component\Symfony\Console\BashCompletion\CompletionCommand as ParentCompletionCommand;
 

src/Command/Environment/EnvironmentXdebugCommand.php

@@ -2,7 +2,6 @@
 namespace Platformsh\Cli\Command\Environment;
 
 use Platformsh\Cli\Command\CommandBase;
-use Platformsh\Cli\Local\LocalApplication;
 use Platformsh\Cli\Service\Ssh;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;

src/Command/Local/LocalDrushAliasesCommand.php

@@ -76,7 +76,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
 
         $aliases = $drush->getAliases($current_group);
         $new_group = ltrim($input->getOption('group'), '@');
-        if (empty($aliases) && !$new_group && $project && $current_group === $project->id) {
+        if (empty($aliases) && !$new_group && $current_group === $project->id) {
             $new_group = (new Slugify())->slugify($project->title);
         }
 

src/Command/Mount/MountUploadCommand.php

@@ -3,7 +3,6 @@
 namespace Platformsh\Cli\Command\Mount;
 
 use Platformsh\Cli\Command\CommandBase;
-use Platformsh\Cli\Local\LocalApplication;
 use Platformsh\Cli\Service\Ssh;
 use Platformsh\Cli\Util\OsUtil;
 use Symfony\Component\Console\Input\InputInterface;

src/Command/MultiCommand.php

@@ -75,9 +75,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             try {
                 $application->setCurrentCommand($command);
                 $commandInput = new StringInput($commandLine . ' --project ' . escapeshellarg($project->id));
-                if ($command instanceof MultiAwareInterface) {
-                    $command->setRunningViaMulti(true);
-                }
+                $command->setRunningViaMulti(true);
                 $returnCode = $command->run($commandInput, $output);
                 $application->setCurrentCommand($this);
                 if ($returnCode !== 0) {

src/Command/Project/Variable/ProjectVariableSetCommand.php

@@ -79,8 +79,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
      */
     protected function validateJson($string)
     {
-        $null = json_decode($string) === null;
-
-        return !$null || ($null && $string === 'null');
+        if ($string === 'null') {
+            return true;
+        }
+        return \json_decode($string) !== null;
     }
 }

src/Command/Route/RouteListCommand.php

@@ -23,7 +23,7 @@ protected function configure()
             ->setAliases(['routes'])
             ->setDescription('List all routes for an environment')
             ->addArgument('environment', InputArgument::OPTIONAL, 'The environment ID')
-            ->addOption('refresh', null, InputOption::VALUE_NONE, 'Bypass the cache of routes');;
+            ->addOption('refresh', null, InputOption::VALUE_NONE, 'Bypass the cache of routes');
         $this->setHiddenAliases(['environment:routes']);
         Table::configureInput($this->getDefinition());
         $this->addProjectOption()

src/Command/Server/ServerRunCommand.php

@@ -2,7 +2,6 @@
 namespace Platformsh\Cli\Command\Server;
 
 use Platformsh\Cli\Exception\RootNotFoundException;
-use Platformsh\Cli\Local\LocalApplication;
 use Platformsh\Cli\Local\BuildFlavor\Drupal;
 use Platformsh\Cli\Service\Url;
 use Platformsh\Cli\Util\PortUtil;