Add missing tests

Author: nguereza-tony

src/Attestation/Format/BaseFormat.php

@@ -44,7 +44,7 @@ abstract class BaseFormat implements JsonSerializable
 {
     /**
      * The attestation object data
-     * @var array<string, mixed>
+     * @var array<string|int, mixed>
      */
     protected array $attestationData;
 
@@ -68,7 +68,7 @@ abstract class BaseFormat implements JsonSerializable
 
     /**
      * Create new instance
-     * @param array<string, mixed> $attestationData
+     * @param array<string|int, mixed> $attestationData
      * @param AuthenticatorData $authenticatorData
      */
     public function __construct(

src/Attestation/Format/FidoU2F.php

@@ -63,7 +63,7 @@ class FidoU2F extends BaseFormat
 
     /**
      * Create new instance
-     * @param array<string, mixed> $attestationData
+     * @param array<string|int, mixed> $attestationData
      * @param AuthenticatorData $authenticatorData
      */
     public function __construct(

src/Attestation/Format/Packed.php

@@ -63,7 +63,7 @@ class Packed extends BaseFormat
 
     /**
      * Create new instance
-     * @param array<string, mixed> $attestationData
+     * @param array<string|int, mixed> $attestationData
      * @param AuthenticatorData $authenticatorData
      */
     public function __construct(

src/Attestation/Format/Tpm.php

@@ -78,7 +78,7 @@ class Tpm extends BaseFormat
 
     /**
      * Create new instance
-     * @param array<string, mixed> $attestationData
+     * @param array<string|int, mixed> $attestationData
      * @param AuthenticatorData $authenticatorData
      */
     public function __construct(

src/Entity/PublicKey.php

@@ -100,7 +100,7 @@ class PublicKey implements JsonSerializable
      * The attestation to use
      * @var string
      */
-    protected string $attestation;
+    protected string $attestation = '';
 
     /**
      * The relying party id. This is used only for login

src/Helper/CborDecoder.php

@@ -57,7 +57,7 @@ class CborDecoder
      */
     public static function decode($data)
     {
-        if (is_string($data)) {
+        if (! $data instanceof ByteBuffer) {
             $data = new ByteBuffer($data);
         }
 
@@ -82,7 +82,7 @@ public static function decode($data)
      */
     public static function decodeInPlace($data, int $startoffset, ?int $endOffset = null)
     {
-        if (is_string($data)) {
+        if (! $data instanceof ByteBuffer) {
             $data = new ByteBuffer($data);
         }
 

src/Webauthn.php

@@ -120,12 +120,18 @@ public function __construct(WebauthnConfiguration $config, array $allowedFormats
 
     /**
      * Add a root certificate to verify new registrations
-     * @param string $path
+     * @param string|array<string> $path
      * @return $this
      */
-    public function addRootCertificate(string $path): self
+    public function addRootCertificate($path): self
     {
-        $this->certificates[] = Path::realPath($path);
+        if (is_array($path)) {
+            foreach ($path as $p) {
+                $this->certificates[] = Path::realPath($p);
+            }
+        } else {
+            $this->certificates[] = Path::realPath($path);
+        }
 
         return $this;
     }

tests/Entity/PublicKeyTest.php

@@ -88,6 +88,6 @@ public function testJson(): void
 
         $json = $o->jsonSerialize();
 
-        $this->assertCount(7, $json);
+        $this->assertCount(8, $json);
     }
 }