Bump elixir to 1.17.3 and OTP to 27.2.1 (#5040)

* Bump elixir to 1.17.3 and OTP to 27.2.1

To address erlang/otp#8588

* Bump cache

* Bump secondary alpine

* Try unzip due to `{:error, :bad_eocd}` on OTP 27.2.1

* jfc

* Revert "jfc"

This reverts commit 018d33f.

* Revert "Try unzip due to `{:error, :bad_eocd}` on OTP 27.2.1"

This reverts commit e04750f.

* huh

* Use Plausible.File.mv!

* Another one

* fixup

* Format

* Another one

* Format

* Update test/plausible/exports_test.exs

Co-authored-by: ruslandoga <[email protected]>

* Bump CI cache again

---------

Co-authored-by: ruslandoga <[email protected]>

Author: aerosol

.github/workflows/elixir.yml

@@ -11,7 +11,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  CACHE_VERSION: v8
+  CACHE_VERSION: v10
   PERSISTENT_CACHE_DIR: cached
 
 jobs:

.tool-versions

@@ -1,3 +1,3 @@
-erlang 27.0
-elixir 1.17.1-otp-27
+erlang 27.2.1
+elixir 1.17.3-otp-27
 nodejs 21.7.3

Dockerfile

@@ -2,7 +2,7 @@
 # platform specific, it makes sense to build it in the docker
 
 #### Builder
-FROM hexpm/elixir:1.17.1-erlang-27.0-alpine-3.20.1 AS buildcontainer
+FROM hexpm/elixir:1.17.3-erlang-27.2.1-alpine-3.20.5 AS buildcontainer
 
 ARG MIX_ENV=ce
 
@@ -54,7 +54,7 @@ COPY rel rel
 RUN mix release plausible
 
 # Main Docker Image
-FROM alpine:3.20.1
+FROM alpine:3.20.5
 LABEL maintainer="plausible.io <[email protected]>"
 
 ARG BUILD_METADATA={}

test/plausible/exports_test.exs

@@ -89,7 +89,9 @@ defmodule Plausible.ExportsTest do
       end)
 
       assert {:ok, files} =
-               :zip.unzip(to_charlist(Path.join(tmp_dir, "numbers.zip")), cwd: tmp_dir)
+               :zip.unzip(to_charlist(Path.join(tmp_dir, "numbers.zip")),
+                 cwd: to_charlist(tmp_dir)
+               )
 
       assert Enum.map(files, &Path.basename/1) == ["1.csv", "2.csv"]
 
@@ -137,8 +139,10 @@ defmodule Plausible.ExportsTest do
         end)
       end
 
-      assert {:error, :einval} =
-               :zip.unzip(to_charlist(Path.join(tmp_dir, "failed.zip")), cwd: tmp_dir)
+      assert {:error, :bad_eocd} =
+               :zip.unzip(to_charlist(Path.join(tmp_dir, "failed.zip")),
+                 cwd: to_charlist(tmp_dir)
+               )
     end
   end
 end

test/plausible/imported/csv_importer_test.exs

@@ -1228,17 +1228,19 @@ defmodule Plausible.Imported.CSVImporterTest do
         )
       )
     else
-      File.rename!(context.local_path, Path.join(tmp_dir, "plausible-export.zip"))
+      Plausible.File.mv!(context.local_path, Path.join(tmp_dir, "plausible-export.zip"))
     end
 
     context
   end
 
   defp unzip_archive(%{tmp_dir: tmp_dir} = context) do
     assert {:ok, files} =
-             :zip.unzip(to_charlist(Path.join(tmp_dir, "plausible-export.zip")), cwd: tmp_dir)
+             :zip.unzip(to_charlist(Path.join(tmp_dir, "plausible-export.zip")),
+               cwd: to_charlist(tmp_dir)
+             )
 
-    Map.put(context, :exported_files, files)
+    Map.put(context, :exported_files, Enum.map(files, &to_string/1))
   end
 
   defp upload_csvs(%{exported_files: files} = context) do