Prevent Salts server from dirty postgres disconnects during tests (#5968)

Author: aerosol

test/support/conn_case.ex

@@ -40,6 +40,8 @@ defmodule PlausibleWeb.ConnCase do
       Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, {:shared, self()})
     end
 
+    Plausible.Test.Support.Sandbox.allow_salts_process()
+
     # randomize client ip to avoid accidentally hitting
     # rate limiting during tests
     conn =

test/support/data_case.ex

@@ -37,6 +37,8 @@ defmodule Plausible.DataCase do
       Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, {:shared, self()})
     end
 
+    Plausible.Test.Support.Sandbox.allow_salts_process()
+
     :ok
   end
 end

test/support/plugins_api_case.ex

@@ -41,6 +41,8 @@ defmodule PlausibleWeb.PluginsAPICase do
       Ecto.Adapters.SQL.Sandbox.mode(Plausible.Repo, {:shared, self()})
     end
 
+    Plausible.Test.Support.Sandbox.allow_salts_process()
+
     conn = Phoenix.ConnTest.build_conn()
 
     site = Plausible.Teams.Test.new_site()

test/support/sandbox.ex

@@ -0,0 +1,15 @@
+defmodule Plausible.Test.Support.Sandbox do
+  @moduledoc """
+  Prevent background processes from interfering with tests 
+  (e.g. exiting before properly returning the connection) by allowing them to access sandbox
+  """
+  def allow_salts_process do
+    case Process.whereis(Plausible.Session.Salts) do
+      nil ->
+        :ok
+
+      pid ->
+        Ecto.Adapters.SQL.Sandbox.allow(Plausible.Repo, self(), pid)
+    end
+  end
+end