Platform upgrade: elixir 1.19.4 and otp 27.3.4.6 (#5920)

* Platform upgrade: elixir 1.19.4 and otp 27.3.4.6

* !fixup

* credo

* credo

* Bump cache

* fix docker image tag

* hum

* hum

* Match docker images

* Define ALPINE_VERSION once

* fixup

Author: aerosol

.github/workflows/elixir.yml

@@ -11,7 +11,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  CACHE_VERSION: v16
+  CACHE_VERSION: v17
   PERSISTENT_CACHE_DIR: cached
 
 jobs:

.tool-versions

@@ -1,3 +1,3 @@
-erlang 27.3.1
-elixir 1.18.3-otp-27
+erlang 27.3.4.6
+elixir 1.19.4-otp-27
 nodejs 23.2.0

Dockerfile

@@ -1,8 +1,10 @@
 # we can not use the pre-built tar because the distribution is
 # platform specific, it makes sense to build it in the docker
 
+ARG ALPINE_VERSION=3.22.2
+
 #### Builder
-FROM hexpm/elixir:1.18.3-erlang-27.3.1-alpine-3.21.3 AS buildcontainer
+FROM hexpm/elixir:1.19.4-erlang-27.3.4.6-alpine-${ALPINE_VERSION} AS buildcontainer
 
 ARG MIX_ENV=ce
 
@@ -20,7 +22,7 @@ RUN mkdir /app
 WORKDIR /app
 
 # install build dependencies
-RUN apk add --no-cache git "nodejs-current=23.2.0-r1" yarn npm python3 ca-certificates wget gnupg make gcc libc-dev brotli
+RUN apk add --no-cache git "nodejs-current=23.11.1-r0" yarn npm python3 ca-certificates wget gnupg make gcc libc-dev brotli
 
 COPY mix.exs ./
 COPY mix.lock ./
@@ -54,7 +56,7 @@ COPY rel rel
 RUN mix release plausible
 
 # Main Docker Image
-FROM alpine:3.21.3
+FROM alpine:${ALPINE_VERSION}
 LABEL maintainer="plausible.io <hello@plausible.io>"
 
 ARG BUILD_METADATA={}
@@ -84,3 +86,4 @@ EXPOSE 8000
 ENV DEFAULT_DATA_DIR=/var/lib/plausible
 VOLUME /var/lib/plausible
 CMD ["run"]
+

lib/plausible/auth/user.ex

@@ -1,15 +1,3 @@
-defimpl Bamboo.Formatter, for: Plausible.Auth.User do
-  def format_email_address(user, _opts) do
-    {user.name, user.email}
-  end
-end
-
-defimpl FunWithFlags.Actor, for: Plausible.Auth.User do
-  def id(%{id: id}) do
-    "user:#{id}"
-  end
-end
-
 defmodule Plausible.Auth.User do
   use Plausible
   use Ecto.Schema
@@ -284,3 +272,15 @@ defmodule Plausible.Auth.User do
     end
   end
 end
+
+defimpl Bamboo.Formatter, for: Plausible.Auth.User do
+  def format_email_address(user, _opts) do
+    {user.name, user.email}
+  end
+end
+
+defimpl FunWithFlags.Actor, for: Plausible.Auth.User do
+  def id(%{id: id}) do
+    "user:#{id}"
+  end
+end

lib/plausible/google/ga4/api.ex

@@ -202,7 +202,7 @@ defmodule Plausible.Google.GA4.API do
     end
   end
 
-  defp prepare_request(report_request, date_range, property, access_token) do
+  defp prepare_request(%GA4.ReportRequest{} = report_request, date_range, property, access_token) do
     %GA4.ReportRequest{
       report_request
       | date_range: date_range,

lib/plausible/shield/country_rule_cache.ex

@@ -44,7 +44,7 @@ defmodule Plausible.Shield.CountryRuleCache do
       |> where([rule, site], rule.country_code == ^country_code and site.domain == ^domain)
 
     case Plausible.Repo.one(query) do
-      {_, _, rule} -> %CountryRule{rule | from_cache?: false}
+      {_, _, rule = %CountryRule{}} -> %CountryRule{rule | from_cache?: false}
       _any -> nil
     end
   end

lib/plausible/shield/hostname_rule_cache.ex

@@ -45,7 +45,7 @@ defmodule Plausible.Shield.HostnameRuleCache do
 
     case Plausible.Repo.all(query) do
       [_ | _] = results ->
-        Enum.map(results, fn {_, _, rule} ->
+        Enum.map(results, fn {_, _, rule = %HostnameRule{}} ->
           %HostnameRule{rule | from_cache?: false}
         end)
 

lib/plausible/shield/ip_rule_cache.ex

@@ -44,7 +44,7 @@ defmodule Plausible.Shield.IPRuleCache do
       |> where([rule, site], rule.inet == ^address and site.domain == ^domain)
 
     case Plausible.Repo.one(query) do
-      {_, _, rule} -> %IPRule{rule | from_cache?: false}
+      {_, _, rule = %IPRule{}} -> %IPRule{rule | from_cache?: false}
       _any -> nil
     end
   end

lib/plausible/shield/page_rule_cache.ex

@@ -44,7 +44,7 @@ defmodule Plausible.Shield.PageRuleCache do
       |> where([..., site], site.domain == ^domain)
 
     case Plausible.Repo.one(query) do
-      {_, _, rule} -> %PageRule{rule | from_cache?: false}
+      {_, _, rule = %PageRule{}} -> %PageRule{rule | from_cache?: false}
       _any -> nil
     end
   end

lib/plausible/site/cache.ex

@@ -63,7 +63,7 @@ defmodule Plausible.Site.Cache do
     query = from s in base_db_query(), where: s.domain == ^domain
 
     case Plausible.Repo.one(query) do
-      {_, _, site} -> %Site{site | from_cache?: false}
+      {_, _, site = %Site{}} -> %Site{site | from_cache?: false}
       _any -> nil
     end
   end