Skip to content

Commit bba9740

Browse files
committed
Fix up flaky tests
The suggest function sleeps for 500ms, so we need sufficient retries to handle both the task execution time and LiveView message processing under low resources. With this I couldn't reproduce anymore in repetead runs. In the other case, funnel saved message may arrive after the test is done and this is when Funnels are listed again.
1 parent 4d5372b commit bba9740

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

test/plausible_web/live/components/combo_box_test.exs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -372,8 +372,8 @@ defmodule PlausibleWeb.Live.Components.ComboBoxTest do
372372
true
373373
}
374374
end,
375-
200,
376-
20
375+
50,
376+
50
377377
)
378378
end
379379

@@ -393,8 +393,8 @@ defmodule PlausibleWeb.Live.Components.ComboBoxTest do
393393
true
394394
}
395395
end,
396-
200,
397-
20
396+
50,
397+
50
398398
)
399399
end
400400
end

test/plausible_web/live/funnel_settings_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
defmodule PlausibleWeb.Live.FunnelSettingsTest do
2-
use PlausibleWeb.ConnCase, async: true
2+
use PlausibleWeb.ConnCase, async: false
33
@moduletag :ee_only
44

55
on_ee do

0 commit comments

Comments
 (0)