Fix and move test env switch inside the modal component

Author: zoldar

lib/plausible_web/live/components/modal.ex

@@ -131,7 +131,12 @@ defmodule PlausibleWeb.Live.Components.Modal do
 
   @impl true
   def update(assigns, socket) do
-    preload? = Map.get(assigns, :preload?, true)
+    preload? =
+      if Mix.env() in [:test, :ce_test] do
+        true
+      else
+        Map.get(assigns, :preload?, true)
+      end
 
     socket =
       assign(socket,

lib/plausible_web/live/goal_settings.ex

@@ -51,12 +51,7 @@ defmodule PlausibleWeb.Live.GoalSettings do
     <div id="goal-settings-main">
       <.flash_messages flash={@flash} />
 
-      <.live_component
-        :let={modal_unique_id}
-        module={Modal}
-        preload?={Mix.env() == :test}
-        id="goals-form-modal"
-      >
+      <.live_component :let={modal_unique_id} module={Modal} preload?={false} id="goals-form-modal">
         <.live_component
           module={PlausibleWeb.Live.GoalSettings.Form}
           id={"goals-form-#{modal_unique_id}"}