From 3eaa960630989436340040503b706ee925becae5 Mon Sep 17 00:00:00 2001 From: Sanne de Vries Date: Thu, 20 Nov 2025 14:52:41 +0100 Subject: [PATCH 1/2] Fix Safari bug where `+ Add another step` button wasn't hidden properly --- .../plausible_web/live/funnel_settings/form.ex | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/extra/lib/plausible_web/live/funnel_settings/form.ex b/extra/lib/plausible_web/live/funnel_settings/form.ex index fa18248be046..c59d218ce5af 100644 --- a/extra/lib/plausible_web/live/funnel_settings/form.ex +++ b/extra/lib/plausible_web/live/funnel_settings/form.ex @@ -84,7 +84,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do Funnel steps -
+
<.live_component selected={find_preselected(@funnel, @funnel_modified?, step_idx)} @@ -117,13 +117,12 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do
- <.add_step_button :if={ - length(@step_ids) < Funnel.max_steps() and - map_size(@selections_made) < length(@goals) - } /> -
-

+ <.add_step_button :if={ + length(@step_ids) < Funnel.max_steps() and + map_size(@selections_made) < length(@goals) + } /> +

<%= if @evaluation_result do %> Last month conversion rate: <%= List.last(@evaluation_result.steps).conversion_rate %>% <% end %> @@ -179,7 +178,7 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do def add_step_button(assigns) do ~H""" - + + Add another step """ From 702c9e29f5039609707ff6c2b6aced3cd364f939 Mon Sep 17 00:00:00 2001 From: Sanne de Vries Date: Thu, 20 Nov 2025 15:23:02 +0100 Subject: [PATCH 2/2] Increase spacing between add step button and conversion rate when both are shown --- extra/lib/plausible_web/live/funnel_settings/form.ex | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extra/lib/plausible_web/live/funnel_settings/form.ex b/extra/lib/plausible_web/live/funnel_settings/form.ex index c59d218ce5af..63250f402475 100644 --- a/extra/lib/plausible_web/live/funnel_settings/form.ex +++ b/extra/lib/plausible_web/live/funnel_settings/form.ex @@ -117,12 +117,12 @@ defmodule PlausibleWeb.Live.FunnelSettings.Form do

-
+
<.add_step_button :if={ length(@step_ids) < Funnel.max_steps() and map_size(@selections_made) < length(@goals) } /> -

+

<%= if @evaluation_result do %> Last month conversion rate: <%= List.last(@evaluation_result.steps).conversion_rate %>% <% end %>