Use math.DEG_TO_RAD uinstead of PI / 180 internally (#8111)

Co-authored-by: Martin Valigursky <[email protected]>

Author: mvaligursky

src/extras/exporters/gltf-exporter.js

@@ -325,7 +325,7 @@ class GltfExporter extends CoreExporter {
 
                     camera.type = 'perspective';
                     camera.perspective = {
-                        yfov: fov * Math.PI / 180,
+                        yfov: fov * math.DEG_TO_RAD,
                         znear: nearClip,
                         zfar: farClip
                     };

src/extras/render-passes/render-pass-ssao.js

@@ -1,5 +1,6 @@
 import { BlueNoise } from '../../core/math/blue-noise.js';
 import { Color } from '../../core/math/color.js';
+import { math } from '../../core/math/math.js';
 import {
     ADDRESS_CLAMP_TO_EDGE, FILTER_NEAREST, PIXELFORMAT_R8, SEMANTIC_POSITION, SHADERLANGUAGE_GLSL,
     SHADERLANGUAGE_WGSL
@@ -197,7 +198,7 @@ class RenderPassSsao extends RenderPassShaderQuad {
 
         scope.resolve('uSampleCount').setValue([sampleCount, 1.0 / sampleCount]);
 
-        const minAngleSin = Math.sin(minAngle * Math.PI / 180.0);
+        const minAngleSin = Math.sin(minAngle * math.DEG_TO_RAD);
         scope.resolve('uMinHorizonAngleSineSquared').setValue(minAngleSin * minAngleSin);
 
         const spiralTurns = 10.0;

src/scene/camera.js

@@ -685,7 +685,7 @@ class Camera {
      */
     getFrustumCorners(near = this.nearClip, far = this.farClip) {
 
-        const fov = this.fov * Math.PI / 180.0;
+        const fov = this.fov * math.DEG_TO_RAD;
         let x, y;
 
         if (this.projection === PROJECTION_PERSPECTIVE) {

src/scene/gsplat-unified/gsplat-manager.js

@@ -399,7 +399,7 @@ class GSplatManager {
                 const currentCameraFwd = this.cameraNode.forward;
                 const dot = Math.min(1, Math.max(-1, this.lastLodCameraFwd.dot(currentCameraFwd)));
                 const angle = Math.acos(dot);
-                const rotThreshold = lodUpdateAngleDeg * Math.PI / 180;
+                const rotThreshold = lodUpdateAngleDeg * math.DEG_TO_RAD;
                 cameraRotated = angle > rotThreshold;
             } else {
                 // first run, force update to initialize last orientation

src/scene/light.js

@@ -254,7 +254,7 @@ class Light {
 
         this._position = new Vec3(0, 0, 0);
         this._direction = new Vec3(0, 0, 0);
-        this._innerConeAngleCos = Math.cos(this._innerConeAngle * Math.PI / 180);
+        this._innerConeAngleCos = Math.cos(this._innerConeAngle * math.DEG_TO_RAD);
         this._updateOuterAngle(this._outerConeAngle);
 
         this._usePhysicalUnits = undefined;
@@ -630,7 +630,7 @@ class Light {
         }
 
         this._innerConeAngle = value;
-        this._innerConeAngleCos = Math.cos(value * Math.PI / 180);
+        this._innerConeAngleCos = Math.cos(value * math.DEG_TO_RAD);
         this.updateClusterData(false, true);
 
         if (this._usePhysicalUnits) {
@@ -677,7 +677,7 @@ class Light {
     }
 
     _updateOuterAngle(angle) {
-        const radAngle = angle * Math.PI / 180;
+        const radAngle = angle * math.DEG_TO_RAD;
         this._outerConeAngleCos = Math.cos(radAngle);
         this._outerConeAngleSin = Math.sin(radAngle);
         this.updateClusterData(false, true);
@@ -1205,13 +1205,13 @@ class Light {
 
             // Shrink angles slightly (~1%) to prevent light leaking outside shadow boundaries
             const angleShrinkFactor = 0.99;
-            let innerCos = Math.cos(this._innerConeAngle * angleShrinkFactor * Math.PI / 180);
+            let innerCos = Math.cos(this._innerConeAngle * angleShrinkFactor * math.DEG_TO_RAD);
             if (innerCos > cosThreshold) {
                 innerCos = 1.0 - innerCos;
                 flags |= 1; // Use bit 0 for inner angle: 1 = versine, 0 = cosine
             }
 
-            let outerCos = Math.cos(this._outerConeAngle * angleShrinkFactor * Math.PI / 180);
+            let outerCos = Math.cos(this._outerConeAngle * angleShrinkFactor * math.DEG_TO_RAD);
             if (outerCos > cosThreshold) {
                 outerCos = 1.0 - outerCos;
                 flags |= 2; // Use bit 1 for outer angle: 1 = versine, 0 = cosine

src/scene/renderer/forward-renderer.js

@@ -1,5 +1,6 @@
 import { now } from '../../core/time.js';
 import { Debug } from '../../core/debug.js';
+import { math } from '../../core/math/math.js';
 import { Vec3 } from '../../core/math/vec3.js';
 import { Color } from '../../core/math/color.js';
 import { DebugGraphics } from '../../platform/graphics/debug-graphics.js';
@@ -425,7 +426,7 @@ class ForwardRenderer extends Renderer {
             this.lightShadowIntensity[cnt].setValue(spot.shadowIntensity);
 
             const pixelsPerMeter = spot.penumbraSize / lightRenderData.shadowCamera.renderTarget.width;
-            const fov = lightRenderData.shadowCamera._fov * Math.PI / 180.0;
+            const fov = lightRenderData.shadowCamera._fov * math.DEG_TO_RAD;
             const fovRatio = 1.0 / Math.tan(fov / 2.0);
             this.lightShadowSearchAreaId[cnt].setValue(pixelsPerMeter * fovRatio);