Refactor CurveSet constructor (#7552)

Author: willeastcott

src/core/math/curve-set.js

@@ -19,9 +19,14 @@ class CurveSet {
     /**
      * Creates a new CurveSet instance.
      *
-     * @param {Array<number[]>} curveKeys - An array of arrays of keys (pairs of numbers with the
-     * time first and value second).
+     * @param {...*} args - Variable arguments with several possible formats:
+     * - No arguments: Creates a CurveSet with a single default curve.
+     * - Single number argument: Creates a CurveSet with the specified number of default curves.
+     * - Single array argument: An array of arrays, where each sub-array contains keys (pairs of
+     * numbers with the time first and value second).
+     * - Multiple arguments: Each argument becomes a separate curve.
      * @example
+     * // Create from an array of arrays of keys
      * const curveSet = new pc.CurveSet([
      *     [
      *         0, 0,        // At 0 time, value of 0
@@ -37,24 +42,27 @@ class CurveSet {
      *     ]
      * ]);
      */
-    constructor() {
-        if (arguments.length > 1) {
-            for (let i = 0; i < arguments.length; i++) {
-                this.curves.push(new Curve(arguments[i]));
+    constructor(...args) {
+        if (args.length > 1) {
+            // Multiple arguments: each becomes a curve
+            for (let i = 0; i < args.length; i++) {
+                this.curves.push(new Curve(args[i]));
             }
+        } else if (args.length === 0) {
+            // No arguments: create a single default curve
+            this.curves.push(new Curve());
         } else {
-            if (arguments.length === 0) {
-                this.curves.push(new Curve());
+            // Single argument
+            const arg = args[0];
+            if (typeof arg === 'number') {
+                // Number: create specified number of default curves
+                for (let i = 0; i < arg; i++) {
+                    this.curves.push(new Curve());
+                }
             } else {
-                const arg = arguments[0];
-                if (typeof arg === 'number') {
-                    for (let i = 0; i < arg; i++) {
-                        this.curves.push(new Curve());
-                    }
-                } else {
-                    for (let i = 0; i < arg.length; i++) {
-                        this.curves.push(new Curve(arg[i]));
-                    }
+                // Array: each element becomes a curve
+                for (let i = 0; i < arg.length; i++) {
+                    this.curves.push(new Curve(arg[i]));
                 }
             }
         }