Skip to content

Commit efcc046

Browse files
authored
[FIX] 2 more TypeDoc warnings (#7559)
* [FIX] 2 more TypeDoc warnings * Remove category tag
1 parent 701da44 commit efcc046

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

src/scene/materials/standard-material.js

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -522,16 +522,6 @@ const _tempColor = new Color();
522522
* backfaces.
523523
* @property {boolean} shadowCatcher When enabled, the material will output accumulated directional
524524
* shadow value in linear space as the color.
525-
* @property {UpdateShaderCallback} onUpdateShader A custom function that will be called after all
526-
* shader generator properties are collected and before shader code is generated. This function
527-
* will receive an object with shader generator settings (based on current material and scene
528-
* properties), that you can change and then return. Returned value will be used instead. This is
529-
* mostly useful when rendering the same set of objects, but with different shader variations based
530-
* on the same material. For example, you may wish to render a depth or normal pass using textures
531-
* assigned to the material, a reflection pass with simpler shaders and so on. These properties are
532-
* split into two sections, generic standard material options and lit options. Properties of the
533-
* standard material options are {@link StandardMaterialOptions} and the options for the lit options
534-
* are {@link LitShaderOptions}.
535525
*
536526
* @category Graphics
537527
*/
@@ -542,6 +532,22 @@ class StandardMaterial extends Material {
542532

543533
userAttributes = new Map();
544534

535+
/**
536+
* A custom function that will be called after all shader generator properties are collected
537+
* and before shader code is generated. This function will receive an object with shader
538+
* generator settings (based on current material and scene properties), that you can change and
539+
* then return. Returned value will be used instead. This is mostly useful when rendering the
540+
* same set of objects, but with different shader variations based on the same material. For
541+
* example, you may wish to render a depth or normal pass using textures assigned to the
542+
* material, a reflection pass with simpler shaders and so on. These properties are split into
543+
* two sections, generic standard material options and lit options. Properties of the standard
544+
* material options are {@link StandardMaterialOptions} and the options for the lit options are
545+
* {@link LitShaderOptions}.
546+
*
547+
* @type {UpdateShaderCallback|undefined}
548+
*/
549+
onUpdateShader;
550+
545551
/**
546552
* Create a new StandardMaterial instance.
547553
*

src/scene/mesh-instance.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ class MeshInstance {
233233
visible = true;
234234

235235
/**
236-
* Read this value in {@link EVENT_POSTCULL} event to determine if the object is actually going
236+
* Read this value in {@link Scene.EVENT_POSTCULL} event to determine if the object is actually going
237237
* to be rendered.
238238
*
239239
* @type {boolean}

utils/plugins/rollup-types-fixup.mjs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,6 @@ const STANDARD_MAT_PROPS = [
132132
['occludeDirect', 'number'],
133133
['occludeSpecular', 'number'],
134134
['occludeSpecularIntensity', 'number'],
135-
['onUpdateShader', 'UpdateShaderCallback'],
136135
['opacity', 'number'],
137136
['opacityDither', 'string'],
138137
['opacityShadowDither', 'string'],

0 commit comments

Comments
 (0)