fix: reset render pass merge flags each frame in FrameGraph.compile()#8516
Merged
mvaligursky merged 1 commit intomainfrom Mar 10, 2026
Merged
fix: reset render pass merge flags each frame in FrameGraph.compile()#8516mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Fixed #8514 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FrameGraph.compile()sets_skipStartand_skipEndflags onRenderPassinstances when merging consecutive passes that share a render target, but never resets them. SinceRenderPassobjects are reused across frames, stale flags from a previous frame's merge persist even when the pass composition changes (e.g. a pass is disabled between frames), causingstartRenderPassto be called while a previous pass is still open.Changes:
_skipStartand_skipEndtofalsefor each render pass at the top of the existing render-target-map loop incompile(), before the merge loop re-evaluates which passes should be merged.Fixes #8514