Skip to content

Commit 733f158

Browse files
mwgraymwgray
committed
cleaned up TODOs to populate Android Studios's TODO tab with tasks for user to configure sample
Change-Id: Id0d6e9f95b27db77d80e5f38b248d056772e4379
1 parent ed9d772 commit 733f158

File tree

13 files changed

+69
-45
lines changed

13 files changed

+69
-45
lines changed

‎BasicSamples/BeGenerous/src/main/res/values/ids.xml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
See the License for the specific language governing permissions and
1515
limitations under the License.
1616
-->
17-
1817
<resources>
19-
<!-- Replace by your app ID -->
20-
<string name="app_id">ReplaceMe</string>
18+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
19+
NOTE: You can find this file by clicking the `Get Resources` link in
20+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
21+
<string name="app_id">YOUR_APP_ID</string>
2122
</resources>

‎BasicSamples/ButtonClicker/build.gradle‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ android {
77

88
defaultConfig {
99
/*
10-
REPLACE THIS VALUE WITH YOUR APPLICATION ID
10+
TODO: Replace this value with your application's package name
11+
You can find this in Linked Apps section of your Game Service in the Google Play Console
1112
*/
1213
applicationId "com.google.example.games.replace.me"
1314

‎BasicSamples/ButtonClicker/src/main/res/values/ids.xml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,9 @@
1414
See the License for the specific language governing permissions and
1515
limitations under the License.
1616
-->
17-
1817
<resources>
19-
<string name="app_id">ReplaceMe</string>
18+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
19+
NOTE: You can find this file by clicking the `Get Resources` link in
20+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
21+
<string name="app_id">YOUR_APP_ID</string>
2022
</resources>

‎BasicSamples/CollectAllTheStars2/build.gradle‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ android {
77

88
defaultConfig {
99
/*
10-
REPLACE THIS VALUE WITH YOUR APPLICATION ID
10+
TODO: Replace this value with your application's package name
11+
You can find this in Linked Apps section of your Game Service in the Google Play Console
1112
*/
1213
applicationId "com.google.example.games.replace.me"
1314

‎BasicSamples/CollectAllTheStars2/src/main/res/values/ids.xml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,9 @@
1414
See the License for the specific language governing permissions and
1515
limitations under the License.
1616
-->
17-
1817
<resources>
19-
<!-- Replace by your app ID -->
18+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
19+
NOTE: You can find this file by clicking the `Get Resources` link in
20+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
2021
<string name="app_id">YOUR_APP_ID</string>
2122
</resources>

‎BasicSamples/SkeletonTbmp/build.gradle‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
apply plugin: 'com.android.application'
22

33
android {
4-
54
compileSdkVersion android_compile_version
65
buildToolsVersion android_version
76

87
defaultConfig {
98
/*
10-
REPLACE THIS VALUE WITH YOUR APPLICATION ID
9+
TODO: Replace this value with your application's package name
10+
You can find this in Linked Apps section of your Game Service in the Google Play Console
1111
*/
1212
applicationId "com.google.example.games.replace.me"
1313

‎BasicSamples/SkeletonTbmp/src/main/java/com/google/example/games/tbmpskeleton/SkeletonTurn.java‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@ public byte[] persist() {
4949
retVal.put("turnCounter", turnCounter);
5050

5151
} catch (JSONException e) {
52-
// TODO Auto-generated catch block
53-
e.printStackTrace();
52+
Log.e("SkeletonTurn", "There was an issue writing JSON!", e);
5453
}
5554

5655
String st = retVal.toString();
@@ -91,8 +90,7 @@ static public SkeletonTurn unpersist(byte[] byteArray) {
9190
}
9291

9392
} catch (JSONException e) {
94-
// TODO Auto-generated catch block
95-
e.printStackTrace();
93+
Log.e("SkeletonTurn", "There was an issue parsing JSON!", e);
9694
}
9795

9896
return retVal;

‎BasicSamples/SkeletonTbmp/src/main/res/values/ids.xml‎

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,22 @@
1+
<?xml version="1.0" encoding="utf-8"?>
2+
<!--
3+
Copyright (C) 2013 Google Inc.
4+
5+
Licensed under the Apache License, Version 2.0 (the "License");
6+
you may not use this file except in compliance with the License.
7+
You may obtain a copy of the License at
8+
9+
http://www.apache.org/licenses/LICENSE-2.0
10+
11+
Unless required by applicable law or agreed to in writing, software
12+
distributed under the License is distributed on an "AS IS" BASIS,
13+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14+
See the License for the specific language governing permissions and
15+
limitations under the License.
16+
-->
117
<resources>
2-
<!-- Insert your app id from the Developer Consoles -->
3-
<string name="app_id">ReplaceMe</string>
18+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
19+
NOTE: You can find this file by clicking the `Get Resources` link in
20+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
21+
<string name="app_id">YOUR_APP_ID</string>
422
</resources>

‎BasicSamples/TrivialQuest/src/main/res/values/ids.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,11 @@
1414
See the License for the specific language governing permissions and
1515
limitations under the License.
1616
-->
17-
1817
<resources>
19-
<!-- Replace by your app ID -->
20-
<string name="app_id">ReplaceMe</string>
18+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
19+
NOTE: You can find this file by clicking the `Get Resources` link in
20+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
21+
<string name="app_id">YOUR_APP_ID</string>
2122

22-
<!-- Replace by your "Trivial Victory" achievement ID -->
23-
<string name="achievement_trivial_victory">ReplaceMe</string>
23+
<string name="achievement_trivial_victory">YOUR_ACHIEVEMENT_TRIVIAL_VICTORY</string>
2424
</resources>

‎BasicSamples/TrivialQuest2/src/main/res/values/ids.xml‎

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@
1717

1818
<!-- Copy the resources from the Play Games Console by clicking "Get resources"
1919
on the Events tab into this file -->
20-
21-
2220
<resources>
23-
<string name="app_id">ReplaceMe</string>
21+
<!-- TODO: Replace this entire file with the ids.xml provided from the Google Play Console.
22+
NOTE: You can find this file by clicking the `Get Resources` link in
23+
the Events, Achievements, or Leaderboards menu of the Google Play Console. -->
24+
<string name="app_id">YOUR_APP_ID</string>
2425

25-
<string name="event_red">ReplaceMe</string>
26-
<string name="event_green">ReplaceMe</string>
27-
<string name="event_blue">ReplaceMe</string>
28-
<string name="event_yellow">ReplaceMe</string>
26+
<string name="event_red">YOUR_EVENT_RED</string>
27+
<string name="event_green">YOUR_EVENT_GREEN</string>
28+
<string name="event_blue">YOUR_EVENT_BLUE</string>
29+
<string name="event_yellow">YOUR_EVENT_YELLOW</string>
2930
</resources>

0 commit comments

Comments
 (0)