fix: send string instead

Author: momintlh

Assets/PlayroomKit/PlayroomKit.cs

@@ -355,6 +355,12 @@ public void OpenDiscordInviteDialog(Action callback = null)
             _playroomService.OpenDiscordInviteDialog(callback);
         }
 
+        public void OpenDiscordExternalLink(string url, Action<string> callback = null)
+        {
+            CheckPlayRoomInitialized();
+            _playroomService.OpenDiscordExternalLink(url, callback);
+        }
+
         public void StartDiscordPurchase(string skuId, Action<string> responseCallback, Action<string> onError = null)
         {
             CheckPlayRoomInitialized();

Assets/PlayroomKit/modules/Interfaces/IPlayroomBase.cs

@@ -73,7 +73,7 @@ public void InsertCoin(InitOptions options = null, Action onLaunchCallBack = nul
 
             #region Discord
             public void OpenDiscordInviteDialog(Action callback = null);
-            public void OpenDiscordExternalLink(string url, Action<bool> callback = null);
+            public void OpenDiscordExternalLink(string url, Action<string> callback = null);
             public void StartDiscordPurchase(string skuId, Action<string> callback, Action<string> onError = null);
             public void GetDiscordSkus(Action<List<DiscordSku>> callback);
             public void GetDiscordEntitlements(Action<List<DiscordEntitlement>> callback);

Assets/PlayroomKit/modules/MockMode/BrowserMode/BrowserMockService.cs

@@ -349,10 +349,10 @@ public void SubscribeDiscordEvent(SDKEvent eventName, Action<string> callback)
             DebugLogger.LogWarning("[MockMode] Discord events only work inside discord!");
         }
 
-        public void OpenDiscordExternalLink(string url, Action<bool> callback = null)
+        public void OpenDiscordExternalLink(string url, Action<string> callback = null)
         {
             DebugLogger.LogWarning("[MockMode] Discord external link is currently not supported in browser mock mode!");
-            callback?.Invoke(true);
+            callback?.Invoke("true");
         }
         #endregion
     }

Assets/PlayroomKit/modules/MockMode/LocalPlayroomService.cs

@@ -249,10 +249,10 @@ public void SubscribeDiscordEvent(SDKEvent eventName, Action<string> callback)
             DebugLogger.LogWarning("[MockMode] Discord events only work inside discord!");
         }
 
-        public void OpenDiscordExternalLink(string url, Action<bool> callback = null)
+        public void OpenDiscordExternalLink(string url, Action<string> callback = null)
         {
             DebugLogger.LogWarning("[MockMode] Discord external link is currently not supported in local mode!");
-            callback?.Invoke(true);
+            callback?.Invoke("true");
         }
         #endregion
     }

Assets/PlayroomKit/modules/PlayroomBuildService.cs

@@ -440,7 +440,7 @@ public void OpenDiscordInviteDialog(Action callback = null)
                 _interop.OpenDiscordInviteDialogInternalWrapper(OpenDiscordInviteDialogCallbackInvoker);
             }
 
-            public void OpenDiscordExternalLink(string url, Action<bool> callback = null)
+            public void OpenDiscordExternalLink(string url, Action<string> callback = null)
             {
                 CheckPlayRoomInitialized();
                 CallbackManager.RegisterCallback(callback, "discordExternalLink");
@@ -450,8 +450,7 @@ public void OpenDiscordExternalLink(string url, Action<bool> callback = null)
             [MonoPInvokeCallback(typeof(Action<string>))]
             private static void InvokeOpenDiscordExternalLinkCallback(string openedString)
             {
-                bool opened = bool.TryParse(openedString, out bool result) && result;
-                CallbackManager.InvokeCallback("discordExternalLink", opened);
+                CallbackManager.InvokeCallback("discordExternalLink", openedString);
             }
 
             [MonoPInvokeCallback(typeof(Action<string, string>))]

Assets/PlayroomKit/src/index.js

@@ -1122,11 +1122,13 @@ mergeInto(LibraryManager.library, {
       return;
     }
 
-   Playroom.getDiscordClient().commands.openExternalLink(UTF8ToString(url))
+   Playroom.getDiscordClient().commands.openExternalLink({url: UTF8ToString(url)})
       .then((opened) => {
-        var returnData = _ConvertString(opened.toString());
-        console.log("Discord external link opened successfully: " + opened);
+        if (opened == null) {
+            opened = "" 
+        }
 
+        var returnData = _ConvertString(JSON.stringify(opened));
         {{{ makeDynCall('vi', 'callback') }}}(returnData)
       })
       .catch((error) => {

Assets/Scripts/GameManager.cs

@@ -207,10 +207,19 @@ private void Update()
 
         if (Input.GetKeyDown(KeyCode.Z))
         {
-            string nullString = null;
-            int length = nullString.Length; // This will throw a NullReferenceException
+            playroomKit.OpenDiscordExternalLink("https://github.com/momintlh", (success) =>
+            {
+                text.text = success;
+            });
         }
 
+        if (Input.GetKeyDown(KeyCode.I))
+        {
+            playroomKit.OpenDiscordExternalLink("https://discord.gg/9s5jfcgQ6P", (success) =>
+            {
+                text.text = success;
+            });
+        }
 
     }
     #endregion