chore: use golangci-lint and gofumpt (#408)

Author: canstand

.github/workflows/build.yml

@@ -9,11 +9,12 @@ jobs:
     name: Lint
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Go 1.x
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: ^1.19.9
+        cache: false
       id: go
     - name: golangci-lint
       uses: golangci/golangci-lint-action@v3
@@ -28,16 +29,16 @@ jobs:
     runs-on: ${{ matrix.os }}
     name:  ${{ matrix.browser }} on ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
       with:
         submodules: true
     - name: Set up Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: ^1.19.9
       id: go
     - name: Cache drivers
-      uses: actions/cache@v3
+      uses: actions/cache@v4
       with:
         # In order:
         # * Driver for linux
@@ -78,9 +79,9 @@ jobs:
     needs: test
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Go
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: ^1.19.9
       id: go
@@ -95,9 +96,9 @@ jobs:
   test-examples:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Set up Go 1.x
-      uses: actions/setup-go@v4
+      uses: actions/setup-go@v5
       with:
         go-version: ^1.19.9
       id: go

.github/workflows/docs.yml

@@ -7,7 +7,7 @@ jobs:
     name: Deploy docs
     runs-on: ubuntu-20.04
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: ruby/setup-ruby@v1
       with:
         ruby-version: 2.7 

.github/workflows/verify_type_generation.yml

@@ -8,13 +8,15 @@ jobs:
   verify:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           submodules: true
       - name: Set up Go
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: ^1.19.9
+      - name: Install gofumpt
+        run: go install mvdan.cc/gofumpt@latest
       - name: Install Browsers
         run: |
           go install ./...

.golangci.yaml

@@ -0,0 +1,6 @@
+---
+linters:
+  enable-all: false
+  disable-all: false
+  enable:
+    - gofumpt

CONTRIBUTING.md

@@ -1,5 +1,8 @@
 # Contributing
 
+## Code style
+The Go code is linted with [golangci-lint](https://golangci-lint.run/) and formatted with [gofumpt](https://github.com/mvdan/gofumpt). Please configure your editor to run the tools while developing and make sure to run the tools before committing any code.
+
 ## Tests
 
 ### Test coverage

browser.go

@@ -179,11 +179,11 @@ func (b *browserImpl) StopTracing() ([]byte, error) {
 		return binary, err
 	}
 	if b.chromiumTracingPath != nil {
-		err := os.MkdirAll(filepath.Dir(*b.chromiumTracingPath), 0777)
+		err := os.MkdirAll(filepath.Dir(*b.chromiumTracingPath), 0o777)
 		if err != nil {
 			return binary, err
 		}
-		err = os.WriteFile(*b.chromiumTracingPath, binary, 0644)
+		err = os.WriteFile(*b.chromiumTracingPath, binary, 0o644)
 		if err != nil {
 			return binary, err
 		}

browser_context.go

@@ -66,6 +66,7 @@ func (b *browserContextImpl) Pages() []Page {
 func (b *browserContextImpl) Browser() Browser {
 	return b.browser
 }
+
 func (b *browserContextImpl) Tracing() Tracing {
 	return b.tracing
 }

browser_type.go

@@ -87,6 +87,7 @@ func (b *browserTypeImpl) LaunchPersistentContext(userDataDir string, options ..
 	b.didCreateContext(context, option, tracesDir)
 	return context, nil
 }
+
 func (b *browserTypeImpl) Connect(wsEndpoint string, options ...BrowserTypeConnectOptions) (Browser, error) {
 	overrides := map[string]interface{}{
 		"wsEndpoint": wsEndpoint,

element_handle.go

@@ -268,7 +268,7 @@ func (e *elementHandleImpl) Screenshot(options ...ElementHandleScreenshotOptions
 		return nil, fmt.Errorf("could not decode base64 :%w", err)
 	}
 	if path != nil {
-		if err := os.WriteFile(*path, image, 0644); err != nil {
+		if err := os.WriteFile(*path, image, 0o644); err != nil {
 			return nil, err
 		}
 	}

examples/javascript/main.go

@@ -45,5 +45,4 @@ func main() {
 	if err := pw.Stop(); err != nil {
 		log.Fatalf("could not stop Playwright: %v\n", err)
 	}
-
 }