Skip to content

Commit 4e8d389

Browse files
authored
feat: hide process window under Windows
1 parent 781b80d commit 4e8d389

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

run.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ func (d *PlaywrightDriver) isUpToDateDriver() (bool, error) {
7070
return false, nil
7171
}
7272
cmd := exec.Command(d.DriverBinaryLocation, "--version")
73+
cmd.SysProcAttr = defaultSysProcAttr
7374
output, err := cmd.Output()
7475
if err != nil {
7576
return false, fmt.Errorf("could not run driver: %w", err)
@@ -193,6 +194,7 @@ func (d *PlaywrightDriver) DownloadDriver() error {
193194

194195
func (d *PlaywrightDriver) run() (*connection, error) {
195196
cmd := exec.Command(d.DriverBinaryLocation, "run-driver")
197+
cmd.SysProcAttr = defaultSysProcAttr
196198
cmd.Stderr = os.Stderr
197199
stdin, err := cmd.StdinPipe()
198200
if err != nil {
@@ -237,13 +239,15 @@ func (d *PlaywrightDriver) installBrowsers(driverPath string) error {
237239
additionalArgs = append(additionalArgs, d.options.Browsers...)
238240
}
239241
cmd := exec.Command(driverPath, additionalArgs...)
242+
cmd.SysProcAttr = defaultSysProcAttr
240243
cmd.Stdout = os.Stdout
241244
cmd.Stderr = os.Stderr
242245
return cmd.Run()
243246
}
244247

245248
func (d *PlaywrightDriver) uninstallBrowsers(driverPath string) error {
246249
cmd := exec.Command(driverPath, "uninstall")
250+
cmd.SysProcAttr = defaultSysProcAttr
247251
cmd.Stdout = os.Stdout
248252
cmd.Stderr = os.Stderr
249253
return cmd.Run()

run_unix.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
//go:build !windows
2+
3+
package playwright
4+
5+
import "syscall"
6+
7+
var defaultSysProcAttr = &syscall.SysProcAttr{}

run_win.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
//go:build windows
2+
3+
package playwright
4+
5+
import "syscall"
6+
7+
var defaultSysProcAttr = &syscall.SysProcAttr{HideWindow: true}

0 commit comments

Comments
 (0)