Skip to content

Commit 664e25d

Browse files
authored
fix: correct download url for beta driver and roll to v1.41.2 (#422)
close #421
1 parent a6f1d21 commit 664e25d

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,17 @@ jobs:
5858
- name: Test
5959
env:
6060
BROWSER: ${{ matrix.browser }}
61+
GOEXPERIMENT: nocoverageredesign
6162
if: matrix.os == 'ubuntu-latest'
6263
run: xvfb-run go test -v -covermode atomic -coverprofile=covprofile -coverpkg="github.com/playwright-community/playwright-go" --race ./...
6364
- name: Test
6465
env:
6566
BROWSER: ${{ matrix.browser }}
67+
GOEXPERIMENT: nocoverageredesign
6668
if: matrix.os != 'ubuntu-latest'
6769
run: go test -v -covermode atomic -coverprofile=covprofile -coverpkg="github.com/playwright-community/playwright-go" --race ./...
6870
- name: Install goveralls
69-
env:
70-
GO111MODULE: off
71-
run: go get github.com/mattn/goveralls
71+
run: go install github.com/mattn/goveralls@latest
7272
- name: Send coverage
7373
env:
7474
COVERALLS_TOKEN: ${{ secrets.GITHUB_TOKEN }}
@@ -86,9 +86,7 @@ jobs:
8686
go-version: ^1.19.9
8787
id: go
8888
- name: Install goveralls
89-
env:
90-
GO111MODULE: off
91-
run: go get github.com/mattn/goveralls
89+
run: go install github.com/mattn/goveralls@latest
9290
- name: Finish
9391
run: goveralls -service=github -parallel-finish
9492
env:

run.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import (
1818
)
1919

2020
const (
21-
playwrightCliVersion = "1.41.1"
21+
playwrightCliVersion = "1.41.2"
2222
)
2323

2424
var playwrightCDNMirrors = []string{
@@ -298,7 +298,7 @@ func (d *PlaywrightDriver) getDriverURLs() []string {
298298
baseURLs := []string{}
299299
pattern := "%s/builds/driver/playwright-%s-%s.zip"
300300
if !d.isReleaseVersion() {
301-
pattern = "%s/next/builds/driver/playwright-%s-%s.zip"
301+
pattern = "%s/builds/driver/next/playwright-%s-%s.zip"
302302
}
303303

304304
if hostEnv := os.Getenv("PLAYWRIGHT_DOWNLOAD_HOST"); hostEnv != "" {
@@ -314,7 +314,7 @@ func (d *PlaywrightDriver) getDriverURLs() []string {
314314
// isReleaseVersion checks if the version is not a beta or alpha release
315315
// this helps to determine the url from where to download the driver
316316
func (d *PlaywrightDriver) isReleaseVersion() bool {
317-
return !strings.Contains(d.Version, "beta") && !strings.Contains(d.Version, "alpha")
317+
return !strings.Contains(d.Version, "beta") && !strings.Contains(d.Version, "alpha") && !strings.Contains(d.Version, "next")
318318
}
319319

320320
func makeFileExecutable(path string) error {

0 commit comments

Comments
 (0)