chore: roll to Playwright v1.43.0 (#449)

Author: canstand

README.md

@@ -5,17 +5,17 @@
 [![PkgGoDev](https://pkg.go.dev/badge/github.com/playwright-community/playwright-go)](https://pkg.go.dev/github.com/playwright-community/playwright-go)
 [![License](https://img.shields.io/badge/License-MIT-blue.svg)](http://opensource.org/licenses/MIT)
 [![Go Report Card](https://goreportcard.com/badge/github.com/playwright-community/playwright-go)](https://goreportcard.com/report/github.com/playwright-community/playwright-go) ![Build Status](https://github.com/playwright-community/playwright-go/workflows/Go/badge.svg)
-[![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) [![Coverage Status](https://coveralls.io/repos/github/playwright-community/playwright-go/badge.svg?branch=main)](https://coveralls.io/github/playwright-community/playwright-go?branch=main) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-123.0.6312.4-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-123.0-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-17.4-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop -->
+[![Join Slack](https://img.shields.io/badge/join-slack-infomational)](https://aka.ms/playwright-slack) [![Coverage Status](https://coveralls.io/repos/github/playwright-community/playwright-go/badge.svg?branch=main)](https://coveralls.io/github/playwright-community/playwright-go?branch=main) <!-- GEN:chromium-version-badge -->[![Chromium version](https://img.shields.io/badge/chromium-124.0.6367.29-blue.svg?logo=google-chrome)](https://www.chromium.org/Home)<!-- GEN:stop --> <!-- GEN:firefox-version-badge -->[![Firefox version](https://img.shields.io/badge/firefox-124.0-blue.svg?logo=mozilla-firefox)](https://www.mozilla.org/en-US/firefox/new/)<!-- GEN:stop --> <!-- GEN:webkit-version-badge -->[![WebKit version](https://img.shields.io/badge/webkit-17.4-blue.svg?logo=safari)](https://webkit.org/)<!-- GEN:stop -->
 
 [API reference](https://playwright.dev/docs/api/class-playwright) | [Example recipes](https://github.com/playwright-community/playwright-go/tree/main/examples)
 
 Playwright is a Go library to automate [Chromium](https://www.chromium.org/Home), [Firefox](https://www.mozilla.org/en-US/firefox/new/) and [WebKit](https://webkit.org/) with a single API. Playwright is built to enable cross-browser web automation that is **ever-green**, **capable**, **reliable** and **fast**.
 
 |          | Linux | macOS | Windows |
 |   :---   | :---: | :---: | :---:   |
-| Chromium <!-- GEN:chromium-version -->123.0.6312.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Chromium <!-- GEN:chromium-version -->124.0.6367.29<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 | WebKit <!-- GEN:webkit-version -->17.4<!-- GEN:stop --> | ✅ | ✅ | ✅ |
-| Firefox <!-- GEN:firefox-version -->123.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
+| Firefox <!-- GEN:firefox-version -->124.0<!-- GEN:stop --> | ✅ | ✅ | ✅ |
 
 Headless execution is supported for all the browsers on all platforms.
 

browser_context.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"fmt"
 	"os"
+	"regexp"
 	"strings"
 	"sync"
 
@@ -43,10 +44,7 @@ func (b *browserContextImpl) setDefaultNavigationTimeoutImpl(timeout *float64) {
 }
 
 func (b *browserContextImpl) SetDefaultTimeout(timeout float64) {
-	b.timeoutSettings.SetDefaultTimeout(&timeout)
-	b.channel.SendNoReply("setDefaultTimeoutNoReply", map[string]interface{}{
-		"timeout": timeout,
-	})
+	b.setDefaultTimeoutImpl(&timeout)
 }
 
 func (b *browserContextImpl) setDefaultTimeoutImpl(timeout *float64) {
@@ -125,8 +123,53 @@ func (b *browserContextImpl) AddCookies(cookies []OptionalCookie) error {
 	return err
 }
 
-func (b *browserContextImpl) ClearCookies() error {
-	_, err := b.channel.Send("clearCookies")
+func (b *browserContextImpl) ClearCookies(options ...BrowserContextClearCookiesOptions) error {
+	params := map[string]interface{}{}
+	if len(options) == 1 {
+		if options[0].Domain != nil {
+			switch t := options[0].Domain.(type) {
+			case string:
+				params["domain"] = t
+			case *string:
+				params["domain"] = t
+			case *regexp.Regexp:
+				pattern, flag := convertRegexp(t)
+				params["domainRegexSource"] = pattern
+				params["domainRegexFlags"] = flag
+			default:
+				return errors.New("invalid type for domain, expected string or *regexp.Regexp")
+			}
+		}
+		if options[0].Name != nil {
+			switch t := options[0].Name.(type) {
+			case string:
+				params["name"] = t
+			case *string:
+				params["name"] = t
+			case *regexp.Regexp:
+				pattern, flag := convertRegexp(t)
+				params["nameRegexSource"] = pattern
+				params["nameRegexFlags"] = flag
+			default:
+				return errors.New("invalid type for name, expected string or *regexp.Regexp")
+			}
+		}
+		if options[0].Path != nil {
+			switch t := options[0].Path.(type) {
+			case string:
+				params["path"] = t
+			case *string:
+				params["path"] = t
+			case *regexp.Regexp:
+				pattern, flag := convertRegexp(t)
+				params["pathRegexSource"] = pattern
+				params["pathRegexFlags"] = flag
+			default:
+				return errors.New("invalid type for path, expected string or *regexp.Regexp")
+			}
+		}
+	}
+	_, err := b.channel.Send("clearCookies", params)
 	return err
 }
 

cmd/playwright/main.go

@@ -3,7 +3,6 @@ package main
 import (
 	"log"
 	"os"
-	"os/exec"
 
 	"github.com/playwright-community/playwright-go"
 )
@@ -16,7 +15,7 @@ func main() {
 	if err = driver.DownloadDriver(); err != nil {
 		log.Fatalf("could not download driver: %v", err)
 	}
-	cmd := exec.Command(driver.DriverBinaryLocation, os.Args[1:]...)
+	cmd := driver.Command(os.Args[1:]...)
 	cmd.Stdout = os.Stdout
 	cmd.Stderr = os.Stderr
 	if err := cmd.Run(); err != nil {

frame_locator.go

@@ -120,3 +120,7 @@ func (fl *frameLocatorImpl) Locator(selectorOrLocator interface{}, options ...Fr
 func (fl *frameLocatorImpl) Nth(index int) FrameLocator {
 	return newFrameLocator(fl.frame, fl.frameSelector+" >> nth="+strconv.Itoa(index))
 }
+
+func (fl *frameLocatorImpl) Owner() Locator {
+	return newLocator(fl.frame, fl.frameSelector)
+}

generated-interfaces.go

@@ -295,8 +295,8 @@ type BrowserContext interface {
 	// Returns the browser instance of the context. If it was launched as a persistent context null gets returned.
 	Browser() Browser
 
-	// Clears context cookies.
-	ClearCookies() error
+	// Removes cookies from context. Accepts optional filter.
+	ClearCookies(options ...BrowserContextClearCookiesOptions) error
 
 	// Clears all permission overrides for the browser context.
 	ClearPermissions() error
@@ -1831,9 +1831,10 @@ type Frame interface {
 // matches a given selector.
 // **Converting Locator to FrameLocator**
 // If you have a [Locator] object pointing to an `iframe` it can be converted to [FrameLocator] using
-// [`:scope`] CSS selector:
-//
-// [`:scope`]: https://developer.mozilla.org/en-US/docs/Web/CSS/:scope
+// [Locator.ContentFrame].
+// **Converting FrameLocator to Locator**
+// If you have a [FrameLocator] object it can be converted to [Locator] pointing to the same `iframe` using
+// [FrameLocator.Owner].
 type FrameLocator interface {
 	// Returns locator to the first matching frame.
 	First() FrameLocator
@@ -1925,6 +1926,12 @@ type FrameLocator interface {
 
 	// Returns locator to the n-th matching frame. It's zero based, `nth(0)` selects the first frame.
 	Nth(index int) FrameLocator
+
+	// Returns a [Locator] object pointing to the same `iframe` as this frame locator.
+	// Useful when you have a [FrameLocator] object obtained somewhere, and later on would like to interact with the
+	// `iframe` element.
+	// For a reverse operation, use [Locator.ContentFrame].
+	Owner() Locator
 }
 
 // JSHandle represents an in-page JavaScript object. JSHandles can be created with the [Page.EvaluateHandle] method.
@@ -2243,6 +2250,12 @@ type Locator interface {
 	// Deprecated: Always prefer using [Locator]s and web assertions over [ElementHandle]s because latter are inherently racy.
 	ElementHandles() ([]ElementHandle, error)
 
+	// Returns a [FrameLocator] object pointing to the same `iframe` as this locator.
+	// Useful when you have a [Locator] object obtained somewhere, and later on would like to interact with the content
+	// inside the frame.
+	// For a reverse operation, use [FrameLocator.Owner].
+	ContentFrame() FrameLocator
+
 	// Execute JavaScript code in the page, taking the matching element as an argument.
 	//
 	// # Details
@@ -3521,17 +3534,20 @@ type Page interface {
 	// [locators]: https://playwright.dev/docs/locators
 	QuerySelectorAll(selector string) ([]ElementHandle, error)
 
-	// When testing a web page, sometimes unexpected overlays like a coookie consent dialog appear and block actions you
-	// want to automate, e.g. clicking a button. These overlays don't always show up in the same way or at the same time,
-	// making them tricky to handle in automated tests.
+	// **NOTE** This method is experimental and its behavior may change in the upcoming releases.
+	// When testing a web page, sometimes unexpected overlays like a "Sign up" dialog appear and block actions you want to
+	// automate, e.g. clicking a button. These overlays don't always show up in the same way or at the same time, making
+	// them tricky to handle in automated tests.
 	// This method lets you set up a special function, called a handler, that activates when it detects that overlay is
 	// visible. The handler's job is to remove the overlay, allowing your test to continue as if the overlay wasn't there.
 	// Things to keep in mind:
 	//  - When an overlay is shown predictably, we recommend explicitly waiting for it in your test and dismissing it as
 	//   a part of your normal test flow, instead of using [Page.AddLocatorHandler].
 	//  - Playwright checks for the overlay every time before executing or retrying an action that requires an
 	//   [actionability check], or before performing an auto-waiting assertion check. When overlay
-	//   is visible, Playwright calls the handler first, and then proceeds with the action/assertion.
+	//   is visible, Playwright calls the handler first, and then proceeds with the action/assertion. Note that the
+	//   handler is only called when you perform an action/assertion - if the overlay becomes visible but you don't
+	//   perform any actions, the handler will not be triggered.
 	//  - The execution time of the handler counts towards the timeout of the action/assertion that executed the handler.
 	//   If your handler takes too long, it might cause timeouts.
 	//  - You can register multiple handlers. However, only a single handler will be running at a time. Make sure the

generated-structs.go

@@ -585,6 +585,14 @@ type Script struct {
 	// Raw script content. Optional.
 	Content *string `json:"content"`
 }
+type BrowserContextClearCookiesOptions struct {
+	// Only removes cookies with the given domain.
+	Domain interface{} `json:"domain"`
+	// Only removes cookies with the given name.
+	Name interface{} `json:"name"`
+	// Only removes cookies with the given path.
+	Path interface{} `json:"path"`
+}
 type BrowserContextCloseOptions struct {
 	// The reason to be reported to the operations interrupted by the context closure.
 	Reason *string `json:"reason"`
@@ -716,6 +724,10 @@ type BrowserTypeLaunchOptions struct {
 	ChromiumSandbox *bool `json:"chromiumSandbox"`
 	// **Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
 	// “headless” option will be set `false`.
+	//
+	// Deprecated: Use [debugging tools] instead.
+	//
+	// [debugging tools]: https://playwright.dev/docs/debug
 	Devtools *bool `json:"devtools"`
 	// If specified, accepted downloads are downloaded into this directory. Otherwise, temporary directory is created and
 	// is deleted when browser is closed. In either case, the downloads are deleted when the browser context they were
@@ -804,6 +816,10 @@ type BrowserTypeLaunchPersistentContextOptions struct {
 	DeviceScaleFactor *float64 `json:"deviceScaleFactor"`
 	// **Chromium-only** Whether to auto-open a Developer Tools panel for each tab. If this option is `true`, the
 	// “headless” option will be set `false`.
+	//
+	// Deprecated: Use [debugging tools] instead.
+	//
+	// [debugging tools]: https://playwright.dev/docs/debug
 	Devtools *bool `json:"devtools"`
 	// If specified, accepted downloads are downloaded into this directory. Otherwise, temporary directory is created and
 	// is deleted when browser is closed. In either case, the downloads are deleted when the browser context they were

js_handle.go

@@ -80,6 +80,9 @@ func (j *jsHandleImpl) AsElement() ElementHandle {
 
 func (j *jsHandleImpl) Dispose() error {
 	_, err := j.channel.Send("dispose")
+	if errors.Is(err, ErrTargetClosed) {
+		return nil
+	}
 	return err
 }
 

locator.go

@@ -190,6 +190,10 @@ func (l *locatorImpl) Click(options ...LocatorClickOptions) error {
 	return l.frame.Click(l.selector, opt)
 }
 
+func (l *locatorImpl) ContentFrame() FrameLocator {
+	return newFrameLocator(l.frame, l.selector)
+}
+
 func (l *locatorImpl) Count() (int, error) {
 	if l.err != nil {
 		return 0, l.err