Add missing Page Options

Author: smnandre

src/Page/Options/WaitForResponseOptions.php

@@ -0,0 +1,51 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the community-maintained Playwright PHP project.
+ * It is not affiliated with or endorsed by Microsoft.
+ *
+ * (c) 2025-Present - Playwright PHP - https://github.com/playwright-php
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Playwright\Page\Options;
+
+final readonly class WaitForResponseOptions
+{
+    public function __construct(
+        public ?float $timeout = null,
+    ) {
+    }
+
+    /**
+     * @return array<string, mixed>
+     */
+    public function toArray(): array
+    {
+        $options = [];
+        if (null !== $this->timeout) {
+            $options['timeout'] = $this->timeout;
+        }
+
+        return $options;
+    }
+
+    /**
+     * @param array<string, mixed>|self $options
+     */
+    public static function from(array|self $options = []): self
+    {
+        if ($options instanceof self) {
+            return $options;
+        }
+
+        /** @var float|null $timeout */
+        $timeout = $options['timeout'] ?? null;
+
+        return new self($timeout);
+    }
+}

src/Page/Page.php

@@ -56,6 +56,7 @@
 use Playwright\Page\Options\TypeOptions;
 use Playwright\Page\Options\WaitForLoadStateOptions;
 use Playwright\Page\Options\WaitForPopupOptions;
+use Playwright\Page\Options\WaitForResponseOptions;
 use Playwright\Page\Options\WaitForSelectorOptions;
 use Playwright\Page\Options\WaitForUrlOptions;
 use Playwright\Screenshot\ScreenshotHelper;
@@ -763,15 +764,19 @@ public function waitForURL($url, array|WaitForUrlOptions $options = []): self
     }
 
     /**
-     * @param string|callable      $url
-     * @param array<string, mixed> $options
+     * @param string|callable                             $url
+     * @param array<string, mixed>|WaitForResponseOptions $options
      */
-    public function waitForResponse($url, array $options = []): ResponseInterface
+    public function waitForResponse($url, array|WaitForResponseOptions $options = []): ResponseInterface
     {
-        $action = $options['action'] ?? null;
-        unset($options['action']);
+        $action = null;
+        if (is_array($options)) {
+            $action = $options['action'] ?? null;
+            unset($options['action']);
+        }
 
-        $response = $this->sendCommand('waitForResponse', ['url' => $url, 'options' => $options, 'jsAction' => $action]);
+        $options = WaitForResponseOptions::from($options);
+        $response = $this->sendCommand('waitForResponse', ['url' => $url, 'options' => $options->toArray(), 'jsAction' => $action]);
 
         return $this->createResponse($this->pageId, $response['response']);
     }

src/Page/PageInterface.php

@@ -36,6 +36,7 @@
 use Playwright\Page\Options\TypeOptions;
 use Playwright\Page\Options\WaitForLoadStateOptions;
 use Playwright\Page\Options\WaitForPopupOptions;
+use Playwright\Page\Options\WaitForResponseOptions;
 use Playwright\Page\Options\WaitForSelectorOptions;
 use Playwright\Page\Options\WaitForUrlOptions;
 
@@ -220,6 +221,12 @@ public function waitForEvents(): void;
      */
     public function waitForPopup(callable $action, array|WaitForPopupOptions $options = []): self;
 
+    /**
+     * @param string|callable                             $url
+     * @param array<string, mixed>|WaitForResponseOptions $options
+     */
+    public function waitForResponse($url, array|WaitForResponseOptions $options = []): ResponseInterface;
+
     /**
      * Set files to an input element with type="file".
      *

tests/Unit/Page/Options/WaitForResponseOptionsTest.php

@@ -0,0 +1,46 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the community-maintained Playwright PHP project.
+ * It is not affiliated with or endorsed by Microsoft.
+ *
+ * (c) 2025-Present - Playwright PHP - https://github.com/playwright-php
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Playwright\Tests\Unit\Page\Options;
+
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\TestCase;
+use Playwright\Page\Options\WaitForResponseOptions;
+
+#[CoversClass(WaitForResponseOptions::class)]
+final class WaitForResponseOptionsTest extends TestCase
+{
+    public function testCanBeCreatedFromConstructor(): void
+    {
+        $options = new WaitForResponseOptions(timeout: 1000.0);
+
+        $this->assertSame(1000.0, $options->timeout);
+        $this->assertEquals(['timeout' => 1000.0], $options->toArray());
+    }
+
+    public function testCanBeCreatedFromArray(): void
+    {
+        $options = WaitForResponseOptions::from(['timeout' => 1000.0]);
+
+        $this->assertSame(1000.0, $options->timeout);
+    }
+
+    public function testCanBeCreatedFromSelf(): void
+    {
+        $original = new WaitForResponseOptions(timeout: 1000.0);
+        $options = WaitForResponseOptions::from($original);
+
+        $this->assertSame($original, $options);
+    }
+}