Fix tests

Author: smnandre

tests/Unit/Locator/Options/GetByRoleOptionsTest.php

@@ -74,4 +74,31 @@ public function testCanBeInstantiatedDirectly(): void
         $this->assertTrue($result['pressed']);
         $this->assertSame('disabled', $result['hasNotText']);
     }
+
+    public function testFromReturnsSameInstance(): void
+    {
+        $options = new GetByRoleOptions(checked: true);
+        $this->assertSame($options, GetByRoleOptions::from($options));
+    }
+
+    public function testFromArrayRejectsInvalidName(): void
+    {
+        $this->expectExceptionMessage('getByRole option "name" must be stringable.');
+        GetByRoleOptions::from(['name' => []]);
+    }
+
+    public function testFromArrayHandlesNullValues(): void
+    {
+        $options = GetByRoleOptions::from([
+            'checked' => null,
+            'level' => null,
+            'name' => null,
+        ]);
+
+        $result = $options->toArray();
+
+        $this->assertArrayNotHasKey('checked', $result);
+        $this->assertArrayNotHasKey('level', $result);
+        $this->assertArrayNotHasKey('name', $result);
+    }
 }

tests/Unit/Locator/Options/LocatorOptionsTest.php

@@ -47,4 +47,48 @@ public function testFromArrayRejectsInvalidStrictFlag(): void
 
         LocatorOptions::from(['strict' => 'yes']);
     }
+
+    public function testFromReturnsSameInstance(): void
+    {
+        $options = new LocatorOptions(strict: true);
+        $this->assertSame($options, LocatorOptions::from($options));
+    }
+
+    public function testFromArrayRejectsInvalidLocator(): void
+    {
+        $this->expectExceptionMessage('Locator option "has" must be a Locator instance or null.');
+        LocatorOptions::from(['has' => 'invalid']);
+    }
+
+    public function testFromArrayRejectsInvalidString(): void
+    {
+        $this->expectExceptionMessage('Locator option "hasText" must be stringable.');
+        LocatorOptions::from(['hasText' => []]);
+    }
+
+    public function testFromArrayHandlesNullValues(): void
+    {
+        $options = LocatorOptions::from([
+            'has' => null,
+            'hasText' => null,
+        ]);
+
+        $result = $options->toArray();
+
+        $this->assertArrayNotHasKey('has', $result);
+        $this->assertArrayNotHasKey('hasText', $result);
+    }
+
+    public function testFromArrayIgnoresNonStringKeys(): void
+    {
+        $options = LocatorOptions::from([
+            'valid' => 'value',
+            0 => 'ignored',
+        ]);
+
+        $result = $options->toArray();
+
+        $this->assertArrayHasKey('valid', $result);
+        $this->assertArrayNotHasKey(0, $result);
+    }
 }

tests/Unit/Page/PageEventHandlerTest.php

@@ -129,4 +129,42 @@ public function testOnResponseRegistersResponseHandler(): void
         $this->assertTrue($wasCalled);
         $this->assertSame($response, $receivedResponse);
     }
+
+    public function testOnRequestFailedRegistersRequestFailedHandler(): void
+    {
+        $handler = new PageEventHandler();
+        $wasCalled = false;
+        $receivedRequest = null;
+
+        $request = new Request(['url' => 'https://example.com', 'method' => 'GET', 'headers' => [], 'resourceType' => 'document', 'failure' => 'net::ERR_FAILED']);
+
+        $handler->onRequestFailed(function (Request $r) use (&$wasCalled, &$receivedRequest) {
+            $wasCalled = true;
+            $receivedRequest = $r;
+        });
+
+        $handler->publicEmit('requestfailed', [$request]);
+
+        $this->assertTrue($wasCalled);
+        $this->assertSame($request, $receivedRequest);
+    }
+
+    public function testOnRouteRegistersRouteHandler(): void
+    {
+        $handler = new PageEventHandler();
+        $wasCalled = false;
+        $receivedRoute = null;
+
+        $route = new \Playwright\Network\Route($this->transport, 'route1', ['url' => 'https://example.com']);
+
+        $handler->onRoute(function ($r) use (&$wasCalled, &$receivedRoute) {
+            $wasCalled = true;
+            $receivedRoute = $r;
+        });
+
+        $handler->publicEmit('route', [$route]);
+
+        $this->assertTrue($wasCalled);
+        $this->assertSame($route, $receivedRoute);
+    }
 }