-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Description
Original Review Suggestion
Using
writeFileSync(andreadFileSync) blocks the event loop. Since these are called withinasyncmethods, it is recommended to use the asynchronousnode:fs/promisesAPI to avoid blocking the application, especially as the vector index grows.
Reviewer: @gemini-code-assist
PR: #92
File: packages/store/src/local/vector-store.ts (line 124)
Comment: #92 (comment)
Status
Decision: Skipped
Reason: This store is a zero-dependency dev-fallback for small JSON files where sync I/O is acceptable. Migrating to node:fs/promises would be a significant refactor with no practical benefit at current scale.
Action Items
- Migrate
readFileSync/writeFileSyncinopen()/flush()tonode:fs/promisesequivalents - Update
flush()to returnPromise<void>and make callers await it - Revisit if
LocalVectorStorestarts being used with large indexes in production paths
Reactions are currently unavailable