test(test): make edit test less likely to fail in RPC by hardcoding its resolving

Author: Rinse12

.gitignore

@@ -10,6 +10,9 @@ test-karma-webpack
 .plebbit
 .plebbit/
 
+# test-server generated files
+test/test-server/ens-test-signer.json
+
 # build folder 
 dist/
 /dist/

test/browser-e2e/accounts.test.js

@@ -8,9 +8,20 @@ import subplebbitsStore from '../../dist/stores/subplebbits'
 import testUtils from '../../dist/lib/test-utils'
 import {offlineIpfs, pubsubIpfs, plebbitRpc} from '../test-server/config'
 import signers from '../fixtures/signers'
+
 const subplebbitAddress = signers[0].address
 const adminRoleSigner = signers[1]
 
+// Load ENS test signer info from test-server via HTTP
+// This allows tests to create subplebbits with a signer that matches 'my-sub.eth'
+// The test-server has an endpoint at http://localhost:59281/ens-test-signer
+let ensTestSignerPromise
+const loadEnsTestSigner = async () => {
+  const response = await fetch('http://localhost:59281/ens-test-signer')
+  return await response.json()
+}
+ensTestSignerPromise = loadEnsTestSigner()
+
 const isBase64 = (testString) => /^([0-9a-zA-Z+/]{4})*(([0-9a-zA-Z+/]{2}==)|([0-9a-zA-Z+/]{3}))?$/gm.test(testString)
 
 // large value for manual debugging
@@ -133,7 +144,17 @@ for (const plebbitOptionsType in plebbitOptionsTypes) {
           const createdSubplebbitTitle = 'my title'
           let subplebbit
           await act(async () => {
-            subplebbit = await rendered.result.current.createSubplebbit({title: createdSubplebbitTitle})
+            // Use the ensTestSigner so that 'my-sub.eth' resolves to this subplebbit's address
+            // This is required for the ENS address validation to pass
+            const ensTestSigner = await ensTestSignerPromise
+            const createOptions = {title: createdSubplebbitTitle}
+            if (ensTestSigner) {
+              createOptions.signer = {
+                type: ensTestSigner.type,
+                privateKey: ensTestSigner.privateKey,
+              }
+            }
+            subplebbit = await rendered.result.current.createSubplebbit(createOptions)
           })
           console.log('after create subplebbit', subplebbit.address)
           const createdSubplebbitAddress = subplebbit?.address

test/test-server/index.js

@@ -6,6 +6,12 @@ import startPlebbitRpc from './start-plebbit-rpc.js'
 import signers from '../fixtures/signers.js'
 import {directory as getTmpFolderPath} from 'tempy'
 import http from 'http'
+import fs from 'fs'
+import path from 'path'
+import {fileURLToPath} from 'url'
+
+const __filename = fileURLToPath(import.meta.url)
+const __dirname = path.dirname(__filename)
 const plebbitDataPath = getTmpFolderPath()
 
 // set up a subplebbit for testing
@@ -41,6 +47,32 @@ const plebbitDataPath = getTmpFolderPath()
   })
   const signer = await plebbit.createSigner({privateKey, type: 'ed25519'})
 
+  // Create a signer for testing ENS domain address editing
+  // The 'my-sub.eth' domain should resolve to this signer's address
+  const ensTestSigner = await plebbit.createSigner()
+  const ensTestDomain = 'my-sub.eth'
+
+  // Mock the ENS text record for 'my-sub.eth' to point to ensTestSigner.address
+  // This allows the test to successfully edit a subplebbit's address to 'my-sub.eth'
+  const cacheKey = plebbit._clientsManager._getKeyOfCachedDomainTextRecord(ensTestDomain, 'subplebbit-address')
+  const timestamp = () => Math.floor(Date.now() / 1000)
+  await plebbit._storage.setItem(cacheKey, {
+    timestampSeconds: timestamp(),
+    valueOfTextRecord: ensTestSigner.address,
+  })
+  console.log(`Mocked ENS text record '${ensTestDomain}' -> '${ensTestSigner.address}'`)
+
+  // Export the ENS test signer info to a file so tests can use it
+  const ensTestSignerInfo = {
+    privateKey: ensTestSigner.privateKey,
+    address: ensTestSigner.address,
+    type: ensTestSigner.type,
+    domain: ensTestDomain,
+  }
+  const signerInfoPath = path.join(__dirname, 'ens-test-signer.json')
+  fs.writeFileSync(signerInfoPath, JSON.stringify(ensTestSignerInfo, null, 2))
+  console.log(`Exported ENS test signer info to '${signerInfoPath}'`)
+
   console.log(`creating subplebbit with address '${signer.address}'...`)
   const subplebbit = await plebbit.createSubplebbit({
     signer: signer,
@@ -82,7 +114,13 @@ const plebbitDataPath = getTmpFolderPath()
     http
       .createServer((req, res) => {
         res.setHeader('Access-Control-Allow-Origin', '*')
-        res.end('test server ready')
+        if (req.url === '/ens-test-signer') {
+          // Return the ENS test signer info for browser tests
+          res.setHeader('Content-Type', 'application/json')
+          res.end(JSON.stringify(ensTestSignerInfo))
+        } else {
+          res.end('test server ready')
+        }
       })
       .listen(59281)
   })