Skip to content

Commit 3c9c586

Browse files
committed
Refactor to namespace SoftwareSerial.�Remove example that's unmaintained for a long time.
1 parent 8ef714f commit 3c9c586

File tree

9 files changed

+174
-281
lines changed

9 files changed

+174
-281
lines changed

examples/bitpattern/bitpattern.ino

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
#endif
1919
#endif
2020

21-
SoftwareSerial swSer;
21+
SoftwareSerial::UART swSer;
2222
#ifdef ESP8266
23-
auto logSer = SoftwareSerial(-1, TX);
23+
auto logSer = SoftwareSerial::UART(-1, TX);
2424
auto hwSer = Serial;
2525
#else
2626
auto logSer = Serial;
@@ -32,14 +32,14 @@ constexpr uint32_t TESTBPS = 115200;
3232
void setup() {
3333
delay(2000);
3434
#ifdef ESP8266
35-
hwSer.begin(TESTBPS, SERIAL_8N1);
35+
hwSer.begin(TESTBPS, ::SERIAL_8N1);
3636
hwSer.swap();
3737
#else
38-
hwSer.begin(TESTBPS, SERIAL_8N1, D6, D5);
38+
hwSer.begin(TESTBPS, ::SERIAL_8N1, D6, D5);
3939
#endif
4040
logSer.begin(115200);
4141
logSer.println(PSTR("\nOne Wire Half Duplex Bitpattern and Datarate Test"));
42-
swSer.begin(TESTBPS, SWSERIAL_8N1, D6, D5);
42+
swSer.begin(TESTBPS, SoftwareSerial::SERIAL_8N1, D6, D5);
4343
swSer.enableIntTx(true);
4444
logSer.println(PSTR("Tx on swSer"));
4545
}

examples/loopback/loopback.ino

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,11 @@ constexpr int IUTBITRATE = 19200;
4747
#endif
4848

4949
#if defined(ESP8266)
50-
constexpr SoftwareSerialConfig swSerialConfig = SWSERIAL_8E1;
51-
constexpr SerialConfig hwSerialConfig = SERIAL_8E1;
50+
constexpr SoftwareSerial::Config swSerialConfig = SoftwareSerial::SERIAL_8E1;
51+
constexpr SerialConfig hwSerialConfig = ::SERIAL_8E1;
5252
#elif defined(ESP32)
53-
constexpr SoftwareSerialConfig swSerialConfig = SWSERIAL_8E1;
54-
constexpr uint32_t hwSerialConfig = SERIAL_8E1;
53+
constexpr SoftwareSerial::Config swSerialConfig = SoftwareSerial::SERIAL_8E1;
54+
constexpr uint32_t hwSerialConfig = ::SERIAL_8E1;
5555
#else
5656
constexpr unsigned swSerialConfig = 3;
5757
#endif
@@ -72,37 +72,37 @@ constexpr int ReportInterval = IUTBITRATE / 8;
7272
#if defined(ESP8266)
7373
#if defined(HWLOOPBACK) || defined(HWSOURCESWSINK)
7474
HardwareSerial& hwSerial(Serial);
75-
SoftwareSerial serialIUT;
76-
SoftwareSerial logger;
75+
SoftwareSerial::UART serialIUT;
76+
SoftwareSerial::UART logger;
7777
#elif defined(HWSOURCESINK)
7878
HardwareSerial& serialIUT(Serial);
79-
SoftwareSerial logger;
79+
SoftwareSerial::UART logger;
8080
#else
81-
SoftwareSerial serialIUT;
81+
SoftwareSerial::UART serialIUT;
8282
HardwareSerial& logger(Serial);
8383
#endif
8484
#elif defined(ESP32)
8585
#if defined(HWLOOPBACK) || defined (HWSOURCESWSINK)
8686
HardwareSerial& hwSerial(Serial2);
87-
SoftwareSerial serialIUT;
87+
SoftwareSerial::UART serialIUT;
8888
#elif defined(HWSOURCESINK)
8989
HardwareSerial& serialIUT(Serial2);
9090
#else
91-
SoftwareSerial serialIUT;
91+
SoftwareSerial::UART serialIUT;
9292
#endif
9393
HardwareSerial& logger(Serial);
9494
#else
95-
SoftwareSerial serialIUT(14, 12);
95+
SoftwareSerial::UART serialIUT(14, 12);
9696
HardwareSerial& logger(Serial);
9797
#endif
9898

9999
void setup() {
100100
#if defined(ESP8266)
101101
#if defined(HWLOOPBACK) || defined(HWSOURCESINK) || defined(HWSOURCESWSINK)
102-
Serial.begin(IUTBITRATE, hwSerialConfig, SERIAL_FULL, 1, invert);
102+
Serial.begin(IUTBITRATE, hwSerialConfig, ::SERIAL_FULL, 1, invert);
103103
Serial.swap();
104104
Serial.setRxBufferSize(2 * BLOCKSIZE);
105-
logger.begin(9600, SWSERIAL_8N1, -1, TX);
105+
logger.begin(9600, SoftwareSerial::SERIAL_8N1, -1, TX);
106106
#else
107107
logger.begin(9600);
108108
#endif

examples/onewiretest/onewiretest.ino

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@
1010
#endif
1111
#endif
1212

13-
SoftwareSerial swSer1;
14-
SoftwareSerial swSer2;
13+
SoftwareSerial::UART swSer1;
14+
SoftwareSerial::UART swSer2;
1515

1616
void setup() {
1717
delay(2000);
1818
Serial.begin(115200);
1919
Serial.println(PSTR("\nOne Wire Half Duplex Serial Tester"));
20-
swSer1.begin(115200, SWSERIAL_8N1, D6, D6, false, 256);
20+
swSer1.begin(115200, SoftwareSerial::SERIAL_8N1, D6, D6, false, 256);
2121
// high speed half duplex, turn off interrupts during tx
2222
swSer1.enableIntTx(false);
23-
swSer2.begin(115200, SWSERIAL_8N1, D5, D5, false, 256);
23+
swSer2.begin(115200, SoftwareSerial::SERIAL_8N1, D5, D5, false, 256);
2424
// high speed half duplex, turn off interrupts during tx
2525
swSer2.enableIntTx(false);
2626
}
@@ -36,7 +36,7 @@ void loop() {
3636

3737
}
3838

39-
void checkSwSerial(SoftwareSerial* ss) {
39+
void checkSwSerial(SoftwareSerial::UART* ss) {
4040
byte ch;
4141
while (!Serial.available());
4242
ss->enableTx(true);
@@ -45,7 +45,7 @@ void checkSwSerial(SoftwareSerial* ss) {
4545
ss->write(ch);
4646
}
4747
ss->enableTx(false);
48-
// wait 1 second for the reply from SOftwareSerial if any
48+
// wait 1 second for the reply from SoftwareSerial if any
4949
delay(1000);
5050
if (ss->available()) {
5151
Serial.print(PSTR("\nResult:"));

examples/onreceive/onreceive.ino

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
#define BAUD_RATE 115200
1717
#define MAX_FRAMEBITS (1 + 8 + 1 + 2)
1818

19-
SoftwareSerial testSerial;
19+
SoftwareSerial::UART testSerial;
2020

2121
// Becomes set from ISR / IRQ callback function.
2222
std::atomic<bool> rxPending(false);
@@ -30,7 +30,7 @@ void setup() {
3030
Serial.begin(115200);
3131
Serial.setDebugOutput(false);
3232
Serial.swap();
33-
testSerial.begin(BAUD_RATE, SWSERIAL_8N1, RX, TX);
33+
testSerial.begin(BAUD_RATE, SoftwareSerial::SERIAL_8N1, RX, TX);
3434
// Only half duplex this way, but reliable TX timings for high bps
3535
testSerial.enableIntTx(false);
3636
testSerial.onReceive(receiveHandler);

examples/repeater/repeater.ino

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ constexpr int IUTBITRATE = 19200;
3737
#endif
3838

3939
#if defined(ESP8266)
40-
constexpr SoftwareSerialConfig swSerialConfig = SWSERIAL_8E1;
41-
constexpr SerialConfig hwSerialConfig = SERIAL_8E1;
40+
constexpr SoftwareSerial::Config swSerialConfig = SoftwareSerial::SERIAL_8E1;
41+
constexpr SerialConfig hwSerialConfig = ::SERIAL_8E1;
4242
#elif defined(ESP32)
43-
constexpr SoftwareSerialConfig swSerialConfig = SWSERIAL_8E1;
44-
constexpr uint32_t hwSerialConfig = SERIAL_8E1;
43+
constexpr SoftwareSerial::Config swSerialConfig = SoftwareSerial::SERIAL_8E1;
44+
constexpr uint32_t hwSerialConfig = ::SERIAL_8E1;
4545
#else
4646
constexpr unsigned swSerialConfig = 3;
4747
#endif
@@ -60,30 +60,30 @@ constexpr int ReportInterval = IUTBITRATE / 8;
6060
#if defined(ESP8266)
6161
#if defined(HWLOOPBACK)
6262
HardwareSerial& repeater(Serial);
63-
SoftwareSerial logger;
63+
SoftwareSerial::UART logger;
6464
#else
65-
SoftwareSerial repeater;
65+
SoftwareSerial::UART repeater;
6666
HardwareSerial& logger(Serial);
6767
#endif
6868
#elif defined(ESP32)
6969
#if defined(HWLOOPBACK)
7070
HardwareSerial& repeater(Serial2);
7171
#else
72-
SoftwareSerial repeater;
72+
SoftwareSerial::UART repeater;
7373
#endif
7474
HardwareSerial& logger(Serial);
7575
#else
76-
SoftwareSerial repeater(14, 12);
76+
SoftwareSerial::UART repeater(14, 12);
7777
HardwareSerial& logger(Serial);
7878
#endif
7979

8080
void setup() {
8181
#if defined(ESP8266)
8282
#if defined(HWLOOPBACK)
83-
repeater.begin(IUTBITRATE, hwSerialConfig, SERIAL_FULL, 1, invert);
83+
repeater.begin(IUTBITRATE, hwSerialConfig, ::SERIAL_FULL, 1, invert);
8484
repeater.swap();
8585
repeater.setRxBufferSize(2 * BLOCKSIZE);
86-
logger.begin(9600, SWSERIAL_8N1, -1, TX);
86+
logger.begin(9600, SoftwareSerial::SERIAL_8N1, -1, TX);
8787
#else
8888
repeater.begin(IUTBITRATE, swSerialConfig, D7, D8, invert, 4 * BLOCKSIZE);
8989
#ifdef HALFDUPLEX

examples/servoTester/servoTester.ino

Lines changed: 0 additions & 113 deletions
This file was deleted.

examples/swsertest/swsertest.ino

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@
3737

3838
#ifndef SWAPSERIAL
3939
auto& usbSerial = Serial;
40-
SoftwareSerial testSerial;
40+
SoftwareSerial::UART testSerial;
4141
#else
42-
SoftwareSerial usbSerial;
42+
SoftwareSerial::UART usbSerial;
4343
auto& testSerial = Serial;
4444
#endif
4545

@@ -51,12 +51,12 @@ void setup() {
5151
// to the loopback SoftwareSerial adapter gets read before another write is performed.
5252
// Block writes with a size greater than 1 would usually fail. Do not copy this into your own project without
5353
// reading the documentation.
54-
testSerial.begin(BAUD_RATE, SWSERIAL_8N1, D7, D8, false, 95, 11);
54+
testSerial.begin(BAUD_RATE, SoftwareSerial::SERIAL_8N1, D7, D8, false, 95, 11);
5555
#else
5656
testSerial.begin(115200);
5757
testSerial.setDebugOutput(false);
5858
testSerial.swap();
59-
usbSerial.begin(BAUD_RATE, SWSERIAL_8N1, RX, TX, false, 95);
59+
usbSerial.begin(BAUD_RATE, SoftwareSerial::SERIAL_8N1, RX, TX, false, 95);
6060
#endif
6161

6262
usbSerial.println(PSTR("\nSoftware serial test started"));

0 commit comments

Comments
 (0)