Enhance user data handling and localStorage management

- Added cleanup logic for stale localStorage flags in user.js to prevent interference with user data loading.
- Improved timestamp formatting for Plex linking status in user.js, ensuring better readability.
- Updated index.html to refine redirection logic based on Plex linking state, allowing for smoother user experience.
- Modified plex_auth_routes.py to ensure proper navigation without triggering localStorage redirects during Plex authentication callback.

Author: Admin9705

frontend/static/js/user.js

@@ -35,6 +35,9 @@ class UserModule {
 
     async loadUserData() {
         try {
+            // Clean up any stale localStorage flags that might interfere
+            this.cleanupStaleFlags();
+            
             // Load user info
             const userResponse = await fetch('./api/user/info', { credentials: 'include' });
             if (!userResponse.ok) throw new Error('Failed to fetch user data');
@@ -375,6 +378,7 @@ class UserModule {
                 localStorage.setItem('huntarr-plex-pin-id', this.currentPlexPinId);
                 localStorage.setItem('huntarr-plex-linking', 'true');
                 localStorage.setItem('huntarr-plex-user-mode', 'true');
+                localStorage.setItem('huntarr-plex-linking-timestamp', Date.now().toString());
 
                 // Redirect to Plex authentication
                 setTimeout(() => {
@@ -526,6 +530,7 @@ class UserModule {
             localStorage.removeItem('huntarr-plex-linking');
             localStorage.removeItem('huntarr-plex-pin-id');
             localStorage.removeItem('huntarr-plex-user-mode');
+            localStorage.removeItem('huntarr-plex-linking-timestamp');
 
             // Show modal and start checking
             document.getElementById('plexLinkModal').style.display = 'block';
@@ -617,7 +622,20 @@ class UserModule {
 
             document.getElementById('plexUsername').textContent = plexData.plex_username || 'Unknown';
             document.getElementById('plexEmail').textContent = plexData.plex_email || 'N/A';
-            document.getElementById('plexLinkedAt').textContent = plexData.plex_linked_at || 'Unknown';
+            
+            // Format the timestamp properly
+            let linkedAtText = 'Unknown';
+            if (plexData.plex_linked_at) {
+                try {
+                    const timestamp = plexData.plex_linked_at;
+                    const date = new Date(timestamp * 1000); // Convert Unix timestamp to milliseconds
+                    linkedAtText = date.toLocaleString(); // Format as readable date/time
+                } catch (error) {
+                    console.error('Error formatting plex_linked_at timestamp:', error);
+                    linkedAtText = 'Invalid Date';
+                }
+            }
+            document.getElementById('plexLinkedAt').textContent = linkedAtText;
 
             notLinkedSection.style.display = 'none';
             linkedSection.style.display = 'block';
@@ -630,6 +648,34 @@ class UserModule {
         }
     }
 
+    cleanupStaleFlags() {
+        // Clean up any localStorage flags that might interfere with normal operation
+        const flagsToClean = [
+            'huntarr-plex-login',
+            'huntarr-plex-setup-mode'
+        ];
+        
+        flagsToClean.forEach(flag => {
+            if (localStorage.getItem(flag)) {
+                console.log(`[UserModule] Cleaning up stale localStorage flag: ${flag}`);
+                localStorage.removeItem(flag);
+            }
+        });
+        
+        // Only clean up Plex linking flags if they're older than 10 minutes (stale)
+        const plexLinkingTimestamp = localStorage.getItem('huntarr-plex-linking-timestamp');
+        if (plexLinkingTimestamp) {
+            const tenMinutesAgo = Date.now() - (10 * 60 * 1000);
+            if (parseInt(plexLinkingTimestamp) < tenMinutesAgo) {
+                console.log('[UserModule] Cleaning up stale Plex linking flags (older than 10 minutes)');
+                localStorage.removeItem('huntarr-plex-linking');
+                localStorage.removeItem('huntarr-plex-pin-id');
+                localStorage.removeItem('huntarr-plex-user-mode');
+                localStorage.removeItem('huntarr-plex-linking-timestamp');
+            }
+        }
+    }
+
     showStatus(element, message, type) {
         element.textContent = message;
         element.className = `status-message ${type}`;

frontend/templates/index.html

@@ -107,8 +107,11 @@
                 window.location.href = './login';
             } else if (plexLinking === 'true' && plexSetupMode === 'true') {
                 // Only redirect to setup page for setup mode
-                // User mode now goes directly from callback to user page
                 window.location.href = './setup';
+            } else if (plexLinking === 'true' && plexUserMode === 'true') {
+                // For user mode, stay on current page and let user.js handle it
+                // Do NOT redirect - let the UserModule.checkPlexReturn() handle the flow
+                console.log('Detected Plex user mode return - letting UserModule handle it');
             }
         });
     </script>

src/primary/auth.py

@@ -469,7 +469,7 @@ def authenticate_request():
                 logger.warning(f"Access from {remote_addr} is not recognized as local network - Authentication required")
 
     # Check for valid session
-    session_id = session.get(SESSION_COOKIE_NAME)
+    session_id = request.cookies.get(SESSION_COOKIE_NAME)
     if session_id and verify_session(session_id):
         if not is_polling_endpoint:
             pass  # Session valid - debug spam removed

src/primary/routes/plex_auth_routes.py

@@ -491,7 +491,6 @@ def plex_status():
 @plex_auth_bp.route('/auth/plex/callback')
 def plex_callback():
     """Handle Plex authentication callback (redirect back to app)"""
-    # Check localStorage to determine if this is setup mode or user mode
-    # For now, redirect directly to user page to avoid double flash
-    # TODO: Could be enhanced to check localStorage and route appropriately
-    return redirect('/user')
+    # Redirect to main page with user hash to avoid index.html redirect conflicts
+    # This ensures proper navigation without triggering localStorage redirects
+    return redirect('/#user')