Bugs Fixes

Author: Admin9705

frontend/templates/components/settings_clients_section.html

@@ -159,15 +159,17 @@ <h2 class="client-type-modal-title">Add Download Client</h2>
                         <div class="client-type-option-icon"><i class="fas fa-download"></i></div>
                         <div class="client-type-option-body">
                             <div class="client-type-option-name">SABnzbd <span class="client-type-option-tag" style="background:rgba(245,158,11,0.2);color:#f59e0b;">Beta</span></div>
-                            <div class="client-type-option-desc">External usenet client. Requires host, port, and API key. <span style="color:#f59e0b;">Support is under development and may not be fully stable.</span></div>
+                            <div class="client-type-option-warning" style="display:flex;align-items:center;gap:6px;margin-bottom:4px;font-size:0.8rem;color:#f59e0b;"><i class="fas fa-exclamation-triangle"></i> Support under development</div>
+                            <div class="client-type-option-desc">External usenet client. Requires host, port, and API key. May work but is not fully polished.</div>
                         </div>
                         <div class="client-type-option-check"><i class="fas fa-check-circle"></i></div>
                     </div>
                     <div class="client-type-option" data-client-type="nzbget" id="client-type-option-nzbget">
                         <div class="client-type-option-icon"><i class="fas fa-download"></i></div>
                         <div class="client-type-option-body">
                             <div class="client-type-option-name">NZBGet <span class="client-type-option-tag" style="background:rgba(245,158,11,0.2);color:#f59e0b;">Beta</span></div>
-                            <div class="client-type-option-desc">External usenet client. Requires host, port, and password. <span style="color:#f59e0b;">Support is under development and may not be fully stable.</span></div>
+                            <div class="client-type-option-warning" style="display:flex;align-items:center;gap:6px;margin-bottom:4px;font-size:0.8rem;color:#f59e0b;"><i class="fas fa-exclamation-triangle"></i> Support under development</div>
+                            <div class="client-type-option-desc">External usenet client. Requires host, port, and password. May work but is not fully polished.</div>
                         </div>
                         <div class="client-type-option-check"><i class="fas fa-check-circle"></i></div>
                     </div>

src/primary/apps/movie_hunt/importer.py

@@ -323,6 +323,20 @@ def _auto_probe_file(title: str, year: str, file_path: str, instance_id: int = N
         _mh_log().debug("Import probe: error for '%s' (%s): %s", title, year, e)
 
 
+def _cleanup_on_import_failure(local_path: str, root_folder: str, title: str, year: str) -> None:
+    """
+    Remove the source download folder when import fails.
+    Frees disk space so failed downloads don't accumulate.
+    """
+    if not local_path or not root_folder:
+        return
+    try:
+        _cleanup_source_folder(local_path, root_folder, title, year)
+        _mh_log().info("Import: discarded failed download for '%s' (%s) to free space", title, year)
+    except Exception as e:
+        _mh_log().warning("Import: could not discard failed download folder %s: %s", local_path, e)
+
+
 def _cleanup_source_folder(local_path: str, root_folder: str, title: str, year: str) -> None:
     """
     Remove the source download folder after successful import.
@@ -402,6 +416,7 @@ def import_movie(client: Dict[str, Any], title: str, year: str, download_path: s
         video_file = _find_largest_video_file(local_path)
         if not video_file:
             _mh_log().error("Import: no video file found in %s", local_path)
+            _cleanup_on_import_failure(local_path, root_folder, title, year)
             return False
 
         # 4. Create movie folder and filename using format settings
@@ -429,6 +444,7 @@ def import_movie(client: Dict[str, Any], title: str, year: str, download_path: s
             os.makedirs(dest_folder, exist_ok=True)
         except Exception as e:
             _mh_log().error("Import: failed to create folder %s: %s", dest_folder, e)
+            _cleanup_on_import_failure(local_path, root_folder, title, year)
             return False
 
         dest_file = os.path.join(dest_folder, file_name)
@@ -458,6 +474,7 @@ def import_movie(client: Dict[str, Any], title: str, year: str, download_path: s
                 "Import: failed to move file: %s. Reason: %s. Check permissions and that destination is writable.",
                 video_file, e
             )
+            _cleanup_on_import_failure(local_path, root_folder, title, year)
             return False
 
         # 8. Update collection status
@@ -481,4 +498,11 @@ def import_movie(client: Dict[str, Any], title: str, year: str, download_path: s
 
     except Exception as e:
         _mh_log().exception("Import: error for '%s' (%s): %s", title, year, e)
+        try:
+            local_path = locals().get('local_path')
+            root_folder = locals().get('root_folder')
+            if local_path and root_folder:
+                _cleanup_on_import_failure(local_path, root_folder, title, year)
+        except Exception:
+            pass
         return False

src/primary/apps/tv_hunt/importer.py

@@ -223,6 +223,19 @@ def _add_import_history(series_title: str, season: int, episode: int,
         logger.error("Error adding TV import history: %s", e)
 
 
+def _cleanup_on_import_failure(local_path: str, root_folder: str,
+                              series_title: str, season: int, episode: int) -> None:
+    """Remove the source download folder when import fails. Frees disk space."""
+    if not local_path or not root_folder:
+        return
+    try:
+        _cleanup_source_folder(local_path, root_folder, series_title, season, episode)
+        _tv_log().info("Import: discarded failed download for '%s' S%02dE%02d to free space",
+                       series_title, season or 0, episode or 0)
+    except Exception as e:
+        _tv_log().warning("Import: could not discard failed download folder %s: %s", local_path, e)
+
+
 def _cleanup_source_folder(local_path: str, root_folder: str,
                            series_title: str, season: int, episode: int) -> None:
     """Remove the source download folder after successful import."""
@@ -298,6 +311,7 @@ def import_episode(client: Dict[str, Any], series_title: str, year: str,
         video_file = _find_largest_video_file(local_path)
         if not video_file:
             _tv_log().error("Import: no video file found in %s", local_path)
+            _cleanup_on_import_failure(local_path, root_folder, series_title, season, episode)
             return False
 
         # 4. Generate folder and file names using format settings
@@ -335,6 +349,7 @@ def import_episode(client: Dict[str, Any], series_title: str, year: str,
             os.makedirs(dest_season_folder, exist_ok=True)
         except Exception as e:
             _tv_log().error("Import: failed to create folder %s: %s", dest_season_folder, e)
+            _cleanup_on_import_failure(local_path, root_folder, series_title, season, episode)
             return False
 
         # 5. Check if file already exists
@@ -355,6 +370,7 @@ def import_episode(client: Dict[str, Any], series_title: str, year: str,
             shutil.move(video_file, dest_file)
         except Exception as e:
             _tv_log().error("Import: failed to move file: %s -> %s. Reason: %s", video_file, dest_file, e)
+            _cleanup_on_import_failure(local_path, root_folder, series_title, season, episode)
             return False
 
         # 7. Update collection status
@@ -377,4 +393,11 @@ def import_episode(client: Dict[str, Any], series_title: str, year: str,
     except Exception as e:
         _tv_log().exception("Import: error for '%s' S%02dE%02d: %s",
                             series_title, season or 0, episode or 0, e)
+        try:
+            local_path = locals().get('local_path')
+            root_folder = locals().get('root_folder')
+            if local_path and root_folder:
+                _cleanup_on_import_failure(local_path, root_folder, series_title, season, episode)
+        except Exception:
+            pass
         return False

src/primary/routes/media_hunt/discovery_movie.py

@@ -222,9 +222,10 @@ def _add_nzb_to_download_client(client, nzb_url, nzb_name, category, verify_ssl,
             username = (client.get('username') or '').strip()
             password = (client.get('password') or '').strip()
             auth = (username, password) if (username or password) else None
+            nzb_filename = (nzb_name or '').strip() or (nzb_url.split('/')[-1].split('?')[0] if nzb_url else '') or 'download.nzb'
             payload = {
                 'method': 'append',
-                'params': [nzb_name or '', nzb_url, cat, 0, False, False, '', 0, 'SCORE', False, []],
+                'params': [nzb_filename, nzb_url, cat, 0, False, False, '', 0, 'SCORE', False, []],
                 'id': 1
             }
             r = requests.post(jsonrpc_url, json=payload, auth=auth, timeout=15, verify=verify_ssl)