Skip to content

Commit cb0edeb

Browse files
committed
updates
1 parent 6625c14 commit cb0edeb

File tree

2 files changed

+46
-3
lines changed

2 files changed

+46
-3
lines changed

.github/listen.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,29 @@ fetch('./api/endpoint');
123123
**Debugging Technique:** Use colored debug borders to confirm CSS is loading
124124
**Files:** `/frontend/static/css/responsive-fix.css`, `/frontend/static/css/new-style.css`
125125

126+
### 7. Info Icon Documentation Link Issues
127+
**Symptoms:** Info icons (i) linking to wrong domains, localhost, or broken forum links
128+
**Root Cause:** Hard-coded old links instead of GitHub documentation links
129+
**Fix:** Use proper GitHub documentation pattern with specific anchors
130+
```javascript
131+
// ❌ BROKEN - Old forum or localhost links
132+
<label><a href="https://huntarr.io/threads/name-field.18/" class="info-icon">
133+
<label><a href="/Huntarr.io/docs/#/configuration" class="info-icon">
134+
<label><a href="#" class="info-icon">
135+
136+
// ✅ FIXED - GitHub documentation with anchors
137+
<label><a href="https://plexguide.github.io/Huntarr.io/apps/radarr.html#instances" class="info-icon">
138+
<label><a href="https://plexguide.github.io/Huntarr.io/apps/radarr.html#skip-future-movies" class="info-icon">
139+
<label><a href="https://plexguide.github.io/Huntarr.io/apps/swaparr.html#enable-swaparr" class="info-icon">
140+
```
141+
**Pattern:** `https://plexguide.github.io/Huntarr.io/apps/[app-name].html#[anchor]`
142+
**Requirements:**
143+
- Always use `https://plexguide.github.io/Huntarr.io/` domain
144+
- Include `target="_blank" rel="noopener"` attributes
145+
- Use specific anchors that match documentation headers
146+
- Ensure documentation anchors exist before linking
147+
**File:** `/frontend/static/js/settings_forms.js`
148+
126149
## 🔧 DEVELOPMENT WORKFLOW
127150

128151
### Before Any Changes
@@ -203,6 +226,19 @@ grep -r "window.location.href = '/" frontend/
203226
3. Test save/load cycle
204227
4. Check API endpoints
205228

229+
## 📊 RECENT IMPROVEMENTS
230+
231+
### Radarr Release Date Consistency (2024-12)
232+
**Issue:** Missing movie searches respected `skip_future_releases` setting, but upgrade searches ignored it
233+
**Solution:** Made upgrade behavior consistent with missing movie logic
234+
**Changes:**
235+
- Updated `src/primary/apps/radarr/upgrade.py` to check release dates
236+
- Both missing and upgrade searches now respect `skip_future_releases` and `process_no_release_dates`
237+
- Documentation updated to clarify behavior affects both search types
238+
- Frontend info icons fixed to use GitHub documentation links
239+
240+
**User Benefit:** Consistent behavior - no more unexpected future movie upgrades
241+
206242
## ⚠️ ANTI-PATTERNS TO AVOID
207243

208244
1. **❌ Hard-coded absolute paths:** `/config/file.json`
@@ -214,6 +250,7 @@ grep -r "window.location.href = '/" frontend/
214250
7. **❌ Testing only in Docker (must test bare metal)**
215251
8. **❌ Adding responsive CSS to component templates (use external CSS files)**
216252
9. **❌ Not using debug borders to test CSS loading**
253+
10. **❌ Inconsistent behavior between missing/upgrade logic** - Always check both implement same filtering
217254

218255
## 🚀 ENVIRONMENT DETECTION PATTERN
219256

docs/apps/radarr.html

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ <h4 id="skip-future-movies"><i class="fas fa-calendar" style="margin-right: 8px;
175175
<strong>📋 Release Date Logic Simplified:</strong> As of Huntarr 7.6.0+, we've simplified release date filtering to only use the <strong>Release Date</strong> field from Radarr. This field is the most reliable and consistently populated date field in the Radarr API.
176176
</div>
177177

178+
179+
178180
<h5>Why We Simplified Release Date Detection</h5>
179181
<p>Previous versions of Huntarr used complex fallback logic that checked multiple date fields (Physical Release, Digital Release, In Cinemas) with confusing priority rules. This approach had several problems:</p>
180182
<ul>
@@ -199,6 +201,8 @@ <h5>Release Date Logic Flow</h5>
199201
<li><strong>Skip Future Releases = ON:</strong> Only process movies with past release dates, with optional control over movies with missing dates</li>
200202
</ul>
201203

204+
205+
202206
<div class="mermaid">
203207
graph TD
204208
A["🎬 Radarr Movie"] --> B["Check Skip Future Releases Setting"]
@@ -366,11 +370,13 @@ <h4>Quality Profile Issues</h4>
366370
<p>If Huntarr isn't finding the right quality:</p>
367371
<ul>
368372
<li>Verify your quality profiles are properly configured in Radarr</li>
369-
<li>Check that your indexers support the quality levels you're seeking</li>
370-
<li>Review cutoff settings to ensure upgrades are allowed</li>
371-
<li>Consider adjusting your upgrade search frequency</li>
373+
<li>Check that your cutoff settings in Radarr match your expectations</li>
374+
<li>Ensure your indexers support the quality levels you want</li>
372375
</ul>
373376

377+
378+
379+
374380
<div class="section-nav">
375381
<a href="sonarr.html">← Sonarr Documentation</a>
376382
<a href="lidarr.html">Lidarr Documentation →</a>

0 commit comments

Comments
 (0)