Remove go routine counting in test since it's not reliable

Author: Tobias Kaupat

udp/server_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"context"
 	"net"
-	"runtime"
 	"sync"
 	"testing"
 	"time"
@@ -141,52 +140,39 @@ func TestServer_Discover(t *testing.T) {
 }
 
 func TestServer_CleanUpConns(t *testing.T) {
-	runtime.GC()
-	var initialGoCnt = runtime.NumGoroutine()
-
-	var wg sync.WaitGroup
-	// Container func for defers
-	func() {
-		ld, err := coapNet.NewListenUDP("udp4", "")
-		require.NoError(t, err)
-		defer ld.Close()
-
-		var checkCloseWg sync.WaitGroup
-		defer checkCloseWg.Wait()
-		sd := udp.NewServer(udp.WithOnNewClientConn(func(cc *client.ClientConn) {
-			checkCloseWg.Add(1)
-			cc.AddOnClose(func() {
-				checkCloseWg.Done()
-			})
-		}))
-		defer sd.Stop()
-
-		wg.Add(1)
-		go func() {
-			defer wg.Done()
-			err := sd.Serve(ld)
-			require.NoError(t, err)
-		}()
+	ld, err := coapNet.NewListenUDP("udp4", "")
+	require.NoError(t, err)
+	defer ld.Close()
 
-		cc, err := udp.Dial(ld.LocalAddr().String())
-		require.NoError(t, err)
+	var checkCloseWg sync.WaitGroup
+	defer checkCloseWg.Wait()
+	sd := udp.NewServer(udp.WithOnNewClientConn(func(cc *client.ClientConn) {
 		checkCloseWg.Add(1)
 		cc.AddOnClose(func() {
 			checkCloseWg.Done()
 		})
-		defer cc.Close()
-		ctx, cancel := context.WithTimeout(context.Background(), time.Second)
-		defer cancel()
-		err = cc.Ping(ctx)
-		require.NoError(t, err)
+	}))
+	defer sd.Stop()
 
+	var wg sync.WaitGroup
+	wg.Add(1)
+	go func() {
+		defer wg.Done()
+		err := sd.Serve(ld)
+		require.NoError(t, err)
 	}()
-	wg.Wait()
-	runtime.GC()
-	time.Sleep(10 * time.Millisecond)
-	if !assert.Equal(t, initialGoCnt, runtime.NumGoroutine()) {
-		printStacktrace(t)
-	}
+
+	cc, err := udp.Dial(ld.LocalAddr().String())
+	require.NoError(t, err)
+	checkCloseWg.Add(1)
+	cc.AddOnClose(func() {
+		checkCloseWg.Done()
+	})
+	defer cc.Close()
+	ctx, cancel := context.WithTimeout(context.Background(), time.Second)
+	defer cancel()
+	err = cc.Ping(ctx)
+	require.NoError(t, err)
 }
 
 func TestServer_InactiveMonitor(t *testing.T) {
@@ -249,11 +235,3 @@ func TestServer_InactiveMonitor(t *testing.T) {
 	checkCloseWg.Wait()
 	require.True(t, inactivityDetected)
 }
-
-func printStacktrace(t *testing.T) {
-	buf := make([]byte, 1<<20)
-
-	stacklen := runtime.Stack(buf, true)
-	t.Logf("Number goRoutines: %d\n", runtime.NumGoroutine())
-	t.Logf("*** goroutine dump...\n%s\n*** end\n", buf[:stacklen])
-}