chore: Fix CI (#620)

jkralik · rodneyosodo · web-flow · commit 9ff3778c8bf7 · 2025-09-13T09:05:58.000+02:00
* chore: update go dependencies

* chore: add dependabot

* chore: update github workflows

* style: ignore noctx for go 1.20

Signed-off-by: Rodney Osodo &lt;socials@rodneyosodo.com&gt;

* fix(ci): sonarcloud-github-action is deprecated

* chore: For consistency bump actions/setup-go

* chore: Skip mcast tests for any,all interfaces for macos

---------

Signed-off-by: Rodney Osodo &lt;socials@rodneyosodo.com&gt;
Co-authored-by: Rodney Osodo &lt;socials@rodneyosodo.com&gt;
diff --git a/.github/dependabot.yaml b/.github/dependabot.yaml
@@ -0,0 +1,21 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "./.github/workflows"
+    schedule:
+      interval: "monthly"
+      day: "monday"
+    groups:
+      gh-dependency:
+        patterns:
+          - "*"
+
+  - package-ecosystem: "gomod"
+    directory: "/"
+    schedule:
+      interval: "monthly"
+      day: "monday"
+    groups:
+      go-dependency:
+        patterns:
+          - "*"
diff --git a/.github/workflows/cifuzz.yml b/.github/workflows/cifuzz.yml
@@ -1,33 +1,41 @@
 name: CIFuzz
+
 on:
   pull_request:
   workflow_dispatch:
+
 permissions: {}
+
 jobs:
  Fuzzing:
    runs-on: ubuntu-latest
+
    permissions:
      security-events: write
+
    steps:
    - name: Build Fuzzers
      id: build
      uses: google/oss-fuzz/infra/cifuzz/actions/build_fuzzers@master
      with:
        oss-fuzz-project-name: 'go-coap'
        language: go
+
    - name: Run Fuzzers
      uses: google/oss-fuzz/infra/cifuzz/actions/run_fuzzers@master
      with:
        oss-fuzz-project-name: 'go-coap'
        language: go
        fuzz-seconds: 300
        output-sarif: true
+
    - name: Upload Crash
      uses: actions/upload-artifact@v4
      if: failure() && steps.build.outcome == 'success'
      with:
        name: artifacts
        path: ./out/artifacts
+
    - name: Upload Sarif
      if: always() && steps.build.outcome == 'success'
      uses: github/codeql-action/upload-sarif@v3
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -8,16 +8,18 @@ name: Golangci-lint
 on:
   pull_request:
   workflow_dispatch:
+
 jobs:
   golangci:
     name: lint
     runs-on: ubuntu-latest
+
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Set up Go 1.20+
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: "^1.20" # The Go version to download (if necessary) and use.
           check-latest: true
@@ -27,5 +29,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v8
         with:
-          version: latest
+          version: v2.4.0
           args: --timeout=5m
diff --git a/.github/workflows/staticAnalysis.yml b/.github/workflows/staticAnalysis.yml
@@ -11,10 +11,10 @@ jobs:
 
     steps:
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Set up Go 1.20+
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: "^1.20" # The Go version to download (if necessary) and use.
           check-latest: true
diff --git a/.github/workflows/test-for-fork.yml b/.github/workflows/test-for-fork.yml
@@ -15,7 +15,7 @@ jobs:
 
     steps:
       - name: Set up Go 1.20+
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: "^1.20"
           check-latest: true
@@ -24,7 +24,7 @@ jobs:
 
       # Checks-out repository under $GITHUB_WORKSPACE
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       # Build everything
       - name: Run a build
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: Set up Go 1.20+
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: "^1.20"
           check-latest: true
@@ -33,7 +33,7 @@ jobs:
 
       # Checks-out repository under $GITHUB_WORKSPACE with tags and history (needed by "SonarCloud Scan" step)
       - name: Full checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
         with:
           fetch-depth: 0 # Full clone for SonarCloud
 
@@ -73,12 +73,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v5
         with:
           fetch-depth: 0 # Shallow clones should be disabled for a better relevancy of analysis
 
       - name: Download artifacts
-        uses: actions/download-artifact@v4
+        uses: actions/download-artifact@v5
         with:
           path: ./outputs
 
@@ -90,13 +90,13 @@ jobs:
           find ./outputs -name "*.report.json" -exec sh -c 'cp $1 .tmp/report/$(echo $1 | sed "s/[\/.]/-/g" ).report.json' _ {}  \;
 
       - name: Code coverage
-        uses: codecov/codecov-action@v4.0.0-beta.3
+        uses: codecov/codecov-action@v5
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
           directory: .tmp/
 
-      - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
+      - name: SonarQube Scan
+        uses: SonarSource/sonarqube-scan-action@v5
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
@@ -112,14 +112,14 @@ jobs:
 
     steps:
       - name: Set up Go 1.20
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v6
         with:
           go-version: "~1.20"
 
       - run: go version
 
       - name: Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v5
 
       - name: Run a build
         run: go build ./...
diff --git a/.golangci.yml b/.golangci.yml
@@ -46,7 +46,7 @@ linters:
     - nestif           # Reports deeply nested if statements
     - nilerr           # Finds the code that returns nil even if it checks that the error is not nil.
     - nilnil           # Checks that there is no simultaneous return of `nil` error and an invalid value.
-    - noctx            # noctx finds sending http request without context.Context
+    # - noctx            # noctx finds sending http request without context.Context - Some occurrences are not support in go1.20
     - nolintlint       # Reports ill-formed or insufficient nolint directives
     - nosprintfhostport # Checks for misuse of Sprintf to construct a host with port in a URL
     - perfsprint       # Checks that fmt.Sprintf can be replaced with a faster alternative.
diff --git a/go.mod b/go.mod
@@ -4,8 +4,8 @@ go 1.20
 
 require (
 	github.com/dsnet/golib/memfile v1.0.0
-	github.com/pion/dtls/v3 v3.0.6
-	github.com/stretchr/testify v1.9.0
+	github.com/pion/dtls/v3 v3.0.7
+	github.com/stretchr/testify v1.11.1
 	go.uber.org/atomic v1.11.0
 	golang.org/x/exp v0.0.0-20240904232852-e7e105dedf7e
 	golang.org/x/net v0.35.0
@@ -14,7 +14,7 @@ require (
 
 require (
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/pion/logging v0.2.3 // indirect
+	github.com/pion/logging v0.2.4 // indirect
 	github.com/pion/transport/v3 v3.0.7 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
 	golang.org/x/crypto v0.33.0 // indirect
diff --git a/go.sum b/go.sum
@@ -2,16 +2,16 @@ github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/dsnet/golib/memfile v1.0.0 h1:J9pUspY2bDCbF9o+YGwcf3uG6MdyITfh/Fk3/CaEiFs=
 github.com/dsnet/golib/memfile v1.0.0/go.mod h1:tXGNW9q3RwvWt1VV2qrRKlSSz0npnh12yftCSCy2T64=
-github.com/pion/dtls/v3 v3.0.6 h1:7Hkd8WhAJNbRgq9RgdNh1aaWlZlGpYTzdqjy9x9sK2E=
-github.com/pion/dtls/v3 v3.0.6/go.mod h1:iJxNQ3Uhn1NZWOMWlLxEEHAN5yX7GyPvvKw04v9bzYU=
-github.com/pion/logging v0.2.3 h1:gHuf0zpoh1GW67Nr6Gj4cv5Z9ZscU7g/EaoC/Ke/igI=
-github.com/pion/logging v0.2.3/go.mod h1:z8YfknkquMe1csOrxK5kc+5/ZPAzMxbKLX5aXpbpC90=
+github.com/pion/dtls/v3 v3.0.7 h1:bItXtTYYhZwkPFk4t1n3Kkf5TDrfj6+4wG+CZR8uI9Q=
+github.com/pion/dtls/v3 v3.0.7/go.mod h1:uDlH5VPrgOQIw59irKYkMudSFprY9IEFCqz/eTz16f8=
+github.com/pion/logging v0.2.4 h1:tTew+7cmQ+Mc1pTBLKH2puKsOvhm32dROumOZ655zB8=
+github.com/pion/logging v0.2.4/go.mod h1:DffhXTKYdNZU+KtJ5pyQDjvOAh/GsNSyv1lbkFbe3so=
 github.com/pion/transport/v3 v3.0.7 h1:iRbMH05BzSNwhILHoBoAPxoB9xQgOaJk+591KC9P1o0=
 github.com/pion/transport/v3 v3.0.7/go.mod h1:YleKiTZ4vqNxVwh77Z0zytYi7rXHl7j6uPLGhhz9rwo=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
-github.com/stretchr/testify v1.9.0 h1:HtqpIVDClZ4nwg75+f6Lvsy/wHu+3BoSGCbBAcpTsTg=
-github.com/stretchr/testify v1.9.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
+github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
+github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
 go.uber.org/atomic v1.11.0 h1:ZvwS0R+56ePWxUNi+Atn9dWONBPp/AUETXlHW0DxSjE=
 go.uber.org/atomic v1.11.0/go.mod h1:LUxbIzbOniOlMKjJjyPfpl4v+PKK2cNJn91OQbhoJI0=
 golang.org/x/crypto v0.33.0 h1:IOBPskki6Lysi0lo9qQvbxiQ+FvsCC/YWOecCHAixus=
diff --git a/net/connUDP_internal_test.go b/net/connUDP_internal_test.go
@@ -140,6 +140,7 @@ func TestUDPConnwriteMulticastWithContext(t *testing.T) {
 		}
 	}
 	require.NotEmpty(t, iface)
+	const goosDarwin = "darwin"
 
 	type args struct {
 		ctx     context.Context
@@ -151,6 +152,7 @@ func TestUDPConnwriteMulticastWithContext(t *testing.T) {
 		name    string
 		args    args
 		wantErr bool
+		skip    func() bool
 	}{
 		{
 			name: "valid all interfaces",
@@ -160,6 +162,9 @@ func TestUDPConnwriteMulticastWithContext(t *testing.T) {
 				buffer:  payload,
 				opts:    []MulticastOption{WithAllMulticastInterface()},
 			},
+			skip: func() bool {
+				return runtime.GOOS == goosDarwin
+			},
 		},
 		{
 			name: "valid any interface",
@@ -169,6 +174,9 @@ func TestUDPConnwriteMulticastWithContext(t *testing.T) {
 				buffer:  payload,
 				opts:    []MulticastOption{WithAnyMulticastInterface()},
 			},
+			skip: func() bool {
+				return runtime.GOOS == goosDarwin
+			},
 		},
 		{
 			name: "valid first interface",
@@ -242,6 +250,10 @@ func TestUDPConnwriteMulticastWithContext(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			if tt.skip != nil && tt.skip() {
+				t.Log("skipped")
+				return
+			}
 			err = c1.WriteMulticast(tt.args.ctx, tt.args.udpAddr, tt.args.buffer, tt.args.opts...)
 			c1.LocalAddr()
 			c1.RemoteAddr()
@@ -361,6 +373,7 @@ func TestUDPConnWriteToAddr(t *testing.T) {
 		name    string
 		args    args
 		wantErr bool
+		skip    func() bool
 	}{
 		{
 			name: "IPv4",
@@ -407,6 +420,9 @@ func TestUDPConnWriteToAddr(t *testing.T) {
 				raddr:             &net.UDPAddr{IP: net.IPv4(224, 0, 0, 1), Port: 1234},
 				buffer:            []byte("hello world"),
 			},
+			skip: func() bool {
+				return runtime.GOOS == "darwin"
+			},
 		},
 		{
 			name: "with interface and source",
@@ -421,6 +437,10 @@ func TestUDPConnWriteToAddr(t *testing.T) {
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
+			if tt.skip != nil && tt.skip() {
+				t.Log("skipped")
+				return
+			}
 			network := udp4Network
 			ip := getIfaceAddr(t, iface, true)
 			if IsIPv6(tt.args.src) {
diff --git a/udp/server_test.go b/udp/server_test.go
