Merge pull request #358 from plivo/VPT-5202

VPT-5202: Plivo Send Digits Call is Failing

Author: manjunath-plivo

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change Log
 
+## [v4.72.0](https://github.com/plivo/plivo-node/tree/v4.72.0) (2025-06-16)
+**Bug Fix - sendDigits validation issue**
+- Fixed `isRequired` validator to properly handle falsy values including the number `0`, resolving "Missing mandatory field: digits" error when sending digit "0"
+- Updated TypeScript definitions for `sendDigits` method to accept `string` instead of `number` to match API expectations and existing tests
+
 ## [v4.71.0](https://github.com/plivo/plivo-node/tree/v4.71.0) (2025-06-13)
 **Bug Fix**
 - Added HTTP/HTTPS agent configuration with connection pooling to prevent progressive API latency increase.

lib/resources/call.js

@@ -459,7 +459,7 @@ export class Call extends PlivoResource {
     /**
      * Send digits on a call
      * @method
-     * @param {number} digits - digits to be send
+     * @param {string} digits - digits to be send
      * @param {object} optionalParams - to send digits for call
      * @promise {object} returns PlivoGenericResponse Object
      * @fail {Error} returns Error
@@ -981,7 +981,7 @@ export class CallInterface extends PlivoResourceInterface {
      * Send digits on a call
      * @method
      * @param {string} callUUID - call uuid to send digits on a call
-     * @param {number} digits - digits to be send
+     * @param {string} digits - digits to be send
      * @param {object} optionalParams - optional params to send digits
      * @promise {object} returns PlivoGenericResponse Object
      * @fail {Error} returns Error

lib/utils/common.js

@@ -34,7 +34,7 @@ export let validate = (() => {
   // };
 
   Validators.isRequired = field => {
-    return !field;
+    return field === null || field === undefined || field === '';
   };
 
   Validators.isTemplate = field => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "plivo",
-  "version": "4.71.0",
+  "version": "4.72.0",
   "description": "A Node.js SDK to make voice calls and send SMS using Plivo and to generate Plivo XML",
   "homepage": "https://github.com/plivo/plivo-node",
   "files": [

test/calls.js

@@ -152,6 +152,10 @@ describe('calls', function () {
     it('should send digits', function () {
       return client.calls.sendDigits('aaa-deeiei3-dfddd', '123');
     });
+
+    it('should send digits with zero', function () {
+      return client.calls.sendDigits('aaa-deeiei3-dfddd', '0');
+    });
   });
 
   describe('Play', function () {

types/resources/call.d.ts

@@ -248,12 +248,12 @@ export class Call extends PlivoResource {
 	/**
 	 * Send digits on a call
 	 * @method
-	 * @param {number} digits - digits to be send
+	 * @param {string} digits - digits to be send
 	 * @param {object} optionalParams - to send digits for call
 	 * @promise {object} returns PlivoGenericResponse Object
 	 * @fail {Error} returns Error
 	 */
-	sendDigits(digits: number, optionalParams: object): Promise < SendDigitsResponse > ;
+	sendDigits(digits: string, optionalParams: object): Promise < SendDigitsResponse > ;
 	/**
 	 * Hangup a Call Request
 	 * @method
@@ -424,12 +424,12 @@ export class CallInterface extends PlivoResourceInterface {
 	 * Send digits on a call
 	 * @method
 	 * @param {string} callUUID - call uuid to send digits on a call
-	 * @param {number} digits - digits to be send
+	 * @param {string} digits - digits to be send
 	 * @param {object} optionalParams - optional params to send digits
 	 * @promise {object} returns PlivoGenericResponse Object
 	 * @fail {Error} returns Error
 	 */
-	sendDigits(callUUID: string, digits: number, optionalParams: object): Promise < any > ;
+	sendDigits(callUUID: string, digits: string, optionalParams: object): Promise < any > ;
 	/**
 	 * Hangup a call request
 	 * @method