Merge pull request #194 from plivo/VT-3986

application create/update changes

Author: huzaif-plivo

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Change Log
 
+## [4.22.3](https://github.com/plivo/plivo-python/tree/v4.22.3) (2022-03-04)
+**Bug fix - Application API (create/update)**
+- For [create & update application API](https://www.plivo.com/docs/account/api/application#create-an-application) the parameter `answer url` is set to optional. 
+- Failing to [update application](https://www.plivo.com/docs/account/api/application#update-an-application) because of `app_id`
+
 ## [4.22.2](https://github.com/plivo/plivo-python/tree/v4.22.2) (2022-02-25)
 **Feature - conference_recording**
 - Add callback_url parameter to [Record Conference API](https://www.plivo.com/docs/voice/api/conference/record-conference#start-recording-a-conference)

plivo/resources/applications.py

@@ -45,8 +45,8 @@ class Applications(PlivoResourceInterface):
     _resource_type = Application
 
     @validate_args(
-        answer_url=[is_url()],
         app_name=[of_type(six.text_type)],
+        answer_url=[optional(is_url())],
         answer_method=[optional(of_type(six.text_type))],
         hangup_url=[optional(is_url())],
         hangup_method=[optional(of_type(six.text_type))],
@@ -60,8 +60,8 @@ class Applications(PlivoResourceInterface):
         log_incoming_messages=[optional(of_type_exact(bool))],
         public_uri=[optional(of_type_exact(bool))])
     def create(self,
-               answer_url,
                app_name,
+               answer_url=None,
                answer_method='POST',
                hangup_url=None,
                hangup_method='POST',
@@ -110,8 +110,8 @@ def list(self, subaccount=None, limit=20, offset=0):
             objects_type=Application, is_voice_request=True)
 
     @validate_args(
-        answer_url=[is_url()],
         app_id=[of_type(six.text_type)],
+        answer_url=[optional(is_url())],
         answer_method=[optional(of_type(six.text_type))],
         hangup_url=[optional(is_url())],
         hangup_method=[optional(of_type(six.text_type))],
@@ -126,7 +126,7 @@ def list(self, subaccount=None, limit=20, offset=0):
         public_uri=[optional(of_type_exact(bool))])
     def update(self,
                app_id,
-               answer_url,
+               answer_url=None,
                answer_method='POST',
                hangup_url=None,
                hangup_method='POST',
@@ -142,8 +142,28 @@ def update(self,
         if subaccount:
             if isinstance(subaccount, Subaccount):
                 subaccount = subaccount.id
+
+        # using localVariablesObject insteadof locals() because we need to remove app_id
+        # as there is no support to update app_id, there is no way to remove an variable from locals() dictionary
+        localVariablesObject = {
+            'self': self,
+            'answer_url': answer_url,
+            'answer_method': answer_method,
+            'hangup_url' : hangup_url,
+            'hangup_method' : hangup_method,
+            'fallback_answer_url' : fallback_answer_url,
+            'fallback_method' : fallback_method,
+            'message_url' : message_url,
+            'message_method' : message_method,
+            'default_number_app' : default_number_app,
+            'default_endpoint_app' : default_endpoint_app,
+            'subaccount' : subaccount,
+            'log_incoming_messages' : log_incoming_messages,
+            'public_uri' : public_uri
+        }
+
         return self.client.request('POST', ('Application', app_id),
-                                   to_param_dict(self.update, locals()), is_voice_request=True)
+                                   to_param_dict(self.update, localVariablesObject), is_voice_request=True)
 
     @validate_args(
         app_id=[of_type(six.text_type)],

plivo/version.py

@@ -1,3 +1,3 @@
 # -*- coding: utf-8 -*-
-__version__ = '4.22.2'
+__version__ = '4.22.3'
 

setup.py

@@ -10,7 +10,7 @@
 
 setup(
     name='plivo',
-    version='4.22.2',
+    version='4.22.3',
     description='A Python SDK to make voice calls & send SMS using Plivo and to generate Plivo XML',
     long_description=long_description,
     url='https://github.com/plivo/plivo-python',

tests/resources/test_applications.py

@@ -10,9 +10,6 @@ def test_application_create_invalid_params(self):
         with self.assertRaises(plivo.exceptions.ValidationError):
             self.client.applications.create(None, None)
 
-        with self.assertRaises(plivo.exceptions.ValidationError):
-            self.client.applications.create('None', None)
-
         with self.assertRaises(plivo.exceptions.ValidationError):
             self.client.applications.create(
                 answer_url='None',
@@ -150,7 +147,7 @@ def test_application_update_invalid_params(self):
             self.client.applications.update(None, 'None', 'None')
 
         with self.assertRaises(plivo.exceptions.ValidationError):
-            self.client.applications.update('AppId', None, None, None, None,
+            self.client.applications.update(None, None, None, None, None,
                                             None, None, None, None, None, None,
                                             None)