Skip to content

Commit 22f04ae

Browse files
plokhotnyukplokhotnyuk
committed
Formatting of FIXME and TODO comments for easier distinguish from 3rd party ones
1 parent 4f1d01d commit 22f04ae

File tree

90 files changed

+407
-407
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

90 files changed

+407
-407
lines changed

‎jsoniter-scala-benchmark/js/src/main/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ object Main {
2121
B("circe")(benchmark.circe()),
2222
B("circeJsoniter")(benchmark.circeJsoniter()),
2323
B("jsoniterScala")(benchmark.jsoniterScala()),
24-
//FIXME play-json parses 42667970104045.735577865 as 42667970104045.734
25-
//B("playJson")(benchmark.playJson()),
24+
// FIXME: play-json parses 42667970104045.735577865 as 42667970104045.734
25+
// B("playJson")(benchmark.playJson()),
2626
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
2727
B("smithy4sJson")(benchmark.smithy4sJson()),
2828
B("uPickle")(benchmark.uPickle()),
@@ -284,8 +284,8 @@ object Main {
284284
B("circe")(benchmark.circe()),
285285
B("circeJsoniter")(benchmark.circeJsoniter()),
286286
B("jsoniterScala")(benchmark.jsoniterScala()),
287-
//FIXME play-json parses 1.1999999284744263 as 1.2000000476837158
288-
//B("playJson")(benchmark.playJson()),
287+
// FIXME: play-json parses 1.1999999284744263 as 1.2000000476837158
288+
// B("playJson")(benchmark.playJson()),
289289
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
290290
B("smithy4sJson")(benchmark.smithy4sJson()),
291291
B("uPickle")(benchmark.uPickle()),
@@ -373,8 +373,8 @@ object Main {
373373
}, {
374374
val benchmark = new ArrayOfJavaEnumsReading { size = 512; setup() }
375375
GS(S("ArrayOfJavaEnumsReading")(
376-
//FIXME: Cannot link with Scala.js
377-
//B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
376+
// FIXME: Cannot link with Scala.js
377+
// B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
378378
B("borer")(benchmark.borer()),
379379
B("circe")(benchmark.circe()),
380380
B("circeJsoniter")(benchmark.circeJsoniter()),
@@ -386,8 +386,8 @@ object Main {
386386
}, {
387387
val benchmark = new ArrayOfJavaEnumsWriting { size = 512; setup() }
388388
GS(S("ArrayOfJavaEnumsWriting")(
389-
//FIXME: Cannot link with Scala.js
390-
//B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
389+
// FIXME: Cannot link with Scala.js
390+
// B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
391391
B("borer")(benchmark.borer()),
392392
B("circe")(benchmark.circe()),
393393
B("circeJsoniter")(benchmark.circeJsoniter()),
@@ -493,7 +493,7 @@ object Main {
493493
B("circeJsoniter")(benchmark.circeJsoniter()),
494494
B("jsoniterScala")(benchmark.jsoniterScala()),
495495
// FIXME: play-json parses 697125858266480539 as 697125858266480500
496-
//B("playJson")(benchmark.playJson()),
496+
// B("playJson")(benchmark.playJson()),
497497
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
498498
B("smithy4sJson")(benchmark.smithy4sJson()),
499499
B("uPickle")(benchmark.uPickle()),
@@ -918,11 +918,11 @@ object Main {
918918
val benchmark = new BigDecimalReading { size = 512; setup() }
919919
GS(S("BigDecimalReading")(
920920
B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
921-
//FIXME: borer parses up to 200 digits only
922-
//B("borer")(benchmark.borer()),
921+
// FIXME: borer parses up to 200 digits only
922+
// B("borer")(benchmark.borer()),
923923
B("circe")(benchmark.circe()),
924-
//FIXME: circe-jsoniter parses up to 308 digits only
925-
//B("circeJsoniter")(benchmark.circeJsoniter()),
924+
// FIXME: circe-jsoniter parses up to 308 digits only
925+
// B("circeJsoniter")(benchmark.circeJsoniter()),
926926
B("jsoniterScala")(benchmark.jsoniterScala()),
927927
B("uPickle")(benchmark.uPickle()),
928928
B("zioJson")(benchmark.zioJson())
@@ -946,14 +946,14 @@ object Main {
946946
val benchmark = new BigIntReading { size = 512; setup() }
947947
GS(S("BigIntReading")(
948948
B("avSystemGenCodec")(benchmark.avSystemGenCodec()),
949-
//FIXME: borer parses up to 200 digits only
950-
//B("borer")(benchmark.borer()),
949+
// FIXME: borer parses up to 200 digits only
950+
// B("borer")(benchmark.borer()),
951951
B("circe")(benchmark.circe()),
952-
//FIXME: circe-jsoniter parses up to 308 digits only
953-
//B("circeJsoniter")(benchmark.circeJsoniter()),
952+
// FIXME: circe-jsoniter parses up to 308 digits only
953+
// B("circeJsoniter")(benchmark.circeJsoniter()),
954954
B("jsoniterScala")(benchmark.jsoniterScala()),
955955
// FIXME: smithy4sJson parses up to 308 digits only
956-
//B("smithy4sJson")(benchmark.smithy4sJson()),
956+
// B("smithy4sJson")(benchmark.smithy4sJson()),
957957
B("uPickle")(benchmark.uPickle()),
958958
B("zioJson")(benchmark.zioJson())
959959
))
@@ -1077,8 +1077,8 @@ object Main {
10771077
B("circeJsoniter")(benchmark.circeJsoniter()),
10781078
B("jsoniterScala")(benchmark.jsoniterScala()),
10791079
B("jsoniterScalaPrealloc")(benchmark.jsoniterScalaPrealloc()),
1080-
//FIXME: play-json pretty prints array values in one line
1081-
//B("playJson")(benchmark.playJson()),
1080+
// FIXME: play-json pretty prints array values in one line
1081+
// B("playJson")(benchmark.playJson()),
10821082
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
10831083
B("smithy4sJson")(benchmark.smithy4sJson()),
10841084
B("uPickle")(benchmark.uPickle()),
@@ -1351,10 +1351,10 @@ object Main {
13511351
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
13521352
B("smithy4sJson")(benchmark.smithy4sJson()),
13531353
B("uPickle")(benchmark.uPickle())
1354-
//FIXME: zio-json serializes default values
1355-
//B("zioJson")(benchmark.zioJson()),
1356-
//FIXME: zio-schema-json serializes default values
1357-
//B("zioSchemaJson")(benchmark.zioSchemaJson())
1354+
// FIXME: zio-json serializes default values
1355+
// B("zioJson")(benchmark.zioJson()),
1356+
// FIXME: zio-schema-json serializes default values
1357+
// B("zioSchemaJson")(benchmark.zioSchemaJson())
13581358
))
13591359
}, {
13601360
val benchmark = new SetOfIntsReading { size = 512; setup() }
@@ -1485,8 +1485,8 @@ object Main {
14851485
B("circe")(benchmark.circe()),
14861486
B("circeJsoniter")(benchmark.circeJsoniter()),
14871487
B("jsoniterScala")(benchmark.jsoniterScala()),
1488-
//FIXME: play-json parses 850007368138018817 as 850007368138018800
1489-
//B("playJson")(benchmark.playJson()),
1488+
// FIXME: play-json parses 850007368138018817 as 850007368138018800
1489+
// B("playJson")(benchmark.playJson()),
14901490
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
14911491
B("smithy4sJson")(benchmark.smithy4sJson()),
14921492
B("uPickle")(benchmark.uPickle()),

‎jsoniter-scala-benchmark/js/src/main/scala-3/com/github/plokhotnyuk/jsoniter_scala/benchmark/Main.scala

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ object Main {
2020
B("circe")(benchmark.circe()),
2121
B("circeJsoniter")(benchmark.circeJsoniter()),
2222
B("jsoniterScala")(benchmark.jsoniterScala()),
23-
//FIXME play-json parses 42667970104045.735577865 as 42667970104045.734
24-
//B("playJson")(benchmark.playJson()),
23+
// FIXME: play-json parses 42667970104045.735577865 as 42667970104045.734
24+
// B("playJson")(benchmark.playJson()),
2525
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
2626
B("smithy4sJson")(benchmark.smithy4sJson()),
2727
B("uPickle")(benchmark.uPickle()),
@@ -265,8 +265,8 @@ object Main {
265265
B("circe")(benchmark.circe()),
266266
B("circeJsoniter")(benchmark.circeJsoniter()),
267267
B("jsoniterScala")(benchmark.jsoniterScala()),
268-
//FIXME play-json parses 1.1999999284744263 as 1.2000000476837158
269-
//B("playJson")(benchmark.playJson()),
268+
// FIXME: play-json parses 1.1999999284744263 as 1.2000000476837158
269+
// B("playJson")(benchmark.playJson()),
270270
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
271271
B("smithy4sJson")(benchmark.smithy4sJson()),
272272
B("uPickle")(benchmark.uPickle()),
@@ -458,7 +458,7 @@ object Main {
458458
B("circeJsoniter")(benchmark.circeJsoniter()),
459459
B("jsoniterScala")(benchmark.jsoniterScala()),
460460
// FIXME: play-json parses 697125858266480539 as 697125858266480500
461-
//B("playJson")(benchmark.playJson()),
461+
// B("playJson")(benchmark.playJson()),
462462
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
463463
B("smithy4sJson")(benchmark.smithy4sJson()),
464464
B("uPickle")(benchmark.uPickle()),
@@ -853,11 +853,11 @@ object Main {
853853
}, {
854854
val benchmark = new BigDecimalReading { size = 512; setup() }
855855
GS(S("BigDecimalReading")(
856-
//FIXME: borer parses up to 200 digits only
857-
//B("borer")(benchmark.borer()),
856+
// FIXME: borer parses up to 200 digits only
857+
// B("borer")(benchmark.borer()),
858858
B("circe")(benchmark.circe()),
859-
//FIXME: circe-jsoniter parses up to 308 digits only
860-
//B("circeJsoniter")(benchmark.circeJsoniter()),
859+
// FIXME: circe-jsoniter parses up to 308 digits only
860+
// B("circeJsoniter")(benchmark.circeJsoniter()),
861861
B("jsoniterScala")(benchmark.jsoniterScala()),
862862
B("uPickle")(benchmark.uPickle()),
863863
B("zioJson")(benchmark.zioJson())
@@ -879,14 +879,14 @@ object Main {
879879
}, {
880880
val benchmark = new BigIntReading { size = 512; setup() }
881881
GS(S("BigIntReading")(
882-
//FIXME: borer parses up to 200 digits only
883-
//B("borer")(benchmark.borer()),
882+
// FIXME: borer parses up to 200 digits only
883+
// B("borer")(benchmark.borer()),
884884
B("circe")(benchmark.circe()),
885-
//FIXME: circe-jsoniter parses up to 308 digits only
886-
//B("circeJsoniter")(benchmark.circeJsoniter()),
885+
// FIXME: circe-jsoniter parses up to 308 digits only
886+
// B("circeJsoniter")(benchmark.circeJsoniter()),
887887
B("jsoniterScala")(benchmark.jsoniterScala()),
888888
// FIXME: smithy4sJson parses up to 308 digits only
889-
//B("smithy4sJson")(benchmark.smithy4sJson()),
889+
// B("smithy4sJson")(benchmark.smithy4sJson()),
890890
B("uPickle")(benchmark.uPickle()),
891891
B("zioJson")(benchmark.zioJson())
892892
))
@@ -948,8 +948,8 @@ object Main {
948948
B("smithy4sJson")(benchmark.smithy4sJson()),
949949
B("uPickle")(benchmark.uPickle()),
950950
B("zioJson")(benchmark.zioJson())
951-
//FIXME: zio-schema-json throws java.lang.RuntimeException: .type.FeatureCollection.features[0].type.Feature.geometry.type.Polygon(unrecognized subtype)
952-
//B("zioSchemaJson")(benchmark.zioSchemaJson())
951+
// FIXME: zio-schema-json throws java.lang.RuntimeException: .type.FeatureCollection.features[0].type.Feature.geometry.type.Polygon(unrecognized subtype)
952+
// B("zioSchemaJson")(benchmark.zioSchemaJson())
953953
))
954954
}, {
955955
val benchmark = new GeoJSONWriting { setup() }
@@ -1003,8 +1003,8 @@ object Main {
10031003
B("circeJsoniter")(benchmark.circeJsoniter()),
10041004
B("jsoniterScala")(benchmark.jsoniterScala()),
10051005
B("jsoniterScalaPrealloc")(benchmark.jsoniterScalaPrealloc()),
1006-
//FIXME: play-json pretty prints array values in one line
1007-
//B("playJson")(benchmark.playJson()),
1006+
// FIXME: play-json pretty prints array values in one line
1007+
// B("playJson")(benchmark.playJson()),
10081008
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
10091009
B("smithy4sJson")(benchmark.smithy4sJson()),
10101010
B("uPickle")(benchmark.uPickle()),
@@ -1256,10 +1256,10 @@ object Main {
12561256
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
12571257
B("smithy4sJson")(benchmark.smithy4sJson()),
12581258
B("uPickle")(benchmark.uPickle())
1259-
//FIXME: zio-json serializes default values
1260-
//B("zioJson")(benchmark.zioJson()),
1261-
//FIXME: zio-schema-json serializes default values
1262-
//B("zioSchemaJson")(benchmark.zioSchemaJson())
1259+
// FIXME: zio-json serializes default values
1260+
// B("zioJson")(benchmark.zioJson()),
1261+
// FIXME: zio-schema-json serializes default values
1262+
// B("zioSchemaJson")(benchmark.zioSchemaJson())
12631263
))
12641264
}, {
12651265
val benchmark = new SetOfIntsReading { size = 512; setup() }
@@ -1381,8 +1381,8 @@ object Main {
13811381
B("circe")(benchmark.circe()),
13821382
B("circeJsoniter")(benchmark.circeJsoniter()),
13831383
B("jsoniterScala")(benchmark.jsoniterScala()),
1384-
//FIXME: play-json parses 850007368138018817 as 850007368138018800
1385-
//B("playJson")(benchmark.playJson()),
1384+
// FIXME: play-json parses 850007368138018817 as 850007368138018800
1385+
// B("playJson")(benchmark.playJson()),
13861386
B("playJsonJsoniter")(benchmark.playJsonJsoniter()),
13871387
B("smithy4sJson")(benchmark.smithy4sJson()),
13881388
B("uPickle")(benchmark.uPickle()),

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/ArrayOfBigDecimalsReadingSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class ArrayOfBigDecimalsReadingSpec extends BenchmarkSpecBase {
1414
benchmark.circe() shouldBe benchmark.sourceObj
1515
benchmark.circeJsoniter() shouldBe benchmark.sourceObj
1616
benchmark.jsoniterScala() shouldBe benchmark.sourceObj
17-
//FIXME play-json parses 42667970104045.735577865 as 42667970104045.734
18-
//benchmark.playJson() shouldBe benchmark.sourceObj
17+
// FIXME: play-json parses 42667970104045.735577865 as 42667970104045.734
18+
// benchmark.playJson() shouldBe benchmark.sourceObj
1919
benchmark.playJsonJsoniter() shouldBe benchmark.sourceObj
2020
benchmark.smithy4sJson() shouldBe benchmark.sourceObj
2121
benchmark.uPickle() shouldBe benchmark.sourceObj

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/ArrayOfBigIntsReadingSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class ArrayOfBigIntsReadingSpec extends BenchmarkSpecBase {
1414
benchmark.circe() shouldBe benchmark.obj
1515
benchmark.circeJsoniter() shouldBe benchmark.obj
1616
benchmark.jsoniterScala() shouldBe benchmark.obj
17-
//FIXME: Play-JSON looses significant digits in BigInt values
18-
//benchmark.playJson() shouldBe benchmark.obj
17+
// FIXME: Play-JSON looses significant digits in BigInt values
18+
// benchmark.playJson() shouldBe benchmark.obj
1919
benchmark.smithy4sJson() shouldBe benchmark.obj
2020
benchmark.uPickle() shouldBe benchmark.obj
2121
benchmark.zioJson() shouldBe benchmark.obj

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/ArrayOfBigIntsWritingSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class ArrayOfBigIntsWritingSpec extends BenchmarkSpecBase {
1414
toString(b.circeJsoniter()) shouldBe b.jsonString
1515
toString(b.jsoniterScala()) shouldBe b.jsonString
1616
toString(b.preallocatedBuf, 64, b.jsoniterScalaPrealloc()) shouldBe b.jsonString
17-
//FIXME: Play-JSON uses BigDecimal with engineering decimal representation to serialize numbers
17+
// FIXME: Play-JSON uses BigDecimal with engineering decimal representation to serialize numbers
1818
//toString(b.playJson()) shouldBe b.jsonString
1919
toString(b.playJsonJsoniter()) shouldBe b.jsonString
2020
toString(b.smithy4sJson()) shouldBe b.jsonString

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/ArrayOfFloatsReadingSpec.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ class ArrayOfFloatsReadingSpec extends BenchmarkSpecBase {
2525
benchmark.circe() shouldBe benchmark.obj
2626
benchmark.circeJsoniter() shouldBe benchmark.obj
2727
benchmark.jsoniterScala() shouldBe benchmark.obj
28-
//FIXME play-json parses 1.1999999284744263 as 1.2000000476837158
29-
//benchmark.playJson() shouldBe benchmark.obj
28+
// FIXME: play-json parses 1.1999999284744263 as 1.2000000476837158
29+
// benchmark.playJson() shouldBe benchmark.obj
3030
benchmark.playJsonJsoniter() shouldBe benchmark.obj
3131
benchmark.smithy4sJson() shouldBe benchmark.obj
3232
benchmark.uPickle() shouldBe benchmark.obj

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/ArrayOfLongsReadingSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ class ArrayOfLongsReadingSpec extends BenchmarkSpecBase {
1515
benchmark.circeJsoniter() shouldBe benchmark.obj
1616
benchmark.jsoniterScala() shouldBe benchmark.obj
1717
// FIXME: play-json parses 697125858266480539 as 697125858266480500
18-
//benchmark.playJson() shouldBe benchmark.obj
18+
// benchmark.playJson() shouldBe benchmark.obj
1919
benchmark.playJsonJsoniter() shouldBe benchmark.obj
2020
benchmark.smithy4sJson() shouldBe benchmark.obj
2121
benchmark.uPickle() shouldBe benchmark.obj

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigDecimalReadingSpec.scala

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,28 +10,28 @@ class BigDecimalReadingSpec extends BenchmarkSpecBase {
1010
"BigDecimalReading" should {
1111
"read properly" in {
1212
benchmark.avSystemGenCodec() shouldBe benchmark.sourceObj
13-
//FIXME: borer parses up to 200 digits only
14-
//benchmark.borer() shouldBe benchmark.sourceObj
13+
// FIXME: borer parses up to 200 digits only
14+
// benchmark.borer() shouldBe benchmark.sourceObj
1515
benchmark.circe() shouldBe benchmark.sourceObj
16-
//FIXME: circe-jsoniter parses up to 308 digits only
17-
//benchmark.circeJsoniter() shouldBe benchmark.sourceObj
16+
// FIXME: circe-jsoniter parses up to 308 digits only
17+
// benchmark.circeJsoniter() shouldBe benchmark.sourceObj
1818
benchmark.jsoniterScala() shouldBe benchmark.sourceObj
19-
//FIXME: Play-JSON: don't know how to tune precision for parsing of BigDecimal values
20-
//benchmark.playJson() shouldBe benchmark.sourceObj
21-
//FIXME: smithy4sJson parses up to 308 digits only
22-
//benchmark.smithy4sJson() shouldBe benchmark.sourceObj
19+
// FIXME: Play-JSON: don't know how to tune precision for parsing of BigDecimal values
20+
// benchmark.playJson() shouldBe benchmark.sourceObj
21+
// FIXME: smithy4sJson parses up to 308 digits only
22+
// benchmark.smithy4sJson() shouldBe benchmark.sourceObj
2323
benchmark.uPickle() shouldBe benchmark.sourceObj
2424
benchmark.zioJson() shouldBe benchmark.sourceObj
2525
}
2626
"fail on invalid input" in {
2727
val b = benchmark
2828
b.jsonBytes = "{}".getBytes(UTF_8)
2929
intercept[Throwable](b.avSystemGenCodec())
30-
//FIXME: borer parses up to 200 digits only
31-
//intercept[Throwable](b.borer())
30+
// FIXME: borer parses up to 200 digits only
31+
// intercept[Throwable](b.borer())
3232
intercept[Throwable](b.circe())
33-
//FIXME: circe-jsoniter parses up to 308 digits only
34-
//intercept[Throwable](b.circeJsoniter())
33+
// FIXME: circe-jsoniter parses up to 308 digits only
34+
// intercept[Throwable](b.circeJsoniter())
3535
intercept[Throwable](b.jsoniterScala())
3636
intercept[Throwable](b.uPickle())
3737
intercept[Throwable](b.zioJson())

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntReadingSpec.scala

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,31 +10,31 @@ class BigIntReadingSpec extends BenchmarkSpecBase {
1010
"BigIntReading" should {
1111
"read properly" in {
1212
benchmark.avSystemGenCodec() shouldBe benchmark.obj
13-
//FIXME: borer parses up to 200 digits only
14-
//benchmark.borer() shouldBe benchmark.obj
13+
// FIXME: borer parses up to 200 digits only
14+
// benchmark.borer() shouldBe benchmark.obj
1515
benchmark.circe() shouldBe benchmark.obj
16-
//FIXME: circe-jsoniter parses up to 308 digits only
17-
//benchmark.circeJsoniter() shouldBe benchmark.obj
16+
// FIXME: circe-jsoniter parses up to 308 digits only
17+
// benchmark.circeJsoniter() shouldBe benchmark.obj
1818
benchmark.jsoniterScala() shouldBe benchmark.obj
19-
//FIXME: Play-JSON looses significant digits in BigInt values
20-
//benchmark.playJson() shouldBe benchmark.obj
19+
// FIXME: Play-JSON looses significant digits in BigInt values
20+
// benchmark.playJson() shouldBe benchmark.obj
2121
// FIXME: smithy4sJson parses up to 308 digits only
22-
//benchmark.smithy4sJson() shouldBe benchmark.obj
22+
// benchmark.smithy4sJson() shouldBe benchmark.obj
2323
benchmark.uPickle() shouldBe benchmark.obj
2424
benchmark.zioJson() shouldBe benchmark.obj
2525
}
2626
"fail on invalid input" in {
2727
val b = benchmark
2828
b.jsonBytes = "{}".getBytes(UTF_8)
2929
intercept[Throwable](b.avSystemGenCodec())
30-
//FIXME: borer parses up to 200 digits only
31-
//intercept[Throwable](b.borer())
30+
// FIXME: borer parses up to 200 digits only
31+
// intercept[Throwable](b.borer())
3232
intercept[Throwable](b.circe())
33-
//FIXME: circe-jsoniter parses up to 308 digits only
34-
//intercept[Throwable](b.circeJsoniter())
33+
// FIXME: circe-jsoniter parses up to 308 digits only
34+
// intercept[Throwable](b.circeJsoniter())
3535
intercept[Throwable](b.jsoniterScala())
3636
// FIXME: smithy4sJson parses up to 308 digits only
37-
//intercept[Throwable](b.smithy4sJson())
37+
// intercept[Throwable](b.smithy4sJson())
3838
intercept[Throwable](b.uPickle())
3939
intercept[Throwable](b.zioJson())
4040
}

‎jsoniter-scala-benchmark/js/src/test/scala-2/com/github/plokhotnyuk/jsoniter_scala/benchmark/BigIntWritingSpec.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class BigIntWritingSpec extends BenchmarkSpecBase {
1414
toString(b.circeJsoniter()) shouldBe b.jsonString
1515
toString(b.jsoniterScala()) shouldBe b.jsonString
1616
toString(b.preallocatedBuf, 64, b.jsoniterScalaPrealloc()) shouldBe b.jsonString
17-
//FIXME: Play-JSON serializes BigInt values as floating point numbers with a scientific representation
17+
// FIXME: Play-JSON serializes BigInt values as floating point numbers with a scientific representation
1818
//toString(b.playJson()) shouldBe b.jsonString
1919
toString(b.playJsonJsoniter()) shouldBe b.jsonString
2020
toString(b.smithy4sJson()) shouldBe b.jsonString

0 commit comments

Comments
 (0)